New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 606023 link

Starred by 1 user
Status: Fixed
Owner:
█ joenotcharles@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
█ caitkp@chromium.org
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove OffDomainInclusionDetector

Project Member Reported by joenotcharles@chromium.org, Apr 22 2016 
https://bugs.chromium.org/p/chromium/issues/detail?id=576750 disabled OffDomainInclusionDetector because its results were not used and it was slowing down resource load. I believe we have no plans to start using it again so the code should be removed entirely.

Comment 1 by joenotcharles@chromium.org, Apr 22 2016

Owner: joenotcharles@chromium.org

Comment 2 by vakh@chromium.org, May 6 2016

Labels: SafeBrowsing-Triaged
Project Member

Comment 3 by bugdroid1@chromium.org, May 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14968931960567f7985f97f28322d8e82f6497a8

commit 14968931960567f7985f97f28322d8e82f6497a8
Author: joenotcharles <joenotcharles@chromium.org>
Date: Mon May 16 21:06:51 2016

Remove the unused OffDomainInclusionDetector

BUG= 606023 

Review-Url: https://codereview.chromium.org/1970823002
Cr-Commit-Position: refs/heads/master@{#393914}

[delete] https://crrev.com/66b5ab718cb4cf10180e2ce458dbddd9db300a25/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector.cc
[delete] https://crrev.com/66b5ab718cb4cf10180e2ce458dbddd9db300a25/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector.h
[delete] https://crrev.com/66b5ab718cb4cf10180e2ce458dbddd9db300a25/chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/chrome/browser/safe_browsing/local_database_manager.cc
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/chrome/browser/safe_browsing/local_database_manager.h
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/chrome/browser/safe_browsing/safe_browsing_database.cc
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/chrome/browser/safe_browsing/safe_browsing_database.h
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/chrome/browser/safe_browsing/safe_browsing_service.h
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/chrome/chrome_browser.gypi
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/components/safe_browsing_db/database_manager.h
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/components/safe_browsing_db/remote_database_manager.cc
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/components/safe_browsing_db/remote_database_manager.h
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/components/safe_browsing_db/test_database_manager.cc
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/components/safe_browsing_db/test_database_manager.h
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/components/safe_browsing_db/util.cc
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/components/safe_browsing_db/util.h
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/components/safe_browsing_db/v4_local_database_manager.cc
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/components/safe_browsing_db/v4_local_database_manager.h
[modify] https://crrev.com/14968931960567f7985f97f28322d8e82f6497a8/tools/metrics/histograms/histograms.xml

Comment 4 by joenotcharles@chromium.org, May 16 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment