New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605987 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

Pin Chromium's dEQP DEPS to ANGLE's DEPS

Project Member Reported by jmad...@chromium.org, Apr 22 2016

Issue description

ANGLE is the host for the build files for dEQP, so really both the build files and DEPS revision should be there. We can achieve this using the "From" feature in gclient's DEPS management. This will also make life easier for Vulkan, which will need ANGLE to manage the layers and loader repo.
 
Summary: Pin Chromium's dEQP DEPS to ANGLE's DEPS (was: Ping Chromium's dEQP DEPS to ANGLE's DEPS)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60783171abc3fc122aeefd9a3705193e9191ccd9

commit 60783171abc3fc122aeefd9a3705193e9191ccd9
Author: jmadill <jmadill@chromium.org>
Date: Fri Apr 22 22:03:22 2016

Pin dEQP to ANGLE's DEPS file.

This will make rolling a new dEQP version in ANGLE testable on the
bots.

BUG= 605987 

Review URL: https://codereview.chromium.org/1912153003

Cr-Commit-Position: refs/heads/master@{#389262}

[modify] https://crrev.com/60783171abc3fc122aeefd9a3705193e9191ccd9/DEPS

Status: Fixed (was: Started)
Status: Started (was: Fixed)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6376c2c38f5bbd6f56a89794f5003cce2aa89c2

commit a6376c2c38f5bbd6f56a89794f5003cce2aa89c2
Author: jmadill <jmadill@chromium.org>
Date: Sun Apr 24 02:34:38 2016

Revert of Pin dEQP to ANGLE's DEPS file. (patchset #1 id:1 of https://codereview.chromium.org/1912153003/ )

Reason for revert:
Using unsupported syntax, could possibly be breaking the ANGLE CQ.

BUG= 606150 

Original issue's description:
> Pin dEQP to ANGLE's DEPS file.
>
> This will make rolling a new dEQP version in ANGLE testable on the
> bots.
>
> BUG= 605987 
>
> Committed: https://crrev.com/60783171abc3fc122aeefd9a3705193e9191ccd9
> Cr-Commit-Position: refs/heads/master@{#389262}

TBR=maruel@chromium.org,kbr@chromium.org,kjellander@chromium.org,iannucci@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 605987 

Review URL: https://codereview.chromium.org/1914843003

Cr-Commit-Position: refs/heads/master@{#389396}

[modify] https://crrev.com/a6376c2c38f5bbd6f56a89794f5003cce2aa89c2/DEPS

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6376c2c38f5bbd6f56a89794f5003cce2aa89c2

commit a6376c2c38f5bbd6f56a89794f5003cce2aa89c2
Author: jmadill <jmadill@chromium.org>
Date: Sun Apr 24 02:34:38 2016

Revert of Pin dEQP to ANGLE's DEPS file. (patchset #1 id:1 of https://codereview.chromium.org/1912153003/ )

Reason for revert:
Using unsupported syntax, could possibly be breaking the ANGLE CQ.

BUG= 606150 

Original issue's description:
> Pin dEQP to ANGLE's DEPS file.
>
> This will make rolling a new dEQP version in ANGLE testable on the
> bots.
>
> BUG= 605987 
>
> Committed: https://crrev.com/60783171abc3fc122aeefd9a3705193e9191ccd9
> Cr-Commit-Position: refs/heads/master@{#389262}

TBR=maruel@chromium.org,kbr@chromium.org,kjellander@chromium.org,iannucci@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 605987 

Review URL: https://codereview.chromium.org/1914843003

Cr-Commit-Position: refs/heads/master@{#389396}

[modify] https://crrev.com/a6376c2c38f5bbd6f56a89794f5003cce2aa89c2/DEPS

Blocking: angleproject:1319
Project Member

Comment 8 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/8c9e4d54d3300317a8f5e5441064760c445727c8

commit 8c9e4d54d3300317a8f5e5441064760c445727c8
Author: Jamie Madill <jmadill@chromium.org>
Date: Fri May 06 16:13:10 2016

Add DEPS.chromium to share dEQP deps with Chrome.

This file will allow ANGLE to update the build files and roll dEQP
in the same CL, making life a pleasure to live for maintainers.

BUG= chromium:605987 

Change-Id: I8f574e80a5f7b176f08a9f51c2369e042cae56b7
Reviewed-on: https://chromium-review.googlesource.com/343010
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[add] https://crrev.com/8c9e4d54d3300317a8f5e5441064760c445727c8/DEPS.chromium

Project Member

Comment 9 by bugdroid1@chromium.org, May 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b772275d9555449120cbc756bd11d0fceb4dd8cc

commit b772275d9555449120cbc756bd11d0fceb4dd8cc
Author: jmadill <jmadill@chromium.org>
Date: Tue May 10 15:52:41 2016

Roll ANGLE a314b61..8c9e4d5

https://chromium.googlesource.com/angle/angle.git/+log/a314b61..8c9e4d5

BUG= chromium:605987 , 605775 
TBR=geofflang@chromium.org
TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/1959243003
Cr-Commit-Position: refs/heads/master@{#392619}

[modify] https://crrev.com/b772275d9555449120cbc756bd11d0fceb4dd8cc/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, May 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf887ad07e2d7fb199832c52c87cc1647c826806

commit bf887ad07e2d7fb199832c52c87cc1647c826806
Author: jmadill <jmadill@chromium.org>
Date: Tue May 10 20:23:30 2016

Pin dEQP DEPS to ANGLE's DEPS.chromium.

This file will manage which dEQP revision Chrome checks out. This
allows ANGLE to roll dEQP in the same CL as it updates the build
files, which makes testing on the bots possible.

BUG= 605987 
R=iannucci@chromium.org

Review-Url: https://codereview.chromium.org/1966743002
Cr-Commit-Position: refs/heads/master@{#392697}

[modify] https://crrev.com/bf887ad07e2d7fb199832c52c87cc1647c826806/DEPS

Project Member

Comment 11 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b627a76883d422736db77ef71fafe26d7f3b3812

commit b627a76883d422736db77ef71fafe26d7f3b3812
Author: mmoss <mmoss@google.com>
Date: Wed May 11 15:33:00 2016

Revert of Pin dEQP DEPS to ANGLE's DEPS.chromium. (patchset #1 id:1 of https://codereview.chromium.org/1966743002/ )

Reason for revert:
Using "recursedeps" broke buildspec creation.

Original issue's description:
> Pin dEQP DEPS to ANGLE's DEPS.chromium.
>
> This file will manage which dEQP revision Chrome checks out. This
> allows ANGLE to roll dEQP in the same CL as it updates the build
> files, which makes testing on the bots possible.
>
> BUG= 605987 
> R=iannucci@chromium.org
>
> Committed: https://crrev.com/bf887ad07e2d7fb199832c52c87cc1647c826806
> Cr-Commit-Position: refs/heads/master@{#392697}

TBR=iannucci@chromium.org,dpranke@chromium.org,agable@chromium.org,jmadill@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 605987 

Review-Url: https://codereview.chromium.org/1966243002
Cr-Commit-Position: refs/heads/master@{#392930}

[modify] https://crrev.com/b627a76883d422736db77ef71fafe26d7f3b3812/DEPS

Cc: jmad...@chromium.org
Labels: -Pri-3 -merge-merged-2716 Pri-2
Owner: mmoss@chromium.org
Status: Assigned (was: Started)
Michael, can you update this issue when you have made progress on the buildspec files workaround? Sending your way.
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=88883

------------------------------------------------------------------
r88883 | mmoss@google.com | 2016-06-16T13:37:00.381895Z

-----------------------------------------------------------------
Cc: mmoss@chromium.org
Owner: jmad...@chromium.org
Thanks Michael, grabbing this back to try landing my DEPS change.
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2dfc8fbfccf3228b6c8ed8c1ccf071559f5523e

commit d2dfc8fbfccf3228b6c8ed8c1ccf071559f5523e
Author: jmadill <jmadill@chromium.org>
Date: Thu Jun 16 16:25:13 2016

Reland of Pin dEQP DEPS to ANGLE's DEPS.chromium. (patchset #1 id:1 of https://codereview.chromium.org/1966243002/ )

Reason for revert:
buildspec creation should be now fixed.

Original issue's description:
> Revert of Pin dEQP DEPS to ANGLE's DEPS.chromium. (patchset #1 id:1 of https://codereview.chromium.org/1966743002/ )
>
> Reason for revert:
> Using "recursedeps" broke buildspec creation.
>
> Original issue's description:
> > Pin dEQP DEPS to ANGLE's DEPS.chromium.
> >
> > This file will manage which dEQP revision Chrome checks out. This
> > allows ANGLE to roll dEQP in the same CL as it updates the build
> > files, which makes testing on the bots possible.
> >
> > BUG= 605987 
> > R=iannucci@chromium.org
> >
> > Committed: https://crrev.com/bf887ad07e2d7fb199832c52c87cc1647c826806
> > Cr-Commit-Position: refs/heads/master@{#392697}
>
> TBR=iannucci@chromium.org,dpranke@chromium.org,agable@chromium.org,jmadill@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 605987 
>
> Committed: https://crrev.com/b627a76883d422736db77ef71fafe26d7f3b3812
> Cr-Commit-Position: refs/heads/master@{#392930}

TBR=iannucci@chromium.org,dpranke@chromium.org,agable@chromium.org,mmoss@chromium.org,mmoss@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 605987 

Review-Url: https://codereview.chromium.org/2066993006
Cr-Commit-Position: refs/heads/master@{#400169}

[modify] https://crrev.com/d2dfc8fbfccf3228b6c8ed8c1ccf071559f5523e/DEPS

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41d9f834db0041a7789eb79b63305982635c336a

commit 41d9f834db0041a7789eb79b63305982635c336a
Author: jmadill <jmadill@chromium.org>
Date: Thu Sep 08 19:57:16 2016

Add ANGLE vulkan GN to gypi whitelist.

ANGLE still uses GYP for a standalone build. Until we switch to full
GN (not currently being worked on) we need this script for all of our
build files.

BUG= 605987 

Review-Url: https://codereview.chromium.org/2320743002
Cr-Commit-Position: refs/heads/master@{#417374}

[modify] https://crrev.com/41d9f834db0041a7789eb79b63305982635c336a/.gn

Blocking: -angleproject:1319
Status: Fixed (was: Assigned)

Sign in to add a comment