Issue metadata
Sign in to add a comment
|
Classic not working when navigating to a new page via omnibox without tabbing |
||||||||||||||||||||||
Issue descriptionWhen navigating to a new site with the below steps, we accidentally force focus back onto the omnibox. - ctrl+l - type an address - hit enter result: we stay in compat mode and we see focus is on the omnibox. expected: focus in webpage; navigation should go from initial focus/beginning of dom.
,
Apr 22 2016
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f2b437436f41145c774d485602bd61edefc443c commit 5f2b437436f41145c774d485602bd61edefc443c Author: dtseng <dtseng@chromium.org> Date: Thu Apr 28 00:00:57 2016 Use forceClickOnCurrentItem to mean doDefault action rather than performDefaultAction When navigating to a new site with the below steps, we accidentally force focus back onto the omnibox. - ctrl+l - type an address - hit enter result: we stay in compat mode and we see focus is on the omnibox. This is because: - when we place focus via ctrl+l, we switch to compat mode - that results in a switch to the classic keymap - the classic keymap binds the enter key to performDefaultAction - in cvox2/background/backgorund.js, performDefaultAction does a |doDefault| action which sends a click - after entering an address, we "click" the address bar - this is racey with the focus generated by the webview Solve this by using the forceClickOnCurrentItem command (which is mapped to Cvox+space) to mean doDefault. This matches classic behavior. performDefaultAction in classic simply meant placing focus correctly when encountering internal links. TEST=navigate between sites via the above reproduction; ensure classic is on and working. BUG= 605980 Review-Url: https://codereview.chromium.org/1915603002 Cr-Commit-Position: refs/heads/master@{#390248} [modify] https://crrev.com/5f2b437436f41145c774d485602bd61edefc443c/chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json [modify] https://crrev.com/5f2b437436f41145c774d485602bd61edefc443c/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
,
May 2 2016
,
May 2 2016
,
May 2 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 2 2016
[Automated comment] We don't branch for M52 for another 16 days, was this request meant for M51?
,
May 2 2016
,
May 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/859c7c4f180588db01d041093731ba701a9019da commit 859c7c4f180588db01d041093731ba701a9019da Author: David Tseng <dtseng@chromium.org> Date: Wed May 04 20:44:25 2016 Use forceClickOnCurrentItem to mean doDefault action rather than performDefaul\ tAction When navigating to a new site with the below steps, we accidentally force focu\ s back onto the omnibox. - ctrl+l - type an address - hit enter result: we stay in compat mode and we see focus is on the omnibox. This is because: - when we place focus via ctrl+l, we switch to compat mode - that results in a switch to the classic keymap -UU-:----F1 cl_descriptionSCqLE6 Top L1 (Fundamental) ------------------# Enter a description of the change. Merge to m51: Use forceClickOnCurrentItem to mean doDefault action rather than performDefaultAction When navigating to a new site with the below steps, we accidentally force focus back onto the omnibox. - ctrl+l - type an address - hit enter result: we stay in compat mode and we see focus is on the omnibox. This is because: - when we place focus via ctrl+l, we switch to compat mode - that results in a switch to the classic keymap - the classic keymap binds the enter key to performDefaultAction - in cvox2/background/backgorund.js, performDefaultAction does a |doDefault| action which sends a click - after entering an address, we "click" the address bar - this is racey with the focus generated by the webview Solve this by using the forceClickOnCurrentItem command (which is mapped to Cvox+space) to mean doDefault. This matches classic behavior. performDefaultAction in classic simply meant placing focus correctly when encountering internal links. TEST=navigate between sites via the above reproduction; ensure classic is on and working. BUG= 605980 Review-Url: https://codereview.chromium.org/1915603002 Cr-Commit-Position: refs/heads/master@{#390248} (cherry picked from commit 5f2b437436f41145c774d485602bd61edefc443c) Review URL: https://codereview.chromium.org/1952803002 . Cr-Commit-Position: refs/branch-heads/2704@{#377} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/859c7c4f180588db01d041093731ba701a9019da/chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json [modify] https://crrev.com/859c7c4f180588db01d041093731ba701a9019da/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
,
May 17 2016
verified on 52.0.2734.0 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dtseng@chromium.org
, Apr 22 2016