New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605958 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

Darken toolbar icons with light theme colors

Project Member Reported by rolfe@chromium.org, Apr 22 2016

Issue description

Assigning to you, yusufo@ but feel free to delegate. Hoping this is an easy fix.

Dark themes are consistently white across the icons and origin text. Light themes default to the 5a5a5a gray used in the standard gray toolbar (see images.)  Ainslie@ proposes making the icons on theme-header toolbars be the same color as the origin in the omnibox. Ok'd by bettes@ and myself.
 
light.png
66.8 KB View Download
dark.png
65.2 KB View Download

Comment 1 by yus...@chromium.org, Apr 25 2016

Labels: M-52
Should be an easy fix, yes. Adding a milestone to make sure this doesn't get lost.

Comment 2 by hwi@chromium.org, May 13 2016

yusufo@: 
When you have a chance -- Q: what's the current value of the origin text in the code? I'm looking to see if we can unify the color for 1) origin text, 2) toolbar icons, 3) progress bar (determinate). Thanks!

Comment 3 by k...@chromium.org, May 25 2016

Owner: mdjones@chromium.org
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 12 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Assigned)
Fixed with https://codereview.chromium.org/2111693002/.

Sign in to add a comment