Make Frame Viewer work without layer hierarchy |
||
Issue descriptionLayerImpl::AsValueInto is used by tracing (for Frame Viewer). This currently recurses over the layer tree and includes the tree structure in the output TracedValue. This needs to be changed to iterate over the layer list. And Frame Viewer needs to be changed so that it doesn't expect the TracedValue to have a tree structure. We might need to add some other information to keep the tracing output useful, particularly so long as the main thread layer tree continues to exist (e.g. maybe we need to push a parent_id from Layer to LayerImpl and include this in the output).
,
May 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6740fc94a0b0258691340092cbc0691a13d05b9a commit 6740fc94a0b0258691340092cbc0691a13d05b9a Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Thu May 05 23:47:04 2016 Roll src/third_party/catapult/ 0f4d6256a..5a77ca6c9 (2 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0f4d6256ad5c..5a77ca6c9cfd $ git log 0f4d6256a..5a77ca6c9 --date=short --no-merges --format='%ad %ae %s' BUG=605665, 605940 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/1949713006 Cr-Commit-Position: refs/heads/master@{#391954} [modify] https://crrev.com/6740fc94a0b0258691340092cbc0691a13d05b9a/DEPS
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3971e0b42893122987ca9647055a079eb1e01e3d commit 3971e0b42893122987ca9647055a079eb1e01e3d Author: sunxd <sunxd@chromium.org> Date: Fri Jun 03 17:31:11 2016 cc: Make LayerTreeImpl dump layer list to FrameViewer and Devtools As compositor will no longer know tree hierarchy information, it is expected to dump a layer list instead of a layer tree to chrome tracing. The value root_layer is also deleted because it is used to judge whether the dumped layer_tree_impl has a list or not on the FrameViewer side. Chrome://tracing will show a layer_tree_impl without depth, this is expected. This CL is blocked by Issue 1947553002, and potentially influenced by the LayerTreeImpl's JSON issue. Devtools need to deal with the new format information. On the devtools side, we make the first drawsContent layer "contentRoot" and treat all other layers as the contentRoot's child. BUG= 605940 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/1945813002 Cr-Commit-Position: refs/heads/master@{#397744} [modify] https://crrev.com/3971e0b42893122987ca9647055a079eb1e01e3d/cc/layers/layer_impl.cc [modify] https://crrev.com/3971e0b42893122987ca9647055a079eb1e01e3d/cc/trees/layer_tree_host.cc [modify] https://crrev.com/3971e0b42893122987ca9647055a079eb1e01e3d/cc/trees/layer_tree_host.h [modify] https://crrev.com/3971e0b42893122987ca9647055a079eb1e01e3d/cc/trees/layer_tree_impl.cc [modify] https://crrev.com/3971e0b42893122987ca9647055a079eb1e01e3d/cc/trees/layer_tree_impl.h [modify] https://crrev.com/3971e0b42893122987ca9647055a079eb1e01e3d/third_party/WebKit/LayoutTests/inspector/tracing/layer-tree-expected.txt [modify] https://crrev.com/3971e0b42893122987ca9647055a079eb1e01e3d/third_party/WebKit/Source/devtools/front_end/timeline_model/LayerTreeModel.js [modify] https://crrev.com/3971e0b42893122987ca9647055a079eb1e01e3d/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js
,
Jun 7 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by sunxd@chromium.org
, Apr 26 2016Status: Assigned (was: Available)