New issue
Advanced search Search tips

Issue 605930 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 341477



Sign in to add a comment

Password import should not (even try to) overwrite the existing credentials

Project Member Reported by vabr@chromium.org, Apr 22 2016

Issue description

The current design (not accessible yet,  bug 605929 ) for importing passwords states that the import should overwrite the stored credentials.

This does not seem like a good idea (1), and it is not what happens (2).

Ad (1): If the origin, username and password are the same in the stored and imported credential, then overwriting it will result just in removing the metadata. This has no positive effect and breaks autofilling. In general, overwriting seems to be a potentially dangerous and unnecessary work.

Ad (2): If one attempts to import an already existing credential (such that the DB unique key of both matches, the DB refuses (according to the logs) to overwrite the data. That's because Chrome uses PasswordStore::AddLogin for that, instead of UpdateLogin.


We should keep the behaviour (of not overwriting the credentials), but do it in a way which does not generate DB errors. We also need to update the design doc.
 

Comment 1 by vabr@chromium.org, Apr 22 2016

Labels: Hotlist-Polish
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 24 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by vabr@chromium.org, Apr 25 2017

Status: Available (was: Untriaged)
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 25 2018

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by vabr@chromium.org, Apr 26 2018

Status: WontFix (was: Untriaged)
No active development on the import feature. If it gets restarted, a new design doc will be made and corner cases like this one discussed.

Sign in to add a comment