Regression: In Switch person window, warning icon appears after a delay for locked profile,
Reported by
vvishwak...@etouch.net,
Apr 22 2016
|
|||||
Issue descriptionVersion: 52.0.2715.0 (Official Build) 3fae42f136f929251b627b2ae6300100afc8ab83-refs/heads/master@{#388964} (32/64-bit) OS: Linux(14.04 LTS), Mac OS X(10.10.5, 10.11.4), Windows (7,8,8.1,10) What steps will reproduce the problem? 1) Launch chrome, Sign in to chrome and from chrome://settings add/import a supervised user. 2) In main user, click on avatar icon and select 'Exit and childlock' option (Switch person window opens). 3) In Switch person window observe main user (locked profile). For locked profile, warning icon appears after a delay. For locked profile, warning icon should appear immediately. This is a Regression issue broken in M-52, below is the bisect info Manual bisect Good build: 52.0.2712.0 Bad build: 52.0.2713.0 Note: Issue is not reproducible on Chromium builds as not able to Sign in to chrome, hence providing suspect from Changelog URL. Changelog URL: https://chromium.googlesource.com/chromium/src/+log/52.0.2712.0..52.0.2713.0?pretty=fuller&n=10000 Suspecting: r388145
,
Apr 27 2016
My changes were related to the profile chooser view UI, which shouldn't cause this issue. Found the recent change in ProfileWindow by lwchkg@: https://codereview.chromium.org/1794353003. lwchkg@, can you please take a look? Thanks. (Cannot assign to lwchkg@, so assigned to the cl reviewer: mlerman@)
,
Apr 27 2016
I am unable to reproduce the icon in the videos, neither the "expected" and the "actual" version. Anyway, the warning icon does not seems to mean that the account is signed out. I don't know it's exact meaning though. (Maybe sync error?) mlerman@: do you know what does the yellow warning icon in the user manager mean?
,
Apr 27 2016
Sorry for quick comment... Now I've reproduced the issue with the help of issue 585082 (see comment #6 by mlerman@). The meaning of the yellow icon is the absence of some "auth credential (password hash)". See issue 514589 for why it is added.
,
Apr 27 2016
Just investigated the issue. The user-pods has been loaded correctly, but the warning iron-icon is lazy-loaded, so it shows after a delay. Suspecting https://crrev.com/386789. Mike: can you reassign the bug to jdufault@?
,
Apr 27 2016
,
Apr 27 2016
jdufault@: can you please take a look? Thanks.
,
Apr 27 2016
That user-pod row is also used on the cros lockscreen. Loading the icon pulls in polymer, which can take quite some time. I'll see if we can avoid the loading delay for the icon. I may have to just rewrite the icon to not use polymer.
,
Apr 28 2016
Removing the usage of iron-icon is tricky because the warning icon is an SVG file. In particular, theming the SVG icon (to make it yellow) requires embedding it directly into the DOM; ultimately this requires JS specifically for this scenario. I've opted instead to just remove the 1s delay after the 'load' event fires. While there will still be a period of time between seeing the first paint and seeing the warning icon, it should be significantly shorter. Removing the additional 1s delay does not appear to introduce any performance regressions when loading the lock screen. If the new delay is still too annoying/noticeable, I think the best solution is to just load polymer immediately but only when not on the lock screen. https://codereview.chromium.org/1925453005/
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/637d3009b75b4837c9a151e84615f57b984a8fa2 commit 637d3009b75b4837c9a151e84615f57b984a8fa2 Author: jdufault <jdufault@chromium.org> Date: Wed May 11 23:59:24 2016 Remove most of the loading delay for warning icon. This does not appear to cause any performance regressions when loading the lock screen. BUG= 605893 Review-Url: https://codereview.chromium.org/1925453005 Cr-Commit-Position: refs/heads/master@{#393111} [modify] https://crrev.com/637d3009b75b4837c9a151e84615f57b984a8fa2/ui/login/account_picker/user_pod_template.js
,
May 13 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dcheng@chromium.org
, Apr 22 2016