Issue metadata
Sign in to add a comment
|
Regression: App image is not seen properly on 'App info' overlay in chrome://appps page.
Reported by
rk...@etouch.net,
Apr 22 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 52.0.2715.0 Revision 3fae42f136f929251b627b2ae6300100afc8ab83-refs/heads/master@{#388964}(32/64 bit) OS: Windows(7,8,8.1,10), Linux (14.04 LTS) What steps will reproduce the problem? (1) Launch chrome and go to chrome://apps page. (2) Drag the Webstore link at bottom into chrome://apps page (shortcut is created). (3) Right click on Webstore shortcut, select 'App info' option and observe the app image on app info overlay. App image is not seen properly i.e. upper boarder is not seen on app info overlay. App image should seen properly. This is a regression issue, broken in 'M-51' , below is bisect info: Good Build: 51.0.2694.0 Bad Build: 51.0.2695.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/21832bf93e466609a4a497e0d67e8f865ab2e13f..bb82fe13a37b08e56ac801360d4cbf5eeba7a9dd?pretty=fuller&n=100 Suspecting: r384118 ? or r384114 ? Note: Issue is not seen on Mac(10.10.5, 10.11.4) OS.
,
Apr 25 2016
the way the icon looks different points to the resource loading change being the culprit imo
,
Apr 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50ed8e6dddc43144f9aad3d08aab379e19df97a3 commit 50ed8e6dddc43144f9aad3d08aab379e19df97a3 Author: oshima <oshima@chromium.org> Date: Fri Apr 29 04:09:49 2016 Default icon should use the image skia created by ResourceBundle Current code gets 2x image first then shrink to 1x. It should simply use the image skia created by ResourceBundle. BUG= 605884 Review-Url: https://codereview.chromium.org/1916883003 Cr-Commit-Position: refs/heads/master@{#390590} [modify] https://crrev.com/50ed8e6dddc43144f9aad3d08aab379e19df97a3/chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc
,
Apr 29 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nyerramilli@chromium.org
, Apr 22 2016