New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 605880 link

Starred by 1 user
Status: Fixed
Owner:
thestig@chromium.org
Closed: Sep 25
Cc:
█ lionel.g...@intel.com
pfeldman@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Dr. Memory reports a NULL dereference in WTF::HashTable<>::lookup<>

Project Member Reported by glider@chromium.org, Apr 22 2016 
The below report is from https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%20%28DrMemory%20full%29%20%289%29/builds/2459/steps/memory%20test%3A%20browser_tests_1/logs/D6B72445FA442471:

UNADDRESSABLE ACCESS: reading 0x00000008-0x0000000c 4 byte(s)
# 0 blink_platform.dll!WTF::HashTable<>::lookup<>                              [third_party\webkit\source\wtf\hashtable.h:652]
# 1 blink_platform.dll!blink::protocol::DictionaryValue::get                   [third_party\webkit\source\platform\inspector_protocol\values.cpp:243]
# 2 blink_platform.dll!blink::protocol::DictionaryValue::getBoolean            [third_party\webkit\source\platform\inspector_protocol\values.cpp:217]
# 3 blink_platform.dll!blink::protocol::DictionaryValue::booleanProperty       [third_party\webkit\source\platform\inspector_protocol\values.cpp:258]
# 4 webcore_shared.dll!blink::InspectorCSSAgent::wasEnabled                    [third_party\webkit\source\core\inspector\inspectorcssagent.cpp:681]
# 5 webcore_shared.dll!blink::InspectorCSSAgent::resourceContentLoaded         [third_party\webkit\source\core\inspector\inspectorcssagent.cpp:675]
# 6 webcore_shared.dll!WTF::PartBoundFunctionImpl<>::operator()                [third_party\webkit\source\wtf\functional.h:275]
# 7 webcore_shared.dll!blink::InspectorResourceContentLoader::resourceFinished [third_party\webkit\source\core\inspector\inspectorresourcecontentloader.cpp:210]
# 8 webcore_shared.dll!blink::InspectorResourceContentLoader::ResourceClient::resourceFinished [third_party\webkit\source\core\inspector\inspectorresourcecontentloader.cpp:60]
# 9 webcore_shared.dll!blink::Resource::checkNotify                            [third_party\webkit\source\core\fetch\resource.cpp:284]
#10 webcore_shared.dll!blink::Resource::finish                                 [third_party\webkit\source\core\fetch\resource.cpp:348]
#11 content.dll!content::WebURLLoaderImpl::Context::OnCompletedRequest         [content\child\web_url_loader_impl.cc:759]
#12 content.dll!content::WebURLLoaderImpl::RequestPeerImpl::OnCompletedRequest [content\child\web_url_loader_impl.cc:905]
#13 content.dll!content::ResourceDispatcher::OnRequestComplete                 [content\child\resource_dispatcher.cc:376]
#14 content.dll!IPC::DispatchToMethod<>                                        [ipc\ipc_message_templates.h:26]
#15 content.dll!IPC::MessageT<>::Dispatch<>                                    [ipc\ipc_message_templates.h:121]
#16 content.dll!content::ResourceDispatcher::DispatchMessageW                  [content\child\resource_dispatcher.cc:507]
#17 content.dll!content::ResourceDispatcher::OnMessageReceived                 [content\child\resource_dispatcher.cc:124]
#18 content.dll!content::`anonymous namespace'::DispatchMessageTask::run       [content\child\resource_scheduling_filter.cc:31]
#19 scheduler.dll!scheduler::WebTaskRunnerImpl::runTask                        [components\scheduler\child\web_task_runner_impl.cc:68]
#20 scheduler.dll!base::internal::Invoker<>::Run                               [base\bind_internal.h:372]
#21 base.dll!base::debug::TaskAnnotator::RunTask                               [base\debug\task_annotator.cc:51]
#22 scheduler.dll!scheduler::TaskQueueManager::ProcessTaskFromWorkQueue        [components\scheduler\base\task_queue_manager.cc:289]
#23 scheduler.dll!scheduler::TaskQueueManager::DoWork                          [components\scheduler\base\task_queue_manager.cc:201]
#24 scheduler.dll!base::internal::Invoker<>::Run                               [base\bind_internal.h:372]
#25 base.dll!base::debug::TaskAnnotator::RunTask                               [base\debug\task_annotator.cc:51]
#26 base.dll!base::MessageLoop::RunTask                                        [base\message_loop\message_loop.cc:479]
#27 base.dll!base::MessageLoop::DeferOrRunPendingTask                          [base\message_loop\message_loop.cc:488]
#28 base.dll!base::MessageLoop::DoWork                                         [base\message_loop\message_loop.cc:600]
#29 base.dll!base::MessagePumpDefault::Run                                     [base\message_loop\message_pump_default.cc:33]
#30 base.dll!base::MessageLoop::RunHandler                                     [base\message_loop\message_loop.cc:443]
#31 base.dll!base::MessageLoop::Run                                            [base\message_loop\message_loop.cc:295]
#32 content.dll!content::RendererMain                                          [content\renderer\renderer_main.cc:219]
#33 content.dll!content::RunNamedProcessTypeMain                               [content\app\content_main_runner.cc:381]
#34 content.dll!content::ContentMainRunnerImpl::Run                            [content\app\content_main_runner.cc:742]
#35 content.dll!content::ContentMain                                           [content\app\content_main.cc:20]
#36 content::LaunchTests                                                       [content\public\test\test_launcher.cc:523]
#37 LaunchChromeTests                                                          [chrome\test\base\chrome_test_launcher.cc:126]
#38 main                                                                       [chrome\test\base\browser_tests_main.cc:25]
Note: @0:07:37.340 in thread 3784
Note: instruction: mov    (%ecx) -> %ebx
The report came from the `ExtensionTabsTest.GetWindow` test.
Suppression (error hash=#D6B72445FA442471#):
For more info on using suppressions see http://dev.chromium.org/developers/how-tos/using-drmemory#TOC-Suppressing-error-reports-from-the-
{
UNADDRESSABLE ACCESS
name=<insert_a_suppression_name_here>
blink_platform.dll!WTF::HashTable<>::lookup<>
blink_platform.dll!blink::protocol::DictionaryValue::get
blink_platform.dll!blink::protocol::DictionaryValue::getBoolean
blink_platform.dll!blink::protocol::DictionaryValue::booleanProperty
webcore_shared.dll!blink::InspectorCSSAgent::wasEnabled
webcore_shared.dll!blink::InspectorCSSAgent::resourceContentLoaded
webcore_shared.dll!WTF::PartBoundFunctionImpl<>::operator()
webcore_shared.dll!blink::InspectorResourceContentLoader::resourceFinished
webcore_shared.dll!blink::InspectorResourceContentLoader::ResourceClient::resourceFinished
webcore_shared.dll!blink::Resource::checkNotify
webcore_shared.dll!blink::Resource::finish
content.dll!content::WebURLLoaderImpl::Context::OnCompletedRequest
content.dll!content::WebURLLoaderImpl::RequestPeerImpl::OnCompletedRequest
content.dll!content::ResourceDispatcher::OnRequestComplete
content.dll!IPC::DispatchToMethod<>
content.dll!IPC::MessageT<>::Dispatch<>
content.dll!content::ResourceDispatcher::DispatchMessageW
content.dll!content::ResourceDispatcher::OnMessageReceived
content.dll!content::`anonymous namespace'::DispatchMessageTask::run
scheduler.dll!scheduler::WebTaskRunnerImpl::runTask
scheduler.dll!base::internal::Invoker<>::Run
base.dll!base::debug::TaskAnnotator::RunTask
scheduler.dll!scheduler::TaskQueueManager::ProcessTaskFromWorkQueue
scheduler.dll!scheduler::TaskQueueManager::DoWork
scheduler.dll!base::internal::Invoker<>::Run
base.dll!base::debug::TaskAnnotator::RunTask
base.dll!base::MessageLoop::RunTask
base.dll!base::MessageLoop::DeferOrRunPendingTask
base.dll!base::MessageLoop::DoWork
base.dll!base::MessagePumpDefault::Run
base.dll!base::MessageLoop::RunHandler
base.dll!base::MessageLoop::Run
content.dll!content::RendererMain
content.dll!content::RunNamedProcessTypeMain
content.dll!content::ContentMainRunnerImpl::Run
content.dll!content::ContentMain
*!content::LaunchTests
*!LaunchChromeTests
*!main
}

Daniel, can you take a look, please?
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ad553c5b56bfc52a9d59701dc961dce0cbad8b3

commit 1ad553c5b56bfc52a9d59701dc961dce0cbad8b3
Author: glider <glider@chromium.org>
Date: Fri Apr 22 10:44:51 2016

Disable ExtensionTabsTest.GetWindow on Windows

BUG= 605880 
TBR=dcheng@chromium.org,benwells@chromium.org

Review URL: https://codereview.chromium.org/1908213003

Cr-Commit-Position: refs/heads/master@{#389067}

[modify] https://crrev.com/1ad553c5b56bfc52a9d59701dc961dce0cbad8b3/chrome/browser/extensions/api/tabs/tabs_test.cc

Comment 2 by dcheng@chromium.org, Apr 22 2016

Cc: pfeldman@chromium.org
This looks like something in inspector is broken maybe?

+pfeldman@, any idea what's going on here?
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b89b204e9d257edb60b8ef6ef2f8bbaac58b4f4d

commit b89b204e9d257edb60b8ef6ef2f8bbaac58b4f4d
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Sep 25 08:02:09 2018

Enable ExtensionTabsTest.GetWindow on Windows.

It was previously disabled because it failed under Dr. Memory, but Dr.
Memory has retired.

BUG= 605880 

Change-Id: I3fb233e97a3acd66060447ed2fb3cd92b7019f15
Reviewed-on: https://chromium-review.googlesource.com/1240202
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593856}
[modify] https://crrev.com/b89b204e9d257edb60b8ef6ef2f8bbaac58b4f4d/chrome/browser/extensions/api/tabs/tabs_test.cc

Comment 4 by dcheng@chromium.org, Sep 25

Owner: thestig@chromium.org
Status: Fixed (was: Assigned)
►

Sign in to add a comment