New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 605878 link

Starred by 2 users
Status: Fixed
Owner:
paulir...@chromium.org
Closed: Jun 2016
Cc:
█ lushnikov@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: Get devtools on eslint

Project Member Reported by paulir...@chromium.org, Apr 22 2016 
For ease of review and contributions.

Comment 1 by paulir...@chromium.org, Apr 22 2016 

Two open CLs:

* Issue 1908863002: DevTools: Introduce eslint configuration. - Code Review https://codereview.chromium.org/1908863002/
* Issue 1907263002: DevTools: Fix all outstanding JavaScript style issues. - Code Review https://codereview.chromium.org/1907263002



Open question: once these are landed, shall we add as a precommit/presubmit/npm test script?

Comment 2 by jonathan.garbee@chromium.org, Apr 22 2016 

I approve of a presubmit hook to test the style. The earlier developers see issues the better.

Precommit shouldn't since say, you are doing sloppy work just to get the logic going and commit as you go. You don't want to have to go back to always clean style when you do that before you submit the patch.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98e1b6ea2cb170934465268a8a4d200e17562c5c

commit 98e1b6ea2cb170934465268a8a4d200e17562c5c
Author: paulirish <paulirish@chromium.org>
Date: Fri Apr 22 19:58:04 2016

DevTools: Fix assorted JavaScript style issues.

https://codereview.chromium.org/1908863002/ introduces an eslint-based
style linter. This CL fixes all issues in the project.

BUG= 605878 

Review URL: https://codereview.chromium.org/1907263002

Cr-Commit-Position: refs/heads/master@{#389217}

[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/Runtime.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/animation/AnimationGroupPreviewUI.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/animation/AnimationUI.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/common/Color.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/common/Settings.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/common/TextDictionary.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/common/TextUtils.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/components/CustomPreviewSection.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/components/ExecutionContextModel.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/elements/BezierEditor.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/elements/ElementStatePaneWidget.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElementHighlighter.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/elements/PlatformFontsWidget.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/elements/Spectrum.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHost.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/main/Connections.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/main/OverlayController.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/network/EventSourceMessagesView.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/network/JSONView.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/platform/utilities.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sass/SASSProcessor.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sdk/CookieParser.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorDictionary.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatter.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/toolbox_bootstrap/Toolbox.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/ui/Context.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/ui/KeyboardShortcut.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
[modify] https://crrev.com/98e1b6ea2cb170934465268a8a4d200e17562c5c/third_party/WebKit/Source/devtools/front_end/ui_lazy/PieChart.js
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/410d9b08afb6a5575b680d4aa4f0911448913cd1

commit 410d9b08afb6a5575b680d4aa4f0911448913cd1
Author: paulirish <paulirish@chromium.org>
Date: Sat Apr 23 00:23:17 2016

DevTools: Fix annotation typo landed in cl/1907263002

BUG= 605878 

Review URL: https://codereview.chromium.org/1914773002

Cr-Commit-Position: refs/heads/master@{#389323}

[modify] https://crrev.com/410d9b08afb6a5575b680d4aa4f0911448913cd1/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/410d9b08afb6a5575b680d4aa4f0911448913cd1

commit 410d9b08afb6a5575b680d4aa4f0911448913cd1
Author: paulirish <paulirish@chromium.org>
Date: Sat Apr 23 00:23:17 2016

DevTools: Fix annotation typo landed in cl/1907263002

BUG= 605878 

Review URL: https://codereview.chromium.org/1914773002

Cr-Commit-Position: refs/heads/master@{#389323}

[modify] https://crrev.com/410d9b08afb6a5575b680d4aa4f0911448913cd1/third_party/WebKit/Source/devtools/front_end/profiler/ProfileDataGrid.js
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37e52b98e568d1e2dcbfed59e783816b69c59d83

commit 37e52b98e568d1e2dcbfed59e783816b69c59d83
Author: paulirish <paulirish@chromium.org>
Date: Fri Apr 29 01:48:28 2016

DevTools: Add lint_javascript.py to drive eslint

An install of eslint (and Node.js) is required.
    npm install -g eslint

http://eslint.org/docs/user-guide/getting-started

BUG= 605878 

Review-Url: https://codereview.chromium.org/1907353005
Cr-Commit-Position: refs/heads/master@{#390567}

[modify] https://crrev.com/37e52b98e568d1e2dcbfed59e783816b69c59d83/third_party/WebKit/Source/devtools/front_end/.eslintignore
[add] https://crrev.com/37e52b98e568d1e2dcbfed59e783816b69c59d83/third_party/WebKit/Source/devtools/scripts/lint_javascript.py
Project Member

Comment 8 by bugdroid1@chromium.org, May 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddf9471bf9b0f1b05b5eabd790dda8836a4184d2

commit ddf9471bf9b0f1b05b5eabd790dda8836a4184d2
Author: lushnikov <lushnikov@chromium.org>
Date: Fri May 20 23:37:24 2016

DevTools: add eslint as presubmit hook

The patch sets up eslint as a presubmit hooks for the DevTools frontend.

The hooks validates only modified javascript files
and works blazingly fast.

BUG= 605878 
R=paulirish, dgozman, pfeldman

Review-Url: https://codereview.chromium.org/1992383002
Cr-Commit-Position: refs/heads/master@{#395203}

[modify] https://crrev.com/ddf9471bf9b0f1b05b5eabd790dda8836a4184d2/third_party/WebKit/Source/devtools/PRESUBMIT.py
[modify] https://crrev.com/ddf9471bf9b0f1b05b5eabd790dda8836a4184d2/third_party/WebKit/Source/devtools/front_end/.eslintignore
[modify] https://crrev.com/ddf9471bf9b0f1b05b5eabd790dda8836a4184d2/third_party/WebKit/Source/devtools/front_end/.eslintrc.js
[modify] https://crrev.com/ddf9471bf9b0f1b05b5eabd790dda8836a4184d2/third_party/WebKit/Source/devtools/front_end/formatter_worker.js
[modify] https://crrev.com/ddf9471bf9b0f1b05b5eabd790dda8836a4184d2/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker.js
[modify] https://crrev.com/ddf9471bf9b0f1b05b5eabd790dda8836a4184d2/third_party/WebKit/Source/devtools/front_end/temp_storage_shared_worker.js
[modify] https://crrev.com/ddf9471bf9b0f1b05b5eabd790dda8836a4184d2/third_party/WebKit/Source/devtools/scripts/lint_javascript.py

Comment 9 by paulir...@chromium.org, Jun 8 2016

Cc: lushnikov@chromium.org
Status: Fixed (was: Assigned)
►

Sign in to add a comment