New issue
Advanced search Search tips

Issue 605860 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 354621



Sign in to add a comment

New Win x64 clobber builder failing archive_build step.

Project Member Reported by kjellander@chromium.org, Apr 22 2016

Issue description

The new builder added in https://codereview.chromium.org/1905213002 is failing: https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1/steps/archive_build/logs/stdio

build name: Win_x64
Creating archive chrome-win32.zip ...
WARNING: No files to archive.
chromium_utils.CopyFileToDir(src\out\Release\mini_installer.exe, C:\b\build\slave\Win_x64\chrome_staging\, dest_fn=mini_installer.exe)
Traceback (most recent call last):
  File "C:\b\build\scripts\slave\chromium\archive_build.py", line 665, in <module>
    sys.exit(main())
  File "C:\b\build\scripts\slave\chromium\archive_build.py", line 661, in main
    return s.ArchiveBuild()
  File "C:\b\build\scripts\slave\chromium\archive_build.py", line 489, in ArchiveBuild
    os.path.join(self._staging_dir, stage_subdir), dest_fn=stage_fn)
  File "C:\b\build\scripts\common\chromium_utils.py", line 587, in CopyFileToDir
    raise PathNotFound('Unable to find file %s' % src_path)
common.chromium_utils.PathNotFound: Unable to find file src\out\Release\mini_installer.exe

I guess mini_installer.exe may not be built with GN?
 
Blocking: 354621
Cc: wfh@chromium.org brucedaw...@chromium.org
Components: Build
Labels: Proj-GN-Migration
Status: Started (was: Assigned)
No, mini_installer.exe exists and is being built, but for some reason the bot
is looking in out\Release instead of out\Release_x64.

This is probably a bug in the recipe; looking now ...
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/f635ccd891adb805e29c022540f401c119654fa4

commit f635ccd891adb805e29c022540f401c119654fa4
Author: dpranke@chromium.org <dpranke@chromium.org>
Date: Fri Apr 22 17:07:17 2016

Fix the archive_build step for Win x64.

The recipe code was looking at the build config (Release)
instead of the filesystem directory name (Release_x64) and
as a result the archive_build step has been failing on the
new 'Win x64' builder on the chromium waterfall.

TBR=phajdan.jr@chromium.org, kjellander@chromium.org
BUG= 605860 

Review URL: https://codereview.chromium.org/1913183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300117 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/f635ccd891adb805e29c022540f401c119654fa4/scripts/slave/recipe_modules/chromium/api.py
[modify] https://crrev.com/f635ccd891adb805e29c022540f401c119654fa4/scripts/slave/recipes/chromium.expected/full_chromium_Win_x64.json

Status: Verified (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=86940

------------------------------------------------------------------
r86940 | recipe-roller@chromium.org | 2016-04-22T19:22:48.288037Z

-----------------------------------------------------------------

Sign in to add a comment