New issue
Advanced search Search tips

Issue 605836 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

Remove deprecated RAPPOR metrics

Project Member Reported by dominickn@chromium.org, Apr 22 2016

Issue description

Once the new RAPPOR configuration for low-frequency metrics has rolled out and stabilised ( crbug.com/598520 ), any existing, deprecated metric which has been replaced with a low-frequency one should be removed.
 
Labels: Hotlist-Fixit-Triaged

Comment 2 by raymes@chromium.org, Nov 30 2016

Components: -Security>UX Internals>Permissions>CrowdConsent
Labels: -Pri-2 Pri-3
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5a506a917f583f5aa6e32231f8a7df563dfe170

commit f5a506a917f583f5aa6e32231f8a7df563dfe170
Author: dominickn <dominickn@chromium.org>
Date: Fri Feb 24 03:36:49 2017

Remove deprecated and out of date permissions metrics.

This CL removes:

 - deprecated permissions RAPPOR metrics
 - secure/insecure origin metrics for geolocation, push, durable storage,
   and MidiSysEx (as they are restricted to secure origins)

BUG= 605836 , 638076 

Review-Url: https://codereview.chromium.org/2711513005
Cr-Commit-Position: refs/heads/master@{#452741}

[modify] https://crrev.com/f5a506a917f583f5aa6e32231f8a7df563dfe170/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/f5a506a917f583f5aa6e32231f8a7df563dfe170/tools/metrics/histograms/histograms.xml

Is this done now?
Cc: timloh@chromium.org
I'd say we can probably remove all the RAPPOR permissions metrics now. Let's keep this bug open for tracking that. It'd be a good fixit work. :)

Comment 7 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b5968a849f0e4a6fd6124a2ea4494d420b25d5d

commit 8b5968a849f0e4a6fd6124a2ea4494d420b25d5d
Author: Timothy Loh <timloh@chromium.org>
Date: Tue Nov 14 00:12:24 2017

Remove permission RAPPOR metrics

The permission RAPPOR metrics have long been supplanted by permission
action reporting metrics (via the safebrowsing service). This patch
removes the RAPPOR logging which we no longer need.

Bug:  605836 
Change-Id: Ibdbb394a074d5c1543538a2ffab44617481d2417
Reviewed-on: https://chromium-review.googlesource.com/765561
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516104}
[modify] https://crrev.com/8b5968a849f0e4a6fd6124a2ea4494d420b25d5d/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/8b5968a849f0e4a6fd6124a2ea4494d420b25d5d/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/8b5968a849f0e4a6fd6124a2ea4494d420b25d5d/chrome/browser/permissions/permission_uma_util.h
[modify] https://crrev.com/8b5968a849f0e4a6fd6124a2ea4494d420b25d5d/chrome/browser/permissions/permission_util.cc
[modify] https://crrev.com/8b5968a849f0e4a6fd6124a2ea4494d420b25d5d/tools/metrics/rappor/rappor.xml

Comment 9 by timloh@chromium.org, Nov 14 2017

Cc: -timloh@chromium.org dominickn@chromium.org
Owner: timloh@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment