New issue
Advanced search Search tips

Issue 605833 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Pressing the check time command does not honor the 24[hour setting in Chrome

Reported by nimerjaber1@gmail.com, Apr 22 2016

Issue description

When ChromeVox is enabled, pressing Search A D does not honor the time and date settings found in Chrome. Please see the following steps to reproduce:
Mode: force_next
Version: 52.0.2712.0
Reproduction Steps: 
1. Enable ChromeVox Next
2. Navigate to Chrome Vox settings and enable 24[hour time setting.
3.Press Search+A D to read the date and time.
Expected behavior: The time is announced in the 24[hour format.
Actual behavior: The time is announced in the 12[hour format.


 
Owner: dtseng@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f289d70ec84f5421e7d69e07fc122fa5fbee23d5

commit f289d70ec84f5421e7d69e07fc122fa5fbee23d5
Author: dtseng <dtseng@chromium.org>
Date: Fri May 06 21:16:28 2016

Revise accessibility for Date/TimeView.

- make it so that accessible labels get set for both Time and Date views (previously only set on DateView).
- prioritize the time first, then the date in the accessible label itself.
- make it so ChromeVox uses the on-screen-ish label (requires some amount of tree interrogation).
- ensure the name is actually updated when the text changes
- this makes it so ChromeVox reads the time and date, from a source that knows how it should be formatted.
- still fallback to something when time is unavailable on-screen.

BUG= 605833 
TEST=invoke ChromeVox read time command; do this with 24/12 hour time set. Observe proper output and that time continues to be updated as time passes.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1953913002
Cr-Commit-Position: refs/heads/master@{#392156}

[modify] https://crrev.com/f289d70ec84f5421e7d69e07fc122fa5fbee23d5/ash/system/date/date_view.cc
[modify] https://crrev.com/f289d70ec84f5421e7d69e07fc122fa5fbee23d5/ash/system/date/date_view.h
[modify] https://crrev.com/f289d70ec84f5421e7d69e07fc122fa5fbee23d5/chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js
[modify] https://crrev.com/f289d70ec84f5421e7d69e07fc122fa5fbee23d5/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Comment 3 by dtseng@chromium.org, May 12 2016

Status: fixed (was: Assigned)
Status: Verified (was: Fixed)
verified on 52.0.2734.0

Sign in to add a comment