New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605830 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 606656



Sign in to add a comment

New git-hash-metrics bot showing up in sheriff-o-matic

Project Member Reported by kjellander@chromium.org, Apr 22 2016

Issue description

There seems to be a new bot in chromium.infra.cron which shows up in sheriff-o-matic for the Chromium sheriff.
1. It seems broken https://build.chromium.org/p/chromium.infra.cron/builders/git-hash-metrics
2. Why does chromium.infra.cron bots keep showing up in sheriff-o-matic? I filed a similar bug before:  bug 602245 .

Assigning to pgervais@ as author of https://codereview.chromium.org/1880343003
 
Thanks for the report. The fact that the builder is broken was (kinda) expected. I'll take care of it soon. It is safe to ignore it for at least a week.

As for why chromium.infra.cron shows up on SoM: I don't know and I think it shouldn't. These bots are essential for chromium but there is nothing sheriffs can do about them apart from pinging troopers. And troopers are alerted when something fails there. Sean: any opinion?

Comment 2 by mgiuca@chromium.org, Apr 26 2016

Issue 606599 has been merged into this issue.

Comment 3 by mgiuca@chromium.org, Apr 26 2016

Cc: mgiuca@chromium.org
Um thanks Sheriff-O-Matic; it didn't show the bug number until I clicked "Link Bug" and then it took me to here...

#1 see my analysis in Issue 606599. Are you sure this isn't a simple misconfiguration?
Status: Started (was: Assigned)
mgiuca: yes, it is a misconfiguration and your analysis is correct. I'll file a CL shortly (was busy with an outage+postmortem until now).
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/94b9a3910115516015cf2c90e84182e0b3847c13

commit 94b9a3910115516015cf2c90e84182e0b3847c13
Author: pgervais@chromium.org <pgervais@chromium.org>
Date: Tue Apr 26 00:49:46 2016

Use correct recipe for git-hash-metrics builder

BUG= 605830 

Review URL: https://codereview.chromium.org/1921993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300182 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/94b9a3910115516015cf2c90e84182e0b3847c13/masters/master.chromium.infra.cron/master.cfg

Comment 6 by mgiuca@chromium.org, Apr 26 2016

Thanks, that was quick!

Any idea why the bot hasn't re-run since you landed the change 2 hours ago?
https://build.chromium.org/p/chromium.infra.cron/builders/git-hash-metrics

Shows that 3.5 hours have passed and it hasn't re-run.

Comment 7 by mgiuca@chromium.org, Apr 26 2016

Blockedon: 606656

Comment 8 by mgiuca@chromium.org, Apr 26 2016

Status: Fixed (was: Started)
Tentatively marking as Fixed. I am still waiting for a bot retry (can't do it myself Issue 606655; requested troopers on Issue 606656).
This builder is triggered by a commit in the infra repo. I guess there hasn't been any recently...

Comment 10 by creis@chromium.org, Apr 26 2016

Status: Assigned (was: Fixed)
Hmm, this doesn't appear to be fixed.  Build 20 failed the "send hash to ts_mon" step:
https://build.chromium.org/p/chromium.infra.cron/builders/git-hash-metrics/builds/20

Argument --ts-mon-task-job-name must be provided when the target type is "task".
step returned non-zero exit code: 2
@@@STEP_FAILURE@@@

pgervais@, can you take another look?

Issue 606655 has been merged into this issue.
sheriffs: please ignore this failure, it has no impact on Chrome at all. In fact it should not show up in Sheriff-o-matic at all.

I am working (slowly) on fixing this builder (and removing this alert from SoM)
Status: Started (was: Assigned)
For the alert removal, see http://crbug.com/606613
Components: Infra>Monitoring
Labels: -Infra-Monitoring
Why shouldn't these show up on SoM? Shouldn't we be able to alert someone if a builder is failing? I think we should apply the same policy here as with tree failures: alert and fix, rather than suppressing.
I agree on the policy. Let me clarify this (in addition to comment #1 above):

- gnumbd is an implementation detail of the commit pipeline. It has nothing to do with sheriffing which is about keeping Chromium tests in a good state.
- Chrome-Infra is already receiving alerts (elsewhere than SoM) when this builder is down and taking action.
- Sheriffs can't do anything about those failures beside pinging troopers so they should not receive this alert.

Status: Verified (was: Started)
The builder is now green, the alert on sheriff-o-matic is gone.
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/e901a4b659f6396c77287b45c07718006bac8d4b

commit e901a4b659f6396c77287b45c07718006bac8d4b
Author: pgervais@chromium.org <pgervais@chromium.org>
Date: Wed Apr 27 18:46:52 2016

git_hash_metric: added missing ts_mon option

BUG= 605830 

Review-Url: https://codereview.chromium.org/1921943007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300247 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/e901a4b659f6396c77287b45c07718006bac8d4b/recipes/recipes/git_hash_metric.expected/infra.json
[modify] https://crrev.com/e901a4b659f6396c77287b45c07718006bac8d4b/recipes/recipes/git_hash_metric.py

Sign in to add a comment