We can depend on base::trace_event from Blink's platform/ so WebMemoryDumpProvider is no longer needed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b873c0d4a990fc5a50d8de6fb71b65478492aefb commit b873c0d4a990fc5a50d8de6fb71b65478492aefb Author: bashi <bashi@chromium.org> Date: Thu May 12 05:41:04 2016 PartitionAllocMemoryDumpProvider can directly inherit from MemoryDumpProvider WebMemoryDumpProviderAdapter was introduced when blink couldn't depend on base/trace_event. We no longer need it for PartionAllocMemoryDumper. BUG= 605822 Review-Url: https://codereview.chromium.org/1910253003 Cr-Commit-Position: refs/heads/master@{#393193} [modify] https://crrev.com/b873c0d4a990fc5a50d8de6fb71b65478492aefb/base/trace_event/malloc_dump_provider.cc [modify] https://crrev.com/b873c0d4a990fc5a50d8de6fb71b65478492aefb/base/trace_event/process_memory_dump.cc [modify] https://crrev.com/b873c0d4a990fc5a50d8de6fb71b65478492aefb/base/trace_event/process_memory_dump.h [modify] https://crrev.com/b873c0d4a990fc5a50d8de6fb71b65478492aefb/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp [modify] https://crrev.com/b873c0d4a990fc5a50d8de6fb71b65478492aefb/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.h [modify] https://crrev.com/b873c0d4a990fc5a50d8de6fb71b65478492aefb/third_party/WebKit/Source/platform/exported/Platform.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6ac66446fcde0040623287ce049043d4a84d51b commit e6ac66446fcde0040623287ce049043d4a84d51b Author: bashi <bashi@chromium.org> Date: Tue May 17 03:19:38 2016 BlinkGCMemoryDumpProvider should inherit from MemoryDumpProvider directly Removing indirections. BUG= 605822 Review-Url: https://codereview.chromium.org/1977783002 Cr-Commit-Position: refs/heads/master@{#394043} [modify] https://crrev.com/e6ac66446fcde0040623287ce049043d4a84d51b/third_party/WebKit/Source/platform/exported/Platform.cpp [modify] https://crrev.com/e6ac66446fcde0040623287ce049043d4a84d51b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp [modify] https://crrev.com/e6ac66446fcde0040623287ce049043d4a84d51b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.h [modify] https://crrev.com/e6ac66446fcde0040623287ce049043d4a84d51b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp [modify] https://crrev.com/e6ac66446fcde0040623287ce049043d4a84d51b/third_party/WebKit/Source/platform/heap/Heap.cpp [modify] https://crrev.com/e6ac66446fcde0040623287ce049043d4a84d51b/third_party/WebKit/Source/platform/heap/HeapPage.cpp [modify] https://crrev.com/e6ac66446fcde0040623287ce049043d4a84d51b/third_party/WebKit/Source/platform/heap/HeapPage.h [modify] https://crrev.com/e6ac66446fcde0040623287ce049043d4a84d51b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c2c70ba86e139bd1143be9c65976ed0720d7c30 commit 8c2c70ba86e139bd1143be9c65976ed0720d7c30 Author: bashi <bashi@chromium.org> Date: Fri May 20 06:32:45 2016 Move WebCacheMemoryDumpProvider to platform Also rename it as MemoryCacheDumpProvider and make it inherit from base::trace_event::MemoryDumpProvider directly. After this CL, no dumper inherits from WebMemoryDumpProvider so we can start removing it. BUG= 605822 Review-Url: https://codereview.chromium.org/1999613002 Cr-Commit-Position: refs/heads/master@{#395019} [modify] https://crrev.com/8c2c70ba86e139bd1143be9c65976ed0720d7c30/third_party/WebKit/Source/core/CoreInitializer.cpp [modify] https://crrev.com/8c2c70ba86e139bd1143be9c65976ed0720d7c30/third_party/WebKit/Source/core/core.gypi [modify] https://crrev.com/8c2c70ba86e139bd1143be9c65976ed0720d7c30/third_party/WebKit/Source/core/fetch/MemoryCache.cpp [modify] https://crrev.com/8c2c70ba86e139bd1143be9c65976ed0720d7c30/third_party/WebKit/Source/core/fetch/MemoryCache.h [delete] https://crrev.com/f973e4a3385b284288a73c8ce7491e9338d6fa29/third_party/WebKit/Source/core/fetch/WebCacheMemoryDumpProvider.cpp [delete] https://crrev.com/f973e4a3385b284288a73c8ce7491e9338d6fa29/third_party/WebKit/Source/core/fetch/WebCacheMemoryDumpProvider.h [add] https://crrev.com/8c2c70ba86e139bd1143be9c65976ed0720d7c30/third_party/WebKit/Source/platform/MemoryCacheDumpProvider.cpp [add] https://crrev.com/8c2c70ba86e139bd1143be9c65976ed0720d7c30/third_party/WebKit/Source/platform/MemoryCacheDumpProvider.h [modify] https://crrev.com/8c2c70ba86e139bd1143be9c65976ed0720d7c30/third_party/WebKit/Source/platform/blink_platform.gypi [modify] https://crrev.com/8c2c70ba86e139bd1143be9c65976ed0720d7c30/third_party/WebKit/Source/platform/exported/Platform.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/337a3fc4f1a26274585d52ac52beab41a0dfd6dc commit 337a3fc4f1a26274585d52ac52beab41a0dfd6dc Author: bashi <bashi@chromium.org> Date: Thu May 26 06:39:33 2016 Remove WebMemoryDumpProvider BUG= 605822 Review-Url: https://codereview.chromium.org/2009483002 Cr-Commit-Position: refs/heads/master@{#396135} [modify] https://crrev.com/337a3fc4f1a26274585d52ac52beab41a0dfd6dc/components/test_runner/test_common.cc [modify] https://crrev.com/337a3fc4f1a26274585d52ac52beab41a0dfd6dc/content/child/blink_platform_impl.cc [modify] https://crrev.com/337a3fc4f1a26274585d52ac52beab41a0dfd6dc/media/blink/run_all_unittests.cc [modify] https://crrev.com/337a3fc4f1a26274585d52ac52beab41a0dfd6dc/third_party/WebKit/Source/core/fetch/Resource.h [modify] https://crrev.com/337a3fc4f1a26274585d52ac52beab41a0dfd6dc/third_party/WebKit/Source/platform/MemoryCacheDumpProvider.cpp [modify] https://crrev.com/337a3fc4f1a26274585d52ac52beab41a0dfd6dc/third_party/WebKit/Source/platform/blink_platform.gypi [modify] https://crrev.com/337a3fc4f1a26274585d52ac52beab41a0dfd6dc/third_party/WebKit/Source/platform/exported/Platform.cpp [delete] https://crrev.com/4ce1cca36afc55c83b9986a9c8f5f89fe5f2a629/third_party/WebKit/Source/platform/exported/WebMemoryDumpProvider.cpp [modify] https://crrev.com/337a3fc4f1a26274585d52ac52beab41a0dfd6dc/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.h [modify] https://crrev.com/337a3fc4f1a26274585d52ac52beab41a0dfd6dc/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h [delete] https://crrev.com/4ce1cca36afc55c83b9986a9c8f5f89fe5f2a629/third_party/WebKit/Source/platform/web_memory_dump_provider_adapter.cc [delete] https://crrev.com/4ce1cca36afc55c83b9986a9c8f5f89fe5f2a629/third_party/WebKit/Source/platform/web_memory_dump_provider_adapter.h [modify] https://crrev.com/337a3fc4f1a26274585d52ac52beab41a0dfd6dc/third_party/WebKit/public/blink_headers.gypi [modify] https://crrev.com/337a3fc4f1a26274585d52ac52beab41a0dfd6dc/third_party/WebKit/public/platform/Platform.h [delete] https://crrev.com/4ce1cca36afc55c83b9986a9c8f5f89fe5f2a629/third_party/WebKit/public/platform/WebMemoryDumpProvider.h [modify] https://crrev.com/337a3fc4f1a26274585d52ac52beab41a0dfd6dc/third_party/WebKit/public/platform/WebProcessMemoryDump.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35ef483c57a5b4e47a3c60943751ed7b61a071fc commit 35ef483c57a5b4e47a3c60943751ed7b61a071fc Author: bashi <bashi@chromium.org> Date: Fri May 27 07:49:37 2016 Move memory dumper from public/platform/ to platform/ These are no longer Blink APIs. BUG= 605822 Review-Url: https://codereview.chromium.org/2015133002 Cr-Commit-Position: refs/heads/master@{#396422} [modify] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/core/fetch/Resource.cpp [modify] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/core/fetch/Resource.h [modify] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/core/fetch/ScriptResource.cpp [modify] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/platform/MemoryCacheDumpProvider.h [modify] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/platform/PurgeableVector.cpp [modify] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/platform/SharedBuffer.cpp [rename] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/platform/WebMemoryAllocatorDump.cpp [rename] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/platform/WebMemoryAllocatorDump.h [rename] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/platform/WebProcessMemoryDump.cpp [rename] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/platform/WebProcessMemoryDump.h [modify] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/platform/blink_platform.gypi [modify] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/platform/fonts/FontCache.cpp [modify] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp [modify] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/platform/heap/Heap.cpp [modify] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/platform/heap/HeapPage.cpp [modify] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/platform/heap/ThreadState.cpp [modify] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/platform/web_memory_allocator_dump_impl.h [modify] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/Source/platform/web_process_memory_dump_impl.h [modify] https://crrev.com/35ef483c57a5b4e47a3c60943751ed7b61a071fc/third_party/WebKit/public/blink_headers.gypi
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa5b57e219d183c0e53a2c84f1642c3ca07a8902 commit fa5b57e219d183c0e53a2c84f1642c3ca07a8902 Author: bashi <bashi@chromium.org> Date: Mon May 30 01:51:57 2016 Remove ProcessMemoryDump::AddHeapDump() BUG= 605822 Review-Url: https://codereview.chromium.org/2016613002 Cr-Commit-Position: refs/heads/master@{#396666} [modify] https://crrev.com/fa5b57e219d183c0e53a2c84f1642c3ca07a8902/base/trace_event/process_memory_dump.cc [modify] https://crrev.com/fa5b57e219d183c0e53a2c84f1642c3ca07a8902/base/trace_event/process_memory_dump.h [modify] https://crrev.com/fa5b57e219d183c0e53a2c84f1642c3ca07a8902/base/trace_event/process_memory_dump_unittest.cc [modify] https://crrev.com/fa5b57e219d183c0e53a2c84f1642c3ca07a8902/third_party/WebKit/Source/platform/WebProcessMemoryDump.h [modify] https://crrev.com/fa5b57e219d183c0e53a2c84f1642c3ca07a8902/third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40 commit 47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40 Author: bashi <bashi@chromium.org> Date: Tue May 31 08:32:48 2016 Remove abstract classes for memory dumper WebProcessMemoryDump and WebMemoryAllocatorDump are abstract interfaces because they lived in public/platform. Now they live in platform so there is no reason to have such abstractions. Unify them with their impl classes. This CL also replaces WebString with String. BUG= 605822 Review-Url: https://codereview.chromium.org/2028483002 Cr-Commit-Position: refs/heads/master@{#396803} [modify] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/core/fetch/Resource.h [modify] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/core/fetch/ScriptResource.cpp [modify] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/platform/MemoryCacheDumpProvider.cpp [modify] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/platform/MemoryCacheDumpProvider.h [modify] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/platform/PurgeableVector.cpp [modify] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/platform/SharedBuffer.cpp [delete] https://crrev.com/378adfe12b9ed629a8843cc661eb12b445bf3ac7/third_party/WebKit/Source/platform/WebMemoryAllocatorDump.cpp [delete] https://crrev.com/378adfe12b9ed629a8843cc661eb12b445bf3ac7/third_party/WebKit/Source/platform/WebMemoryAllocatorDump.h [delete] https://crrev.com/378adfe12b9ed629a8843cc661eb12b445bf3ac7/third_party/WebKit/Source/platform/WebProcessMemoryDump.cpp [delete] https://crrev.com/378adfe12b9ed629a8843cc661eb12b445bf3ac7/third_party/WebKit/Source/platform/WebProcessMemoryDump.h [modify] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/platform/blink_platform.gypi [modify] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/platform/fonts/FontCache.cpp [modify] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp [modify] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/platform/heap/Heap.cpp [modify] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/platform/heap/HeapPage.cpp [modify] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/platform/heap/ThreadState.cpp [add] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/platform/web_memory_allocator_dump.cc [add] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/platform/web_memory_allocator_dump.h [delete] https://crrev.com/378adfe12b9ed629a8843cc661eb12b445bf3ac7/third_party/WebKit/Source/platform/web_memory_allocator_dump_impl.cc [delete] https://crrev.com/378adfe12b9ed629a8843cc661eb12b445bf3ac7/third_party/WebKit/Source/platform/web_memory_allocator_dump_impl.h [rename] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/platform/web_process_memory_dump.cc [add] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/platform/web_process_memory_dump.h [delete] https://crrev.com/378adfe12b9ed629a8843cc661eb12b445bf3ac7/third_party/WebKit/Source/platform/web_process_memory_dump_impl.h [rename] https://crrev.com/47d6f9ab402750dd83ecd64ba8f0fc9e98cd5f40/third_party/WebKit/Source/platform/web_process_memory_dump_test.cc
Comment 1 by bugdroid1@chromium.org
, May 12 2016