New issue
Advanced search Search tips

Issue 605821 link

Starred by 4 users
Status: Untriaged
Owner: ----
Cc:
dbeam@chromium.org
michae...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 612068
issue 613416
Blocking:
issue 602896



Sign in to add a comment

Polymer icons: enforce include-what-you-use

Project Member Reported by michae...@chromium.org, Apr 22 2016 
Instead of importing every <svg> in Polymer (including vulcanizing them into Downloads), we should only include those we actually use.

We can do this by creating a file with these SVGs (using https://poly-icon.appspot.com) and removing third_party/polymer/v1_0/components-chromium/iron-icons/* from polymer_resources.grdp.

It will be a minor pain to gather all the icons we use in all of our WebUI in one place, but after that, enforcing the removal of iron-icons/* will ensure we only include what we use going forward. I'll send an email to chromium-polymer with the details when we're ready.
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9867387afe61115b3e17e6a28d392ebdd3f688a1

commit 9867387afe61115b3e17e6a28d392ebdd3f688a1
Author: michaelpg <michaelpg@chromium.org>
Date: Wed May 04 20:41:01 2016

Material WebUI: create shared icon file.

This moves commonly used icons, or icons used by common CR elements, to
their own file. Eventually, the goal will be for all applications to
include this file and/or their own custom iconset, and we will remove
PolymerElement/iron-icons from Chromium entirely.

The benefit of this is loading (mostly) the icons we need on a per-app
basis, instead of loading all 900 icons in every app. Until we remove
PolymerElement/iron-icons, there will be some minor code duplication, but
the longer-term goal of removing that 250KB in favor of per-app lists of
used icons will probably result in less code in total.

To keep this CL small we only update Settings and Downloads
to use these; a follow-up will update other WebUI. Further
follow-ups will be created by app owners to create their own
per-app shared icon files.

BUG=605821
R=dbeam@chromium.org,tsergeant@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true # crisper.js

Review-Url: https://codereview.chromium.org/1947533002
Cr-Commit-Position: refs/heads/master@{#391627}

[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/chrome/browser/resources/md_downloads/toolbar.html
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html
[add] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/ui/webui/resources/cr_elements/cr_icons.html
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/ui/webui/resources/cr_elements/cr_search_field/cr_search_field.html
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html
[modify] https://crrev.com/9867387afe61115b3e17e6a28d392ebdd3f688a1/ui/webui/resources/cr_elements_resources.grdp
Project Member

Comment 2 by bugdroid1@chromium.org, May 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9

commit 3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9
Author: michaelpg <michaelpg@chromium.org>
Date: Mon May 09 18:01:13 2016

Material WebUI: Switch to poly-icons to generate iconsets

This is a follow-up to https://codereview.chromium.org/1947533002/.

Instead of copying iron-icon definitions from third_party/polymer,
we generate them using https://poly-icon.appspot.com. This has the
advantage of being easier to reproduce and update, as a single URL
can generate the list of SVG <g> definitions neaded.

The actual definitions are the same, but the comments were changed
to reflect the new generation style.

Also, the shared icon file is renamed to "icons.html" to reflect
similar conventions in MD Extensions and (soon) MD settings, and
the iconset prefix is simply "cr".

BUG=605821
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1957313002
Cr-Commit-Position: refs/heads/master@{#392360}

[modify] https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9/chrome/browser/resources/md_downloads/toolbar.html
[modify] https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
[modify] https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html
[modify] https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.js
[modify] https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9/ui/webui/resources/cr_elements/cr_search_field/cr_search_field.html
[rename] https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9/ui/webui/resources/cr_elements/icons.html
[modify] https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js
[modify] https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html
[modify] https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9/ui/webui/resources/cr_elements_resources.grdp
Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f53081fa0b0558c466a15994d32461a03098dac6

commit f53081fa0b0558c466a15994d32461a03098dac6
Author: michaelpg <michaelpg@chromium.org>
Date: Tue May 10 03:48:50 2016

MD Downloads: use custom iconset

Instead of including all 299 SVG definitions from iron-icons,
put the 2 icons we're using into our own iconset.

dbeam: i'm not sure how to test this, aside from Inspector. do you have any
unsafe download examples?

BUG=605821
R=dbeam@chromium.org
NOPRESUBMIT=true # crisper.js
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1964493002
Cr-Commit-Position: refs/heads/master@{#392539}

[modify] https://crrev.com/f53081fa0b0558c466a15994d32461a03098dac6/chrome/browser/resources/md_downloads/crisper.js
[add] https://crrev.com/f53081fa0b0558c466a15994d32461a03098dac6/chrome/browser/resources/md_downloads/icons.html
[modify] https://crrev.com/f53081fa0b0558c466a15994d32461a03098dac6/chrome/browser/resources/md_downloads/item.css
[modify] https://crrev.com/f53081fa0b0558c466a15994d32461a03098dac6/chrome/browser/resources/md_downloads/item.html
[modify] https://crrev.com/f53081fa0b0558c466a15994d32461a03098dac6/chrome/browser/resources/md_downloads/item.js
[modify] https://crrev.com/f53081fa0b0558c466a15994d32461a03098dac6/chrome/browser/resources/md_downloads/vulcanized.html
Project Member

Comment 5 by bugdroid1@chromium.org, May 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d

commit bf2d0f7b9eeeab5618f0656e81d40aa5d736557d
Author: michaelpg <michaelpg@chromium.org>
Date: Tue May 10 14:37:30 2016

MD Settings: Use shared cr_elements iconset when possible

This is the first step in getting Settings off of iron-icons. Changes any
instances of icons already in the 'cr' iconset to use that iconset.

A follow-up will consolidate the rest of the Settings icons inside a custom
Settings iconset.

R=dbeam@chromium.org
BUG=605821
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1960323002
Cr-Commit-Position: refs/heads/master@{#392599}

[modify] https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d/chrome/browser/resources/settings/internet_page/network_proxy_exclusions.html
[modify] https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html
[modify] https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d/chrome/browser/resources/settings/languages_page/manage_languages_page.html
[modify] https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d/chrome/browser/resources/settings/people_page/user_list.html
[modify] https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d/chrome/browser/resources/settings/reset_page/reset_profile_banner.html
[modify] https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d/chrome/browser/resources/settings/settings_dialog.html
[modify] https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d/chrome/test/data/webui/settings/languages_page_browsertest.js
[modify] https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d/ui/webui/resources/cr_elements/icons.html
Project Member

Comment 6 by bugdroid1@chromium.org, May 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/824b7c8d91046d0174b654905dd607ffb88c86c8

commit 824b7c8d91046d0174b654905dd607ffb88c86c8
Author: michaelpg <michaelpg@chromium.org>
Date: Wed May 11 03:14:44 2016

MD Settings: use custom iconset

Instead of including almost 1000 definitions from iron-icons,
put the icons we're actually using in our own iconset.

This CL is a net gain of 81 lines, but actually prevents
chrome://md-settings from loading an additional >900 lines.

BUG=605821
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1959163002
Cr-Commit-Position: refs/heads/master@{#392839}

[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/bluetooth_page/bluetooth_add_device_dialog.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/bluetooth_page/bluetooth_pair_device_dialog.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/default_browser_page/default_browser_page.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/device_page/device_page.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/internet_page/network_siminfo.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/people_page/camera.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/people_page/change_picture.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/settings_page/settings_subpage.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/site_settings/site_details_permission.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/site_settings/site_settings_category.html
[modify] https://crrev.com/824b7c8d91046d0174b654905dd607ffb88c86c8/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
Project Member

Comment 7 by bugdroid1@chromium.org, May 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21c031c79dbe21b08a33e9840752550e97ef5077

commit 21c031c79dbe21b08a33e9840752550e97ef5077
Author: tsergeant <tsergeant@chromium.org>
Date: Mon May 16 07:15:57 2016

PDF: Use custom iconsets instead of iron-icons

Previously, the PDF viewer pulled in all of iron-icons and image-icons
(114kB of icons in total!), when it was only using a small number of
them. This CL switches the viewer to use a custom icon set, and pulls a
small number of common icons into the shared cr iconset.

BUG=605821
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1985573002
Cr-Commit-Position: refs/heads/master@{#393801}

[modify] https://crrev.com/21c031c79dbe21b08a33e9840752550e97ef5077/chrome/browser/resources/component_extension_resources.grd
[add] https://crrev.com/21c031c79dbe21b08a33e9840752550e97ef5077/chrome/browser/resources/pdf/elements/icons.html
[modify] https://crrev.com/21c031c79dbe21b08a33e9840752550e97ef5077/chrome/browser/resources/pdf/elements/viewer-bookmark/viewer-bookmark.html
[modify] https://crrev.com/21c031c79dbe21b08a33e9840752550e97ef5077/chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.html
[modify] https://crrev.com/21c031c79dbe21b08a33e9840752550e97ef5077/chrome/browser/resources/pdf/elements/viewer-toolbar-dropdown/viewer-toolbar-dropdown.html
[modify] https://crrev.com/21c031c79dbe21b08a33e9840752550e97ef5077/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-button.html
[modify] https://crrev.com/21c031c79dbe21b08a33e9840752550e97ef5077/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-toolbar.html
[modify] https://crrev.com/21c031c79dbe21b08a33e9840752550e97ef5077/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/21c031c79dbe21b08a33e9840752550e97ef5077/chrome/test/data/pdf/material_elements_test.js
[modify] https://crrev.com/21c031c79dbe21b08a33e9840752550e97ef5077/ui/webui/resources/cr_elements/icons.html
Project Member

Comment 8 by bugdroid1@chromium.org, May 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21ba32279e7b808c7e59e48d45db99d59951de70

commit 21ba32279e7b808c7e59e48d45db99d59951de70
Author: tsergeant <tsergeant@chromium.org>
Date: Tue May 17 01:29:01 2016

MD Settings: Fix names of icons which had been moved to shared iconset

In crrev.com/393801, several icons from the settings iconset were moved
to the shared cr iconset, however, the icon names in MD Settings were
not updated. This CL updates the icons so they display correctly again.

BUG=605821
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1982113002
Cr-Commit-Position: refs/heads/master@{#394007}

[modify] https://crrev.com/21ba32279e7b808c7e59e48d45db99d59951de70/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/21ba32279e7b808c7e59e48d45db99d59951de70/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/21ba32279e7b808c7e59e48d45db99d59951de70/chrome/browser/resources/settings/site_settings/site_settings_behavior.html
[modify] https://crrev.com/21ba32279e7b808c7e59e48d45db99d59951de70/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
Project Member

Comment 9 by bugdroid1@chromium.org, May 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc0c80d90187791680863ec1e8a5ddbeb28c5030

commit fc0c80d90187791680863ec1e8a5ddbeb28c5030
Author: michaelpg <michaelpg@chromium.org>
Date: Tue May 17 23:11:16 2016

MD WebUI: Update docs for custom iconsets.

Simplify instructions and point to the Sites page documentation.

We originally intended to keep the poly-icon.appspot.com URL
in sync with the list of icons, so theoretically we could
visit the URL when iron-icon definitions change in order to
update our copies of them.

However, that's confusing and difficult. And Polymer icons
get updated very infrequently, so it's not worth the hassle.

BUG=605821
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1992503002
Cr-Commit-Position: refs/heads/master@{#394262}

[modify] https://crrev.com/fc0c80d90187791680863ec1e8a5ddbeb28c5030/chrome/browser/resources/md_downloads/icons.html
[modify] https://crrev.com/fc0c80d90187791680863ec1e8a5ddbeb28c5030/chrome/browser/resources/md_user_manager/icons.html
[modify] https://crrev.com/fc0c80d90187791680863ec1e8a5ddbeb28c5030/chrome/browser/resources/pdf/elements/icons.html
[modify] https://crrev.com/fc0c80d90187791680863ec1e8a5ddbeb28c5030/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/fc0c80d90187791680863ec1e8a5ddbeb28c5030/ui/webui/resources/cr_elements/icons.html

Comment 10 by michae...@chromium.org, May 17 2016

Blockedon: 612068

Comment 11 by michae...@chromium.org, May 20 2016

Blockedon: 613416

Comment 12 by tbuck...@chromium.org, May 24 2016

Labels: Hotlist-MD-Settings-General
Project Member

Comment 13 by bugdroid1@chromium.org, May 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6aa929611e6250d05017513eee4abed661842234

commit 6aa929611e6250d05017513eee4abed661842234
Author: calamity <calamity@chromium.org>
Date: Mon May 30 07:01:59 2016

[MD History] Create an icons.html for MD History.

This CL creates a smaller icons file for history rather than pulling in
all unnecessary icons in other packages.

BUG=605821
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2001013002
Cr-Commit-Position: refs/heads/master@{#396690}

[modify] https://crrev.com/6aa929611e6250d05017513eee4abed661842234/chrome/browser/browser_resources.grd
[modify] https://crrev.com/6aa929611e6250d05017513eee4abed661842234/chrome/browser/resources/md_history/history_toolbar.html
[add] https://crrev.com/6aa929611e6250d05017513eee4abed661842234/chrome/browser/resources/md_history/icons.html
[modify] https://crrev.com/6aa929611e6250d05017513eee4abed661842234/chrome/browser/ui/webui/md_history_ui.cc

Comment 14 by michae...@chromium.org, Jun 3 2016

Cc: michae...@chromium.org
Components: -Internals>Cast>UI -UI>Settings -UI>Browser>Downloads
Labels: -Hotlist-MD-Settings-General
Owner: ----
Status: Available (was: Started)
Remaining UIs blocking the removal of iron-icons:

* history
* extensions
* OOBE
* smart lock
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4e61b6bb3a602adecf92d4e0a41804e5997895f

commit e4e61b6bb3a602adecf92d4e0a41804e5997895f
Author: michaelpg <michaelpg@chromium.org>
Date: Tue Aug 16 03:40:41 2016

Preprocess settings/icons.html and cr_elements/icons.html for <if>s

BUG=605821
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2249943002
Cr-Commit-Position: refs/heads/master@{#412159}

[modify] https://crrev.com/e4e61b6bb3a602adecf92d4e0a41804e5997895f/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/e4e61b6bb3a602adecf92d4e0a41804e5997895f/ui/webui/resources/cr_elements_resources.grdp

Comment 16 by tsergeant@chromium.org, Jan 18 2017

Components: -UI>Browser>History
History doesn't use iron-icons, so removing the Component to get it out of our bug queue.
Project Member

Comment 17 by sheriffbot@chromium.org, Apr 13 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 18 by rdevlin....@chromium.org, Apr 13 2018

Components: -Platform>Extensions UI>Browser>ExtensionsManagement
►

Sign in to add a comment