Issue metadata
Sign in to add a comment
|
Tabs are not being rendered properly in some cases |
||||||||||||||||||||||
Issue descriptionChrome Version : 52.0.2714.0 canary (64-bit) OS Version: OS X 10.11.4 URLs (if applicable) : https://kernel.googlesource.com/pub/scm/bluetooth/bluez/+/master/monitor/uuid.c#37 Other browsers tested: Add OK or FAIL after other browsers where you have tested this issue: Safari 9.1 (11601.5.17.1): PASS Firefox 45.0.2: PASS What steps will reproduce the problem? 1. Head to https://kernel.googlesource.com/pub/scm/bluetooth/bluez/+/master/monitor/uuid.c#37 2. The closing brackets (`}`) don’t line up on lines 38—45 even though they should. The brackets should align and do on other browsers (Safari and FF).
,
Apr 25 2016
,
Apr 25 2016
Confirmed it was caused by r351368. Looking into it now.
,
Apr 25 2016
,
Apr 25 2016
Thanks for the quick turnaround, Emil :)
,
Apr 25 2016
With a reliable reproduction and regression range all the hard work has already been done for me. :)
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/957ee1cf9558f59e65c943a85fab2ec7ce94ebe2 commit 957ee1cf9558f59e65c943a85fab2ec7ce94ebe2 Author: eae <eae@chromium.org> Date: Mon Apr 25 04:58:57 2016 Change LineWidth::snapUncommittedWidth to ceil Change the snapUncommittedWidth method on the LineWidth class to ceil to the nearest LayoutUnit rather than to floor. It's only called from a one place, BreakingContext::increment, where the intent is to increment, not decrement, the uncommitted width. This ensures that the snapped width is wide enough to contain the text. This fixes a bug where tabulation characters were omitted incorrectly in text layout due to the width being floored during the width commit step. R=kojii@chromium.org BUG= 605820 Review URL: https://codereview.chromium.org/1919693002 Cr-Commit-Position: refs/heads/master@{#389413} [modify] https://crrev.com/957ee1cf9558f59e65c943a85fab2ec7ce94ebe2/third_party/WebKit/Source/core/layout/line/LineWidth.h
,
Apr 25 2016
,
Apr 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/957ee1cf9558f59e65c943a85fab2ec7ce94ebe2 commit 957ee1cf9558f59e65c943a85fab2ec7ce94ebe2 Author: eae <eae@chromium.org> Date: Mon Apr 25 04:58:57 2016 Change LineWidth::snapUncommittedWidth to ceil Change the snapUncommittedWidth method on the LineWidth class to ceil to the nearest LayoutUnit rather than to floor. It's only called from a one place, BreakingContext::increment, where the intent is to increment, not decrement, the uncommitted width. This ensures that the snapped width is wide enough to contain the text. This fixes a bug where tabulation characters were omitted incorrectly in text layout due to the width being floored during the width commit step. R=kojii@chromium.org BUG= 605820 Review URL: https://codereview.chromium.org/1919693002 Cr-Commit-Position: refs/heads/master@{#389413} [modify] https://crrev.com/957ee1cf9558f59e65c943a85fab2ec7ce94ebe2/third_party/WebKit/Source/core/layout/line/LineWidth.h |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ajha@chromium.org
, Apr 22 2016Components: -Blink Blink>Layout
Labels: -Type-Bug hasbisect M-52 Type-Bug-Regression
Owner: szager@chromium.org
Status: Assigned (was: Untriaged)