New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605819 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 1
Type: Bug

Blocking:
issue 432959
issue 433082
issue 588080



Sign in to add a comment

GN doesn't support linux_dump_symbols

Project Member Reported by dpranke@chromium.org, Apr 22 2016

Issue description

We still need to implement this for clang tip-of-tree builders and
a chromeos config.
 
Summary: GN doesn't support linux_dump_symbols (was: Gn doesn't support linux_dump_symbols)
Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ae814d2d836ea64a076b0a6d193d83098e812d4

commit 1ae814d2d836ea64a076b0a6d193d83098e812d4
Author: dpranke <dpranke@chromium.org>
Date: Wed May 25 02:59:55 2016

Flip ClangToTLinux builder to GN.

In the GYP build, this builder was using linux_dump_symbols
to make sure that we were getting debug symbols in a release (optimized) build, but in GN we can accomplish that by
simply passing the symbol_level=2 build arg instead.

R=brettw@chromium.org, thakis@chromium.org
BUG= 605819 

Review-Url: https://codereview.chromium.org/2008713003
Cr-Commit-Position: refs/heads/master@{#395786}

[modify] https://crrev.com/1ae814d2d836ea64a076b0a6d193d83098e812d4/tools/mb/mb_config.pyl

Did we end up deciding this is WontFix, or is this needed for more than the ClangToTLinux bots?
Status: WontFix (was: Assigned)
Cc: llozano@chromium.org
Status: Assigned (was: WontFix)
Chrome OS ebuild sets linux_dump_symbols=1 when USE=deep_memory_profiler.
(https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/master/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild)

Luis, do you happen to know if USE=deep_memory_profiler is used by anyone currently?
If not, let's close this as WontFix, and remove that deep_memory_profiler part from Chrome OS ebuild.

Comment 6 by lloz...@google.com, Jun 9 2016

I dont know anything about this.
this shows it seems used by libchromeos-ui
https://cs.corp.google.com/search/?q=deep_memory_profiler+package:%5Echromeos_public$&type=cs


We deleted deep_memory_profiler last year ( bug 490464 ) -- if cros still refers to it, that's probably a remnant that still need to be deleted.

Comment 8 by thakis@chromium.org, Jun 10 2016

Status: WontFix (was: Assigned)
closing this again -- llozano, please delete references to deep_memory_profiler on your end.

Sign in to add a comment