GN doesn't support linux_dump_symbols |
||||
Issue descriptionWe still need to implement this for clang tip-of-tree builders and a chromeos config.
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ae814d2d836ea64a076b0a6d193d83098e812d4 commit 1ae814d2d836ea64a076b0a6d193d83098e812d4 Author: dpranke <dpranke@chromium.org> Date: Wed May 25 02:59:55 2016 Flip ClangToTLinux builder to GN. In the GYP build, this builder was using linux_dump_symbols to make sure that we were getting debug symbols in a release (optimized) build, but in GN we can accomplish that by simply passing the symbol_level=2 build arg instead. R=brettw@chromium.org, thakis@chromium.org BUG= 605819 Review-Url: https://codereview.chromium.org/2008713003 Cr-Commit-Position: refs/heads/master@{#395786} [modify] https://crrev.com/1ae814d2d836ea64a076b0a6d193d83098e812d4/tools/mb/mb_config.pyl
,
Jun 8 2016
Did we end up deciding this is WontFix, or is this needed for more than the ClangToTLinux bots?
,
Jun 8 2016
,
Jun 9 2016
Chrome OS ebuild sets linux_dump_symbols=1 when USE=deep_memory_profiler. (https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/master/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild) Luis, do you happen to know if USE=deep_memory_profiler is used by anyone currently? If not, let's close this as WontFix, and remove that deep_memory_profiler part from Chrome OS ebuild.
,
Jun 9 2016
I dont know anything about this. this shows it seems used by libchromeos-ui https://cs.corp.google.com/search/?q=deep_memory_profiler+package:%5Echromeos_public$&type=cs
,
Jun 9 2016
We deleted deep_memory_profiler last year ( bug 490464 ) -- if cros still refers to it, that's probably a remnant that still need to be deleted.
,
Jun 10 2016
closing this again -- llozano, please delete references to deep_memory_profiler on your end.
,
Jun 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/df86d16724329fa65d360e54635ff1d3a1976ca8 commit df86d16724329fa65d360e54635ff1d3a1976ca8 Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Mon Jun 13 08:46:22 2016 chromeos-chrome: Remove deep_memory_profiler related code BUG= chromium:605819 TEST=build Change-Id: I54cbc47fb696be938d145ec4d1940b75deb32ab5 Reviewed-on: https://chromium-review.googlesource.com/351799 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [rename] https://crrev.com/df86d16724329fa65d360e54635ff1d3a1976ca8/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1-r12.ebuild [modify] https://crrev.com/df86d16724329fa65d360e54635ff1d3a1976ca8/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild [modify] https://crrev.com/df86d16724329fa65d360e54635ff1d3a1976ca8/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1.ebuild
,
Jun 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/50a200ce9c23d72e7ae34dad35936b7202b6eadb commit 50a200ce9c23d72e7ae34dad35936b7202b6eadb Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Mon Jun 13 08:45:15 2016 libchromeos-ui: Remove deep_memory_profiler related code BUG= chromium:605819 TEST=UnitTests Change-Id: I526b56421cd17be42dad29a3a752845996ac30a1 Reviewed-on: https://chromium-review.googlesource.com/351950 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/50a200ce9c23d72e7ae34dad35936b7202b6eadb/libchromeos-ui/chromeos/ui/chromium_command_builder.cc [modify] https://crrev.com/50a200ce9c23d72e7ae34dad35936b7202b6eadb/libchromeos-ui/chromeos/ui/chromium_command_builder.h [modify] https://crrev.com/50a200ce9c23d72e7ae34dad35936b7202b6eadb/libchromeos-ui/chromeos/ui/chromium_command_builder_unittest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by dpranke@chromium.org
, Apr 22 2016