New issue
Advanced search Search tips

Issue 605818 link

Starred by 1 user
Status: Fixed
Owner:
h...@chromium.org
Closed: Apr 2016
Cc:
thakis@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

New float-to-bool conversion warnings after Clang r267054

Project Member Reported by h...@chromium.org, Apr 22 2016 
For example:

../../content/browser/devtools/protocol/color_picker.cc:184:7: error: implicit conversion from 'const float' to 'bool' changes value from 0 to false [-Werror,-Wfloat-bool-constant-conversion]
  if (kHotspotRadius) {
  ~~  ^~~~~~~~~~~~~~
1 error generated.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24fec3b129239e5812f527033baeb1c7b27e8a48

commit 24fec3b129239e5812f527033baeb1c7b27e8a48
Author: hans <hans@chromium.org>
Date: Fri Apr 22 04:02:41 2016

color_picker.cc fix float-to-bool conversion warning

New versions of Clang were warning (which we treat as an error)
on this code:

../../content/browser/devtools/protocol/color_picker.cc:184:7:
error: implicit conversion from 'const float' to 'bool' changes
value from 0 to false [-Werror,-Wfloat-bool-constant-conversion]
  if (kHotspotRadius) {
      ~~  ^~~~~~~~~~~~~~

BUG= 605818 
TBR=dgozman

Review URL: https://codereview.chromium.org/1906333002

Cr-Commit-Position: refs/heads/master@{#389016}

[modify] https://crrev.com/24fec3b129239e5812f527033baeb1c7b27e8a48/content/browser/devtools/protocol/color_picker.cc

Comment 2 by h...@chromium.org, Apr 22 2016

Status: Fixed (was: Started)
All targets build cleanly on my Linux box now, and I haven't seen any more warnings on the bots.
►

Sign in to add a comment