New issue
Advanced search Search tips

Issue 605811 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ARC: add UMA metric for ARC shutdown time

Project Member Reported by elijahtaylor@chromium.org, Apr 22 2016

Issue description

This will be helpful in guiding how long to delay forcing shutdown when ARC is unresponsive.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e794bb52914b5dd9b440776c56bbe09f4f3a9930

commit e794bb52914b5dd9b440776c56bbe09f4f3a9930
Author: elijahtaylor <elijahtaylor@chromium.org>
Date: Sat Apr 23 00:09:34 2016

ARC: add histogram definition for ShutdownTime

BUG= 605811 

Review URL: https://codereview.chromium.org/1908313002

Cr-Commit-Position: refs/heads/master@{#389319}

[modify] https://crrev.com/e794bb52914b5dd9b440776c56bbe09f4f3a9930/tools/metrics/histograms/histograms.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2016

Labels: merge-merged-2716
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e794bb52914b5dd9b440776c56bbe09f4f3a9930

commit e794bb52914b5dd9b440776c56bbe09f4f3a9930
Author: elijahtaylor <elijahtaylor@chromium.org>
Date: Sat Apr 23 00:09:34 2016

ARC: add histogram definition for ShutdownTime

BUG= 605811 

Review URL: https://codereview.chromium.org/1908313002

Cr-Commit-Position: refs/heads/master@{#389319}

[modify] https://crrev.com/e794bb52914b5dd9b440776c56bbe09f4f3a9930/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Labels: VerifyIn-53
Labels: VerifyIn-54

Comment 6 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55
Cc: dgreid@chromium.org
We had data back when this was added in an init script, which was just advisory for picking a good timeout for killing the container.  My guess is that this was not ported when this shutdown code was moved to session manager.  Dylan, can you confirm?

I think we do not strictly need this anymore, but am open to adding it back if we think it's useful

Comment 9 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 10 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 11 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58
Status: Verified (was: Fixed)

Sign in to add a comment