New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605791 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

sometimes auto-generated polymer compiled_resources2.gyp target_names are sorted incorrectly

Project Member Reported by dbeam@chromium.org, Apr 21 2016

Issue description

this happens because we're not comparing the real target names before spitting them out
 

Comment 1 by dbeam@chromium.org, Apr 21 2016

Summary: sometimes auto-generated polymer compiled_resources2.gyp target_names are sorted incorrectly (was: sometimes polymer compiled_resources2.gyp target_names are sorted incorrectly)
sorry, forgot to mention this applies to the compiled_resources2.gyp files generated by tools/polymer/generate_compiled_resources_gyp.py
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57c67380298b9c48a1f8d429b2b55c56defaa9af

commit 57c67380298b9c48a1f8d429b2b55c56defaa9af
Author: dbeam <dbeam@chromium.org>
Date: Fri Apr 22 01:04:13 2016

[tools] fix target_name ordering bug in generate_compiled_resources_gyp.py

R=dschuyler@chromium.org
BUG= 605791 

NOTRY=true

Review URL: https://codereview.chromium.org/1908273002

Cr-Commit-Position: refs/heads/master@{#388988}

[modify] https://crrev.com/57c67380298b9c48a1f8d429b2b55c56defaa9af/tools/polymer/generate_compiled_resources_gyp.py

Comment 3 by dbeam@chromium.org, Apr 22 2016

Status: Fixed (was: Started)

Sign in to add a comment