MemoryInfra: Add a memory dump provider for DOM storage. |
|||||
Issue descriptionBackground context:go/memory-infra: memory profiling in chrome://tracing DOM storage uses a lot of memory on long running browser. So, it should be accounted in memory-infra. It uses memory in 3 ways: 1. A map buffer in DomStorageArea before committing to database. 2. A session storage database backed by leveldb. 3. A local storage database backed by sqlite. The tricky part here is only the sqlite databases are accounted in memory-infra. So, (3) has to be sub-allocated from the sqlite dumps in some way. Also, the dom databases in (1) are accessed using DOMStorageTaskRunner. But a SequencedTaskRunner can be extracted from this worker pool just like SequencedWorkerPool::GetSequencedTaskRunner for the PRIMARY id to get memory dumps. This is because Memory-infra only supports dumps on SequencedTaskRunner.
,
Jun 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/659a76cbecfd264aa1c04c113e5d0a03b88038fc commit 659a76cbecfd264aa1c04c113e5d0a03b88038fc Author: ssid <ssid@chromium.org> Date: Wed Jun 08 07:19:15 2016 [tracing] Support background mode in dom storage memory dumps Provide just total numbers for background mode dumps in dom storage. The storage could be using memory for commit batches along with the storage maps. So, add the size to tracing. BUG= 613198 , 605785 TBR=michaeln Review-Url: https://codereview.chromium.org/1950893003 Cr-Commit-Position: refs/heads/master@{#398499} [modify] https://crrev.com/659a76cbecfd264aa1c04c113e5d0a03b88038fc/content/browser/dom_storage/dom_storage_area.cc [modify] https://crrev.com/659a76cbecfd264aa1c04c113e5d0a03b88038fc/content/browser/dom_storage/dom_storage_context_impl.cc
,
Jun 24 2016
Lowering priority since the only part left is to display the sqlite usage under dom. But everything is currently being recorded.
,
Nov 25 2016
triacing: should this still be open?
,
Nov 29 2016
Yes, I don't think it is really worth the code complexity to change sqlite reporting to dom_storage.
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9270bd2a45d85f4810cafedc6f25e188edf2d671 commit 9270bd2a45d85f4810cafedc6f25e188edf2d671 Author: ssid <ssid@chromium.org> Date: Fri Dec 09 01:57:00 2016 [tracing] Show the local storage databases under dom_storage The sqlite memory usage was being reported under "sqlite" column. After this CL the sql databases opened by DOM storage will be shown under the "dom_storage" column. This is done by adding an ownership edge (implemented in sql::Connection::ReportMemoryUsage). BUG= 605785 Review-Url: https://codereview.chromium.org/2548063002 Cr-Commit-Position: refs/heads/master@{#437426} [modify] https://crrev.com/9270bd2a45d85f4810cafedc6f25e188edf2d671/content/browser/dom_storage/dom_storage_area.cc [modify] https://crrev.com/9270bd2a45d85f4810cafedc6f25e188edf2d671/content/browser/dom_storage/dom_storage_database.cc [modify] https://crrev.com/9270bd2a45d85f4810cafedc6f25e188edf2d671/content/browser/dom_storage/dom_storage_database.h [modify] https://crrev.com/9270bd2a45d85f4810cafedc6f25e188edf2d671/content/browser/dom_storage/dom_storage_database_adapter.h [modify] https://crrev.com/9270bd2a45d85f4810cafedc6f25e188edf2d671/content/browser/dom_storage/local_storage_database_adapter.cc [modify] https://crrev.com/9270bd2a45d85f4810cafedc6f25e188edf2d671/content/browser/dom_storage/local_storage_database_adapter.h
,
Jan 4 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, May 4 2016