New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605770 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 646189

Blocking:
issue 669732



Sign in to add a comment

[Predator] Checking CL description

Project Member Reported by st...@chromium.org, Apr 21 2016

Issue description

One possible direction is to derive the changed components from the CL description and the components from the stack trace, and then correlate the two.
 

Comment 1 by st...@chromium.org, Apr 21 2016

Blocking: 605783

Comment 2 by st...@chromium.org, May 27 2016

Blocking: -605783 615262

Comment 3 by st...@chromium.org, Aug 22 2016

Cc: mbarbe...@chromium.org infe...@chromium.org
Owner: wrengr@chromium.org
Status: Assigned (was: Available)

Comment 4 by wrengr@chromium.org, Sep 15 2016

Status: Started (was: Assigned)

Comment 5 by wrengr@chromium.org, Sep 16 2016

Blockedon: 646189

Comment 6 by wrengr@chromium.org, Sep 16 2016

Initial CL is at https://codereview.chromium.org/2338273006/
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/98028c43b368a15f082446772a5077e0e6cb8b68

commit 98028c43b368a15f082446772a5077e0e6cb8b68
Author: wrengr <wrengr@chromium.org>
Date: Wed Sep 28 21:05:15 2016

[Findit] Factoring out the components, so they can classify themselves

Rather than having ComponentClassifier do a bunch of logic about whether
various components are responsible for various stack frames, we instead
have a new class: Component, which encapsulates the work necessary for
that specific component. That is, each Component can —by itself—
recognize whether it is responsible for a given stack frame (or, in the
future: a given CL, file, etc); and the ComponentClassifier class now
simply stores a list of Components, and calls their methods for them to
decide whether they match or not.

In addition, the ComponentClassifier class no longer depends on
CrashConfig. Instead the constructor is given the values it needs, and
therefore client code is free to get those values from wherever they so
desire (rather than forcing clients to use our internal configuration
tools).

BUG= chromium:605770 

Review-Url: https://codereview.chromium.org/2338273006

[add] https://crrev.com/98028c43b368a15f082446772a5077e0e6cb8b68/appengine/findit/crash/component.py
[modify] https://crrev.com/98028c43b368a15f082446772a5077e0e6cb8b68/appengine/findit/crash/component_classifier.py
[modify] https://crrev.com/98028c43b368a15f082446772a5077e0e6cb8b68/appengine/findit/crash/findit_for_chromecrash.py
[modify] https://crrev.com/98028c43b368a15f082446772a5077e0e6cb8b68/appengine/findit/crash/test/component_classifier_test.py
[modify] https://crrev.com/98028c43b368a15f082446772a5077e0e6cb8b68/appengine/findit/model/crash/crash_config.py

Comment 8 by wrengr@chromium.org, Oct 27 2016

Status: Assigned (was: Started)

Comment 9 by wrengr@chromium.org, Nov 29 2016

Components: Tools>Test>Predator
Summary: [Predator] Checking CL description (was: crash: Checking CL description)
Blocking: -615262
Blocking: 669732

Comment 12 by st...@chromium.org, Apr 24 2017

Cc: -kateso...@chromium.org wrengr@chromium.org
Components: -Tools>Test>FindIt
Owner: kateso...@chromium.org
Status: WontFix (was: Assigned)
I think the component classification we have now solves this problem in a better way than checking the CL description would have. Feel free to reopen if you think there's more work to do here.

Sign in to add a comment