[Predator] Checking CL description |
||||||||||
Issue descriptionOne possible direction is to derive the changed components from the CL description and the components from the stack trace, and then correlate the two.
,
Aug 22 2016
,
Sep 15 2016
,
Sep 16 2016
,
Sep 16 2016
Initial CL is at https://codereview.chromium.org/2338273006/
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/98028c43b368a15f082446772a5077e0e6cb8b68 commit 98028c43b368a15f082446772a5077e0e6cb8b68 Author: wrengr <wrengr@chromium.org> Date: Wed Sep 28 21:05:15 2016 [Findit] Factoring out the components, so they can classify themselves Rather than having ComponentClassifier do a bunch of logic about whether various components are responsible for various stack frames, we instead have a new class: Component, which encapsulates the work necessary for that specific component. That is, each Component can —by itself— recognize whether it is responsible for a given stack frame (or, in the future: a given CL, file, etc); and the ComponentClassifier class now simply stores a list of Components, and calls their methods for them to decide whether they match or not. In addition, the ComponentClassifier class no longer depends on CrashConfig. Instead the constructor is given the values it needs, and therefore client code is free to get those values from wherever they so desire (rather than forcing clients to use our internal configuration tools). BUG= chromium:605770 Review-Url: https://codereview.chromium.org/2338273006 [add] https://crrev.com/98028c43b368a15f082446772a5077e0e6cb8b68/appengine/findit/crash/component.py [modify] https://crrev.com/98028c43b368a15f082446772a5077e0e6cb8b68/appengine/findit/crash/component_classifier.py [modify] https://crrev.com/98028c43b368a15f082446772a5077e0e6cb8b68/appengine/findit/crash/findit_for_chromecrash.py [modify] https://crrev.com/98028c43b368a15f082446772a5077e0e6cb8b68/appengine/findit/crash/test/component_classifier_test.py [modify] https://crrev.com/98028c43b368a15f082446772a5077e0e6cb8b68/appengine/findit/model/crash/crash_config.py
,
Oct 27 2016
,
Nov 29 2016
,
Nov 30 2016
,
Nov 30 2016
,
Apr 24 2017
,
Oct 11 2017
I think the component classification we have now solves this problem in a better way than checking the CL description would have. Feel free to reopen if you think there's more work to do here. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by st...@chromium.org
, Apr 21 2016