crash: ignore refactoring CLs |
||||||||
Issue descriptionRefactoring CLs usually touched a lot of files without functional change. We should not blame such CLs for a crash. One special case is adding/modifying a comment.
,
Aug 22 2016
,
Nov 30 2016
,
Nov 30 2016
,
Apr 24 2017
,
Oct 4 2017
Example of a case where this is causing trouble: https://bugs.chromium.org/p/chromium/issues/detail?id=733160#c7
,
Oct 4 2017
,
Oct 4 2017
We can probably look for simple keywords in the first line of the CL description (such as "rename") and ignore based on that as a short-term fix. We can expand on it if we see more issues later.
,
Oct 6 2017
I do have concerns about this approach, people may rename things and make functional changes together. In this case, we still have 'rename' in the cl description.
,
Oct 26 2017
,
Nov 3 2017
In a case like https://bugs.chromium.org/p/chromium/issues/detail?id=778956 We can check each line of the diff, if every line is a comment line, this should be a comment change cl, we should ignore. This is a easy case for refactoring cls.
,
Nov 6 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by st...@chromium.org
, Apr 21 2016