New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 605753 link

Starred by 1 user
Status: Fixed
Owner:
█ michaeln@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
jsb...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Add storage health metrics

Project Member Reported by dk...@chromium.org, Apr 21 2016 
2016 has several big changes planned for storage - durable storage, increasing quota, etc. In order to be confident in the direction these changes are taking us, we need a comprehensive set of "storage health" metrics.

This bug tracks adding:
- Number of storage requests that are denied vs. allowed
- Storage "liveness". e.g. we want a histogram showing the time since last access of storage on a users device, bucketed by
     - Within the last day
     - Within the last week
     - Within the last month
     - Within the last year
     - Older than a year
Project Member

Comment 1 by bugdroid1@chromium.org, May 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78bab80f86194d0b4983aa42b5e11ea3fca3d0f2

commit 78bab80f86194d0b4983aa42b5e11ea3fca3d0f2
Author: michaeln <michaeln@chromium.org>
Date: Fri May 20 02:59:20 2016

Quota: Add metrics about the age and amount of data stored in temporary storage, and a metric about the computed quota for an origin using temporary storage.

Quota.AgeOfOriginInDays
Quota.AgeOfDataInDays
Quota.QuotaForOrigin

BUG= 605753 

Review-Url: https://codereview.chromium.org/1992813004
Cr-Commit-Position: refs/heads/master@{#394970}

[modify] https://crrev.com/78bab80f86194d0b4983aa42b5e11ea3fca3d0f2/storage/browser/quota/quota_manager.cc
[modify] https://crrev.com/78bab80f86194d0b4983aa42b5e11ea3fca3d0f2/storage/browser/quota/quota_manager.h
[modify] https://crrev.com/78bab80f86194d0b4983aa42b5e11ea3fca3d0f2/tools/metrics/histograms/histograms.xml

Comment 2 by michaeln@chromium.org, May 20 2016

Labels: Merge-Request-52 M-52
Drat, looks like the CL this missed the branch cut by a couple hours so requesting to merge onto m52. The change is very small, it adds 3 uma histograms. We need this information to make reasonable decisions about how to change the behavior of the quota system.

Comment 3 by tin...@google.com, May 21 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10cf79c66a8f4b2100c512ce7b9aa54256aecc7a

commit 10cf79c66a8f4b2100c512ce7b9aa54256aecc7a
Author: Michael Nordman <michaeln@google.com>
Date: Mon May 23 19:52:37 2016

Quota: Add metrics about the age and amount of data stored in temporary storage, and a metric about the computed quota for an origin using temporary storage.

Quota.AgeOfOriginInDays
Quota.AgeOfDataInDays
Quota.QuotaForOrigin

BUG= 605753 

Review-Url: https://codereview.chromium.org/1992813004
Cr-Commit-Position: refs/heads/master@{#394970}
(cherry picked from commit 78bab80f86194d0b4983aa42b5e11ea3fca3d0f2)

Review URL: https://codereview.chromium.org/2007663002 .

Cr-Commit-Position: refs/branch-heads/2743@{#15}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/10cf79c66a8f4b2100c512ce7b9aa54256aecc7a/storage/browser/quota/quota_manager.cc
[modify] https://crrev.com/10cf79c66a8f4b2100c512ce7b9aa54256aecc7a/storage/browser/quota/quota_manager.h
[modify] https://crrev.com/10cf79c66a8f4b2100c512ce7b9aa54256aecc7a/tools/metrics/histograms/histograms.xml

Comment 5 by michaeln@chromium.org, May 23 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment