New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605747 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 616886



Sign in to add a comment

auto-balance pools before sending pool inventory eMail

Project Member Reported by kevcheng@chromium.org, Apr 21 2016

Issue description

Currently the deputy needs to balance pools for all boards that have any broken duts.  We can help them out by balancing out the boards that only have 1 bad broken dut since that is expected given the number of DUTs testing in the lab. 

Here's the plan (after discussing with Richard):

1. First update the run-pool-inventory to call balance_pool.py prior to sending the inventory eMail
2. Refactor lab_inventory.py and balance_pool.py to share a common lib 
3. Merge balance_pool.py functionality into lab_inventory.py and update the run-pool-inventory to just call lab_inventory.py.


 

Comment 1 by benhenry@google.com, Apr 26 2016

Components: Infra>Client>ChromeOS
Labels: -Infra-ChromeOS
Project Member

Comment 2 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/bcc3ebc031e671ff4cd2e7ea33f6bebdd0303a76

commit bcc3ebc031e671ff4cd2e7ea33f6bebdd0303a76
Author: Kevin Cheng <kevcheng@chromium.org>
Date: Tue May 17 23:31:22 2016

Blocking: 616886
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cf0ad2ba0e9df5ca6473f50829235b7cc94163d5

commit cf0ad2ba0e9df5ca6473f50829235b7cc94163d5
Author: Kevin Cheng <kevcheng@chromium.org>
Date: Tue Apr 19 21:51:39 2016

[autotest] Update run-pool-inventory to balance_pool.

Balance out the pool before we send out the notification eMail to the
deputy.

BUG= chromium:605747 , chromium:607200 , chromium:617292 
TEST=locally with dry-run/debug options and unittest

Change-Id: I47cd45fe495e1d46a1a49e97922868de74c5fd02
Reviewed-on: https://chromium-review.googlesource.com/339674
Commit-Ready: Kevin Cheng <kevcheng@chromium.org>
Tested-by: Kevin Cheng <kevcheng@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/cf0ad2ba0e9df5ca6473f50829235b7cc94163d5/site_utils/balance_pools.py
[modify] https://crrev.com/cf0ad2ba0e9df5ca6473f50829235b7cc94163d5/site_utils/lab_inventory_unittest.py
[modify] https://crrev.com/cf0ad2ba0e9df5ca6473f50829235b7cc94163d5/contrib/run-pool-inventory
[modify] https://crrev.com/cf0ad2ba0e9df5ca6473f50829235b7cc94163d5/site_utils/lab_inventory.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4e14f58f594c52fd0a62589fae3ad3a3f14a4b7f

commit 4e14f58f594c52fd0a62589fae3ad3a3f14a4b7f
Author: Kevin Cheng <kevcheng@chromium.org>
Date: Wed Jun 22 20:53:22 2016

run-pool-inventory: Log when we balance the pool.

BUG= chromium:605747 
TEST=none

Change-Id: Ied081019fa18b023505642da8906e0ae029d65bc
Reviewed-on: https://chromium-review.googlesource.com/355160
Commit-Ready: Kevin Cheng <kevcheng@chromium.org>
Tested-by: Kevin Cheng <kevcheng@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/4e14f58f594c52fd0a62589fae3ad3a3f14a4b7f/contrib/run-pool-inventory

Status: Archived (was: Assigned)
Bulk closing Infra>Client>ChromeOS issues untouched in over a year.

Sign in to add a comment