New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605733 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: Nexus 6p device art seems offset

Project Member Reported by paulir...@chromium.org, Apr 21 2016

Issue description

Using canary, 6P and https://news.google.com/#0


 
Screen Shot 2016-04-21 at 2.39.12 PM.png
454 KB View Download
similar issue on iphone 6. same site.

(maybe because not a lot of workspace area?)
Screen Shot 2016-04-21 at 3.28.54 PM.png
258 KB View Download

Comment 2 Deleted

Yeah its due the narrow viewport.  I've got a interim patch coming to just hide the frame when the viewport is too narrow to accommodate it correctly, but I'd to make this more appropriately responsive, as you've described in https://bugs.chromium.org/p/chromium/issues/detail?id=607595
Cc: chowse@chromium.org maxwalker@chromium.org
I think the current offset behavior is better than hiding it outright at given viewport breakpoints (in https://codereview.chromium.org/1947573002/ ).

Slightly better I suppose would be suspending the device-art feature when there's not enough horizontal room for it.. but should this toggle be about the width of the frame or the real viewport? Hard to say.

I'm a little stuck on what the best behavior here should be.

+max, chris. Ideas?

Comment 5 by chowse@chromium.org, Jun 15 2016

Any reason the outer viewport (the "space" the device frame floats within) can't become scrollable when there isn't sufficient room for the frame + inner viewport?

Owner: dgozman@chromium.org
> Any reason the outer viewport (the "space" the device frame floats within) can't become scrollable when there isn't sufficient room for the frame + inner viewport?


This is a question for dgozman, but my understanding is that this is the sort of thing our emulation viewporting stuff can't do. Dmitry, that true?
Status: WontFix (was: Assigned)
I think original problem (from #c1 and #c2) was fixed already.

Scrolling we can do in theory, but I'd rather avoid it. Firefox had scrolling with their device mode, and it was harder to use than our scaling solution. WDYT?

Comment 8 by chowse@chromium.org, Jun 15 2016

Just to clarify, this isn't about scaling vs. scrolling, it's when the user deliberately asks not to scale (i.e. when they choose 100% vs. Fit to Window) and there still isn't room to fit everything. In *that* case, I think it would make sense to add outer scrolling, instead of just truncating as we do now. And I say that as someone who's no fan of nested scrolling. :) But I'll save that for a different bug and a more concrete proposal.

Sign in to add a comment