New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605732 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 606003
issue 618534
issue 619503



Sign in to add a comment

Flip all remaining Linux bots to GN

Project Member Reported by dpranke@chromium.org, Apr 21 2016

Issue description

This is a tracking bug to monitor progress getting the remaining Linux bots onto GN. This includes all of the FYI and memory.fyi bots, but not the CrOS bots.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/ef9df5979d9e39bfc87f71ae04c8687424358eaf

commit ef9df5979d9e39bfc87f71ae04c8687424358eaf
Author: dpranke@chromium.org <dpranke@chromium.org>
Date: Thu Apr 21 22:13:10 2016

Remove obsolete chromium.fyi bots.

This CL removes a bunch of unneeded, unmaintained bots:

- Chromium Builder
- Chromium Builder (dbg)
- Chromium Win MiniInstaller Tests
- Chromium Win x64 Clobber (will move to the chromium master)
- Ozone ECS Linux (obsoleted by Cast bots)
- Vista Tests (dbg)(1)
- Vista Tests (dbg)(2)
- Win8 Tests(1)
- Win8 Tests(2)
- Windows 8 App Certification
- Windows Browser (Drmemory Light) (1)
- Windows Browser (Drmemory Light) (2)
- Windows Builder (DrMemory)
- Windows Tests (DrMemory)

R=scottmg@chromium.org, brucedawson@chromium.org
BUG= 605732 ,  605318 

Review URL: https://codereview.chromium.org/1908133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300095 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/ef9df5979d9e39bfc87f71ae04c8687424358eaf/masters/master.chromium.fyi/master.cfg
[modify] https://crrev.com/ef9df5979d9e39bfc87f71ae04c8687424358eaf/masters/master.chromium.fyi/slaves.cfg
[modify] https://crrev.com/ef9df5979d9e39bfc87f71ae04c8687424358eaf/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
[delete] https://crrev.com/fab0c770b7ce3c9fdad595a6eb001a43550afacb/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Win_Builder.json

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/1c6ede0e70627bea1bdab55d138114cf91125f0b

commit 1c6ede0e70627bea1bdab55d138114cf91125f0b
Author: dpranke@chromium.org <dpranke@chromium.org>
Date: Fri Apr 22 00:17:32 2016

Remove 'Blink Linux LSAN MSAN' bot from chromium.fyi.

We don't have anyone available to work on migrating this
to the main waterfall, recipes, and GN, unfortunately, so
I'm going to remove this.

 Bug 361678  is still open, so hopefully someone can pick it
up in the future and bring the bot online using a recipe, which
should be simple enough given that we have ASAN and MSAN
bots already.

TBR=thestig@chromium.org
BUG= 605732 ,  361678 

Review URL: https://codereview.chromium.org/1904363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300099 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/1c6ede0e70627bea1bdab55d138114cf91125f0b/masters/master.chromium.fyi/master.cfg
[modify] https://crrev.com/1c6ede0e70627bea1bdab55d138114cf91125f0b/masters/master.chromium.fyi/slaves.cfg

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=86917

------------------------------------------------------------------
r86917 | recipe-roller@chromium.org | 2016-04-22T01:42:48.002740Z

-----------------------------------------------------------------
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f6d5a676a05cdfa02e52f98bd4be2910b1c2ca7

commit 1f6d5a676a05cdfa02e52f98bd4be2910b1c2ca7
Author: dpranke <dpranke@chromium.org>
Date: Tue Apr 26 18:53:42 2016

Flip Goma Linux x64 canary bots to GN.

We're long-past due for this ...

R=ukai@chromium.org
BUG= 605732 

Review URL: https://codereview.chromium.org/1915423002

Cr-Commit-Position: refs/heads/master@{#389825}

[modify] https://crrev.com/1f6d5a676a05cdfa02e52f98bd4be2910b1c2ca7/tools/mb/mb_config.pyl

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8510319c1fbb784edeb11ebdb522b00c9a851b1d

commit 8510319c1fbb784edeb11ebdb522b00c9a851b1d
Author: dpranke <dpranke@chromium.org>
Date: Tue Apr 26 22:03:19 2016

Flip remaining non-lkgr linux memory bots to GN.

Also, it turns out that I had missed the chromium.memory waterfall
completely, so add in entries for that.

R=brettw@chromium.org
BUG= 605732 

Review URL: https://codereview.chromium.org/1917043004

Cr-Commit-Position: refs/heads/master@{#389909}

[modify] https://crrev.com/8510319c1fbb784edeb11ebdb522b00c9a851b1d/tools/mb/mb_config.pyl

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e6b0473c43e55d89eb007a2268ac6c0933d3734

commit 8e6b0473c43e55d89eb007a2268ac6c0933d3734
Author: dpranke <dpranke@chromium.org>
Date: Tue Apr 26 22:59:54 2016

Revert of Flip remaining non-lkgr linux memory bots to GN. (patchset #1 id:20001 of https://codereview.chromium.org/1917043004/ )

Reason for revert:
Broke the MSAN builder:

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20MSan%20Builder/builds/20032

Original issue's description:
> Flip remaining non-lkgr linux memory bots to GN.
>
> Also, it turns out that I had missed the chromium.memory waterfall
> completely, so add in entries for that.
>
> R=brettw@chromium.org
> BUG= 605732 
>
> Committed: https://crrev.com/8510319c1fbb784edeb11ebdb522b00c9a851b1d
> Cr-Commit-Position: refs/heads/master@{#389909}

TBR=brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 605732 

Review URL: https://codereview.chromium.org/1924553004

Cr-Commit-Position: refs/heads/master@{#389934}

[modify] https://crrev.com/8e6b0473c43e55d89eb007a2268ac6c0933d3734/tools/mb/mb_config.pyl

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b90dc23f793b456b053666ae2d65d2efa4fac20b

commit b90dc23f793b456b053666ae2d65d2efa4fac20b
Author: dpranke <dpranke@chromium.org>
Date: Wed Apr 27 00:07:14 2016

Flip all remaining Linux x86 (32-bit) bots to GN.

R=brettw@chromium.org
BUG= 605732 

Review URL: https://codereview.chromium.org/1915833004

Cr-Commit-Position: refs/heads/master@{#389949}

[modify] https://crrev.com/b90dc23f793b456b053666ae2d65d2efa4fac20b/tools/mb/mb_config.pyl

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/e959c41d27eedcaa137c1af481da0152314ec1cc

commit e959c41d27eedcaa137c1af481da0152314ec1cc
Author: dpranke@chromium.org <dpranke@chromium.org>
Date: Wed Apr 27 01:13:37 2016

Remove 'ChromiumOS Linux Tests' bot.

This is no longer needed or watched.

TBR=zea@chromium.org, phajdan.jr@chromium.org
BUG= 605732 

Review URL: https://codereview.chromium.org/1916223005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300221 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/e959c41d27eedcaa137c1af481da0152314ec1cc/masters/master.chromium.fyi/master.cfg
[modify] https://crrev.com/e959c41d27eedcaa137c1af481da0152314ec1cc/masters/master.chromium.fyi/slaves.cfg

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11fbe13fadf67a4aa225d5d481a084b2be021de0

commit 11fbe13fadf67a4aa225d5d481a084b2be021de0
Author: dpranke <dpranke@chromium.org>
Date: Wed Apr 27 02:11:45 2016

Flip miscellaneous fyi Linux bots to GN.

This flips a few fyi linux bots to GN, and updates the
MB entries for the code search bots to be correct as well.

TBR=brettw@chromium.org
BUG= 605732 

Review URL: https://codereview.chromium.org/1917113002

Cr-Commit-Position: refs/heads/master@{#389973}

[modify] https://crrev.com/11fbe13fadf67a4aa225d5d481a084b2be021de0/tools/mb/mb_config.pyl

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f817767e0167d205eaac73fbebb63f84758228e7

commit f817767e0167d205eaac73fbebb63f84758228e7
Author: dpranke <dpranke@chromium.org>
Date: Wed Apr 27 06:09:08 2016

Revert of Flip all remaining Linux x86 (32-bit) bots to GN. (patchset #3 id:40001 of https://codereview.chromium.org/1915833004/ )

Reason for revert:
looks like we might have some compile failures to fix:

https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29/builds/52148/steps/compile/logs/stdio

Original issue's description:
> Flip all remaining Linux x86 (32-bit) bots to GN.
>
> R=brettw@chromium.org
> BUG= 605732 
>
> Committed: https://crrev.com/b90dc23f793b456b053666ae2d65d2efa4fac20b
> Cr-Commit-Position: refs/heads/master@{#389949}

TBR=brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 605732 

Review URL: https://codereview.chromium.org/1924733002

Cr-Commit-Position: refs/heads/master@{#389999}

[modify] https://crrev.com/f817767e0167d205eaac73fbebb63f84758228e7/tools/mb/mb_config.pyl

"Linux Tests (dbg)(1)(32)" bot has exploded and is inexorably spamming sheriff-o-matic.  Please look into it.

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)(32)
It looks like the isolates are busted. I'm on it.
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41a986d9eded066e3e321c7de80192aaee3e36a5

commit 41a986d9eded066e3e321c7de80192aaee3e36a5
Author: dpranke <dpranke@chromium.org>
Date: Thu Apr 28 21:02:44 2016

Flip remaining Linux x86 bots to GN.

Apparently I missed these earlier ...

TBR=brettw@chromium.org
BUG= 605732 ,  590004 

Review-Url: https://codereview.chromium.org/1928093002
Cr-Commit-Position: refs/heads/master@{#390478}

[modify] https://crrev.com/41a986d9eded066e3e321c7de80192aaee3e36a5/tools/mb/mb_config.pyl

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f0fd54a71eff93fbb3372b0957d373be0860f90

commit 7f0fd54a71eff93fbb3372b0957d373be0860f90
Author: thakis <thakis@chromium.org>
Date: Thu Apr 28 21:44:35 2016

Switch ClangToTLinux (dbg) from gyp to gn.

Other ClangToTLinux bots to follow.

BUG= 605732 

Review-Url: https://codereview.chromium.org/1931993002
Cr-Commit-Position: refs/heads/master@{#390493}

[modify] https://crrev.com/7f0fd54a71eff93fbb3372b0957d373be0860f90/tools/mb/mb_config.pyl

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7349bcba787c5ed47780fe1de8a7a158922c8fb2

commit 7349bcba787c5ed47780fe1de8a7a158922c8fb2
Author: dpranke <dpranke@chromium.org>
Date: Thu Apr 28 22:13:17 2016

Revert of Flip remaining Linux x86 bots to GN. (patchset #1 id:1 of https://codereview.chromium.org/1928093002/ )

Reason for revert:
looks like some mojo targets might be broken:

http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20(dbg)(32)/builds/52253

Original issue's description:
> Flip remaining Linux x86 bots to GN.
>
> Apparently I missed these earlier ...
>
> TBR=brettw@chromium.org
> BUG= 605732 ,  590004 

TBR=brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 605732 ,  590004 

Review-Url: https://codereview.chromium.org/1925403002
Cr-Commit-Position: refs/heads/master@{#390504}

[modify] https://crrev.com/7349bcba787c5ed47780fe1de8a7a158922c8fb2/tools/mb/mb_config.pyl

Blockedon: 606003
Project Member

Comment 18 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09aef466c98076fcccb2e8cd3903f05c4348bf83

commit 09aef466c98076fcccb2e8cd3903f05c4348bf83
Author: thakis <thakis@chromium.org>
Date: Fri Apr 29 16:59:09 2016

Switch ClangToTLinuxASan from gyp to gn.

The other two ClangToTLinux bots are blocked on other things happening
first (ubsan tests aren't green in gn builds yet,  crbug.com/606003 ,
and gn doesn't have linux_dump_symbols yet,  crbug.com/605819 )

BUG= 605732 

Review-Url: https://codereview.chromium.org/1924173004
Cr-Commit-Position: refs/heads/master@{#390676}

[modify] https://crrev.com/09aef466c98076fcccb2e8cd3903f05c4348bf83/tools/mb/mb_config.pyl

Project Member

Comment 19 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/341939b904f5d6079e3c13f7678a242359275263

commit 341939b904f5d6079e3c13f7678a242359275263
Author: thakis <thakis@chromium.org>
Date: Fri Apr 29 18:44:57 2016

Revert of Switch ClangToTLinuxASan from gyp to gn. (patchset #1 id:1 of https://codereview.chromium.org/1924173004/ )

Reason for revert:
ASan builds don't work in gn yet (for nacl targets): https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/4000/steps/compile/logs/stdio

[822/41484] LINK ./libc_free_x86_64.nexe
FAILED: libc_free_x86_64.nexe
../../third_party/llvm-build/Release+Asserts/bin/clang++ -nostdlib -shared -Wl,--no-undefined -Qunused-arguments -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold -pthread -m64 -Wl,-O1 -Wl,--gc-sections --sysroot=../../build/linux/debian_wheezy_amd64-sysroot  -fsanitize=address -fsanitize=leak -Wl,-rpath-link=../Release -Wl,--disable-new-dtags -Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -o "./libc_free_x86_64.nexe" -Wl,--start-group @"./libc_free_x86_64.nexe.rsp"  -Wl,--end-group  -ldl -lrt
../../chrome/test/data/nacl/nonsfi/libc_free.c:214: error: undefined reference to '__asan_option_detect_stack_use_after_return'
../../chrome/test/data/nacl/nonsfi/libc_free.c:214: error: undefined reference to '__asan_stack_malloc_1'

Original issue's description:
> Switch ClangToTLinuxASan from gyp to gn.
>
> The other two ClangToTLinux bots are blocked on other things happening
> first (ubsan tests aren't green in gn builds yet,  crbug.com/606003 ,
> and gn doesn't have linux_dump_symbols yet,  crbug.com/605819 )
>
> BUG= 605732 

TBR=hans@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 605732 

Review-Url: https://codereview.chromium.org/1932333002
Cr-Commit-Position: refs/heads/master@{#390708}

[modify] https://crrev.com/341939b904f5d6079e3c13f7678a242359275263/tools/mb/mb_config.pyl

Blocking: 610748
Project Member

Comment 22 by bugdroid1@chromium.org, May 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1045c7f37c59613f07916dd15156ab306a7f9402

commit 1045c7f37c59613f07916dd15156ab306a7f9402
Author: finnur <finnur@chromium.org>
Date: Tue May 17 15:37:45 2016

Revert of Try again to flip x86 Linux bots to GN. (patchset #10 id:180001 of https://codereview.chromium.org/1928223002/ )

Reason for revert:
Checking to see if the error on the Linux bot goes away.
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/29008

Original issue's description:
> Try again to flip x86 Linux bots to GN.
>
> R=thakis@chromium.org
> BUG= 590004 ,  605732 
>
> Committed: https://crrev.com/e683ff3c1ac97d565f8676c13eac00c64de0c2f4
> Cr-Commit-Position: refs/heads/master@{#393920}

TBR=thakis@chromium.org,machenbach@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 590004 ,  605732 

Review-Url: https://codereview.chromium.org/1982203004
Cr-Commit-Position: refs/heads/master@{#394132}

[modify] https://crrev.com/1045c7f37c59613f07916dd15156ab306a7f9402/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/1045c7f37c59613f07916dd15156ab306a7f9402/tools/mb/mb_config.pyl

Cc: brettw@chromium.org
We're long overdue for an update on this.

As of now (5/23), there are, as far as I can tell, 28 non-ChromeOS, non-Android Linux bots  on the chromium waterfalls that are still using GYP). 

I've posted the following CLs to flip them over to GN:

https://codereview.chromium.org/1914313002 (7 bots on chromium.memory.*)

https://codereview.chromium.org/2006163004/ (a v8 change needed for the next CL).
ttps://codereview.chromium.org/2006173002/ (14 bots on chromium.lkgr)

https://codereview.chromium.org/2000413002/ (3 bots on chromium.fyi)

https://codereview.chromium.org/2006983002/ (1 bot on tryserver.chromium.linux)

https://codereview.chromium.org/2001163003/ (1 bot on tryserver.chromium.linux)

https://codereview.chromium.org/2001133003/ (2 bots on tryserver.chromium.linux)
https://codereview.chromium.org/2006163003/ (a build-side change dependent on the previous CL).

Once they all land I believe we can turn GYP off on Linux.
Project Member

Comment 25 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4ad43e579b880f6c432b5a530b45f8d39ebfe99

commit f4ad43e579b880f6c432b5a530b45f8d39ebfe99
Author: dpranke <dpranke@chromium.org>
Date: Tue May 24 03:07:07 2016

Flip webkit bots to GN (again)

This re-lands #392218, now that we've cleared the M52 branch.

TBR=brettw@chromium.org
BUG= 605732 ,  605318 

Review-Url: https://codereview.chromium.org/2000283003
Cr-Commit-Position: refs/heads/master@{#395525}

[modify] https://crrev.com/f4ad43e579b880f6c432b5a530b45f8d39ebfe99/tools/mb/mb_config.pyl

Project Member

Comment 26 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3be95b712c2f5acfb189b60cb3e4ba3600a66ba8

commit 3be95b712c2f5acfb189b60cb3e4ba3600a66ba8
Author: machenbach <machenbach@chromium.org>
Date: Tue May 24 08:54:42 2016

[gn] Make v8_target_arch a GN declare_arg()

There are bots on the chromium.lkgr waterfall that need to
be able to set v8_target_arch to "arm" while the rest of
the target build is "x86". This CL makes that argument
a declare_arg(), so that we can do that.

BUG= chromium:605732 , chromium:474921 
NOTRY=true

Review-Url: https://codereview.chromium.org/2007843002
Cr-Commit-Position: refs/heads/master@{#36464}

[modify] https://crrev.com/3be95b712c2f5acfb189b60cb3e4ba3600a66ba8/BUILD.gn
[modify] https://crrev.com/3be95b712c2f5acfb189b60cb3e4ba3600a66ba8/build_overrides/v8.gni
[add] https://crrev.com/3be95b712c2f5acfb189b60cb3e4ba3600a66ba8/gni/v8.gni

Project Member

Comment 27 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/52c4010ff79707fe76129a73f3930886ff2049b9

commit 52c4010ff79707fe76129a73f3930886ff2049b9
Author: machenbach <machenbach@chromium.org>
Date: Tue May 24 10:39:57 2016

[gn] Fix setting v8_target_arch default

This moves setting the v8_target_arch default to the shared
v8.gni, so that it's available in build_overrides for
stand-alone mode.

BUG= chromium:605732 ,  chromium:474921 
NOTRY=true

Review-Url: https://codereview.chromium.org/2006213002
Cr-Commit-Position: refs/heads/master@{#36465}

[modify] https://crrev.com/52c4010ff79707fe76129a73f3930886ff2049b9/BUILD.gn
[modify] https://crrev.com/52c4010ff79707fe76129a73f3930886ff2049b9/gni/v8.gni

Project Member

Comment 28 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02eac1e1f7a1f61ae63d7f6cea545920e0eafb8a

commit 02eac1e1f7a1f61ae63d7f6cea545920e0eafb8a
Author: dpranke <dpranke@chromium.org>
Date: Wed May 25 00:13:22 2016

Flip linux_nacl_sdk* bots to GN

R=bradnelson@chromium.org
BUG= 605732 

Review-Url: https://codereview.chromium.org/2001133003
Cr-Commit-Position: refs/heads/master@{#395746}

[modify] https://crrev.com/02eac1e1f7a1f61ae63d7f6cea545920e0eafb8a/tools/mb/mb_config.pyl

Project Member

Comment 29 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19eaeb5307be9770b35d34a741a682a7d7856295

commit 19eaeb5307be9770b35d34a741a682a7d7856295
Author: dpranke <dpranke@chromium.org>
Date: Wed May 25 02:16:30 2016

Flip linux_chromium_browser_side_navigation_rel to GN.

R=carlosk@chromium.org
BUG= 605732 

Review-Url: https://codereview.chromium.org/2006983002
Cr-Commit-Position: refs/heads/master@{#395781}

[modify] https://crrev.com/19eaeb5307be9770b35d34a741a682a7d7856295/tools/mb/mb_config.pyl

Project Member

Comment 30 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c071298d2f98c65aff91bbc30a9caac3fea22ddc

commit c071298d2f98c65aff91bbc30a9caac3fea22ddc
Author: dpranke <dpranke@chromium.org>
Date: Tue May 31 22:34:39 2016

Flip linux_arm bot to GN.

R=bradnelson@chromium.org
BUG= 605732 

Review-Url: https://codereview.chromium.org/2001163003
Cr-Commit-Position: refs/heads/master@{#396954}

[modify] https://crrev.com/c071298d2f98c65aff91bbc30a9caac3fea22ddc/tools/mb/mb_config.pyl

Project Member

Comment 31 by bugdroid1@chromium.org, Jun 5 2016

Project Member

Comment 32 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28d0742cd7809dbf187d2979d2cb00551f30ad78

commit 28d0742cd7809dbf187d2979d2cb00551f30ad78
Author: dpranke <dpranke@chromium.org>
Date: Mon Jun 06 04:54:18 2016

Flip Linux memory, memory.fyi ASAN, TSAN bots to GN.

and the matching tryservers on chromium.linux ...

R=brettw@chromium.org, inferno@chromium.org
BUG= 605732 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_asan_rel_ng,linux_chromium_tsan_rel_ng

Review-Url: https://codereview.chromium.org/2035533002
Cr-Commit-Position: refs/heads/master@{#397972}

[modify] https://crrev.com/28d0742cd7809dbf187d2979d2cb00551f30ad78/tools/mb/mb_config.pyl

Project Member

Comment 33 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6864dbb0407a47f697901f70105d2c2c829c08bc

commit 6864dbb0407a47f697901f70105d2c2c829c08bc
Author: dpranke <dpranke@chromium.org>
Date: Mon Jun 06 16:03:11 2016

Flip Linux bots on chromium.lkgr to GN.

R=brettw@chromium.org, inferno@chromium.org
BUG= 605732 

Review-Url: https://codereview.chromium.org/2006173002
Cr-Commit-Position: refs/heads/master@{#398038}

[modify] https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc/tools/mb/mb_config.pyl

Project Member

Comment 34 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abb3e13504ad431a85e9239d0e01d2a685382bf2

commit abb3e13504ad431a85e9239d0e01d2a685382bf2
Author: dpranke <dpranke@chromium.org>
Date: Mon Jun 06 17:28:36 2016

Flip linux clang tot bots to GN.

R=thakis@chromium.org
BUG= 605732 

Review-Url: https://codereview.chromium.org/2000413002
Cr-Commit-Position: refs/heads/master@{#398053}

[modify] https://crrev.com/abb3e13504ad431a85e9239d0e01d2a685382bf2/tools/mb/mb_config.pyl

Project Member

Comment 35 by bugdroid1@chromium.org, Jun 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/69333923c96290946b7279e8f3541eb1aba7cc58

commit 69333923c96290946b7279e8f3541eb1aba7cc58
Author: dpranke <dpranke@chromium.org>
Date: Mon Jun 06 22:28:28 2016

Flip builders on chromium.memory to MB.

Somehow we missed these before :(.

TBR=brettw@chromium.org
BUG= 605732 

Review-Url: https://codereview.chromium.org/2045743002

[modify] https://crrev.com/69333923c96290946b7279e8f3541eb1aba7cc58/scripts/slave/recipe_modules/chromium_tests/chromium_memory.py
[modify] https://crrev.com/69333923c96290946b7279e8f3541eb1aba7cc58/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_builder.json
[modify] https://crrev.com/69333923c96290946b7279e8f3541eb1aba7cc58/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_ASan_LSan_Builder.json
[modify] https://crrev.com/69333923c96290946b7279e8f3541eb1aba7cc58/scripts/slave/recipes/chromium.expected/full_chromium_memory_Linux_Chromium_OS_ASan_LSan_Builder.json
[modify] https://crrev.com/69333923c96290946b7279e8f3541eb1aba7cc58/scripts/slave/recipes/chromium.expected/full_chromium_memory_Mac_ASan_64_Builder.json
[modify] https://crrev.com/69333923c96290946b7279e8f3541eb1aba7cc58/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_asan_rel_ng.json
[modify] https://crrev.com/69333923c96290946b7279e8f3541eb1aba7cc58/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_asan_rel_ng.json
[modify] https://crrev.com/69333923c96290946b7279e8f3541eb1aba7cc58/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_asan_rel_ng.json

Project Member

Comment 36 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fade21eff0b7bbc3df25c0593de180717470650e

commit fade21eff0b7bbc3df25c0593de180717470650e
Author: dpranke <dpranke@chromium.org>
Date: Tue Jun 07 01:18:52 2016

Update MB config with missing builder entries, etc.

It had been a while since I'd run `mb audit` and there were
a few new builders that didn't have entries. This adds those,
removes some builders that are gone, and fixes some typos.

TBR=brettw@chromium.org
BUG= 605732 

Review-Url: https://codereview.chromium.org/2047583002
Cr-Commit-Position: refs/heads/master@{#398188}

[modify] https://crrev.com/fade21eff0b7bbc3df25c0593de180717470650e/tools/mb/mb_config.pyl

Project Member

Comment 37 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7319eac326e6a9474a572cebd0c6fff9a5035ad0

commit 7319eac326e6a9474a572cebd0c6fff9a5035ad0
Author: dpranke <dpranke@chromium.org>
Date: Tue Jun 07 03:24:32 2016

Flip LKGR/ClusterFuzz, WebKit MSAN bots back to GYP.

There were a couple of build file issues that broke the ASAN Debug
bot and the MSAN bots on the lkgr waterfall. This CL fixes those issues,
and also flips the MSAN bots back to GYP since the main MSAN bots
are still kinda broken and it's easier to keep them all consistent.

TBR=mbarbella@chromium.org
BUG= 605732 

Review-Url: https://codereview.chromium.org/2048513002
Cr-Commit-Position: refs/heads/master@{#398215}

[modify] https://crrev.com/7319eac326e6a9474a572cebd0c6fff9a5035ad0/build/config/sanitizers/sanitizers.gni
[modify] https://crrev.com/7319eac326e6a9474a572cebd0c6fff9a5035ad0/third_party/instrumented_libraries/BUILD.gn
[modify] https://crrev.com/7319eac326e6a9474a572cebd0c6fff9a5035ad0/tools/mb/mb_config.pyl

Latest status: Every bot has been flipped except for the three MSAN bots. I have a CL in flight that will hopefully flip them and stay green (by disabling some failing tests), and we can flip those and then fix the remaining failures afterwards.
Project Member

Comment 39 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/424b728048335ebf880781b600f65fc7d993e206

commit 424b728048335ebf880781b600f65fc7d993e206
Author: thakis <thakis@chromium.org>
Date: Thu Jun 09 16:29:04 2016

Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2006173002/ )

Reason for revert:
This had no effect: The LKGR waterfall used to be not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to out/None (and runhooks still ran gyp, so gyp's ninja files were always used).

I've now switched most of the bots to recipes, and now gn does have an effect, and all the bots now fail to build 'cause they build "chromium_builder_asan", a target that doesn't exist in the gn build.

Reverting to get back to a working state. I'll look at fixing and will hopefully reland this soon.

Original issue's description:
> Flip Linux bots on chromium.lkgr to GN.
>
> R=brettw@chromium.org, inferno@chromium.org
> BUG= 605732 
>
> Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc
> Cr-Commit-Position: refs/heads/master@{#398038}

TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 605732 

Review-Url: https://codereview.chromium.org/2054843002
Cr-Commit-Position: refs/heads/master@{#398904}

[modify] https://crrev.com/424b728048335ebf880781b600f65fc7d993e206/tools/mb/mb_config.pyl

Project Member

Comment 40 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4e9b9ce3b7b6309477ac846f5ff8b565745fd75

commit e4e9b9ce3b7b6309477ac846f5ff8b565745fd75
Author: thakis <thakis@chromium.org>
Date: Fri Jun 10 20:17:54 2016

Reland of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:60001 of https://codereview.chromium.org/2054843002/ )

Reason for revert:
This might work now (see  https://crbug.com/618702 , which I forgot to mention in the revert message).

Original issue's description:
> Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2006173002/ )
>
> Reason for revert:
> This had no effect: The LKGR waterfall used to be not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to out/None (and runhooks still ran gyp, so gyp's ninja files were always used).
>
> I've now switched most of the bots to recipes, and now gn does have an effect, and all the bots now fail to build 'cause they build "chromium_builder_asan", a target that doesn't exist in the gn build.
>
> Reverting to get back to a working state. I'll look at fixing and will hopefully reland this soon.
>
> Original issue's description:
> > Flip Linux bots on chromium.lkgr to GN.
> >
> > R=brettw@chromium.org, inferno@chromium.org
> > BUG= 605732 
> >
> > Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc
> > Cr-Commit-Position: refs/heads/master@{#398038}
>
> TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 605732 
>
> Committed: https://crrev.com/424b728048335ebf880781b600f65fc7d993e206
> Cr-Commit-Position: refs/heads/master@{#398904}

TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 605732 

Review-Url: https://codereview.chromium.org/2057193003
Cr-Commit-Position: refs/heads/master@{#399261}

[modify] https://crrev.com/e4e9b9ce3b7b6309477ac846f5ff8b565745fd75/tools/mb/mb_config.pyl

Project Member

Comment 41 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/746d6c13d1c1463f52adc42381a584dc7029ba6e

commit 746d6c13d1c1463f52adc42381a584dc7029ba6e
Author: dpranke <dpranke@chromium.org>
Date: Fri Jun 10 23:50:03 2016

Flip Linux MSAN (non-CF) bots to GN.

The CF bots on chromium.lkgr will be flipped in a separate CL.

R=brettw@chromium.org, inferno@chromium.org
BUG= 605732 

Review-Url: https://codereview.chromium.org/2033483003
Cr-Commit-Position: refs/heads/master@{#399324}

[modify] https://crrev.com/746d6c13d1c1463f52adc42381a584dc7029ba6e/tools/mb/mb_config.pyl

Project Member

Comment 42 by bugdroid1@chromium.org, Jun 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a28320ff1113f0a858b0d32fb762aa3b44be2696

commit a28320ff1113f0a858b0d32fb762aa3b44be2696
Author: dpranke <dpranke@chromium.org>
Date: Sat Jun 11 22:55:48 2016

Flip remaining Linux builders to GN.

This CL flips the last remaining Linux builders to GN, the
MSAN builders on the chromium.lkgr and chromium.webkit
waterfalls.

TBR=brettw@chromium.org, thakis@chromium.org, inferno@chromium.org
BUG= 605732 

Review-Url: https://codereview.chromium.org/2059003003
Cr-Commit-Position: refs/heads/master@{#399381}

[modify] https://crrev.com/a28320ff1113f0a858b0d32fb762aa3b44be2696/tools/mb/mb_config.pyl

Status: Fixed (was: Started)
!
Blockedon: 618534
Blockedon: 619503
Project Member

Comment 46 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d83c5cb290e0e17caf4ff38d25719030780f60db

commit d83c5cb290e0e17caf4ff38d25719030780f60db
Author: thakis <thakis@chromium.org>
Date: Mon Jun 13 11:00:22 2016

Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #1 id:1 of https://codereview.chromium.org/2057193003/ )

Reason for revert:
This breaks:

* UBSan vptr Release: https://build.chromium.org/p/chromium.lkgr/builders/UBSan%20vptr%20Release/builds/3782/steps/compile/logs/stdio
clang: error: argument unused during compilation: '-fsanitize-coverage=edge'
This is  https://crbug.com/618534 

* The 3 32-bit x86 with 32-bit arm v8 asan bots, e.g. https://build.chromium.org/p/chromium.lkgr/builders/ASan%20Debug%20%2832-bit%20x86%20with%20V8-ARM%29/builds/2477/steps/compile/logs/stdio
../../v8/src/base/build_config.h:145:2: error: Target architecture ia32 is only supported on ia32 host
#error Target architecture ia32 is only supported on ia32 host
 ^
I filed  https://crbug.com/619503  for this.

Original issue's description:
> Reland of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:60001 of https://codereview.chromium.org/2054843002/ )
>
> Reason for revert:
> This might work now (see  https://crbug.com/618702 , which I forgot to mention in the revert message).
>
> Original issue's description:
> > Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2006173002/ )
> >
> > Reason for revert:
> > This had no effect: The LKGR waterfall used to be not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to out/None (and runhooks still ran gyp, so gyp's ninja files were always used).
> >
> > I've now switched most of the bots to recipes, and now gn does have an effect, and all the bots now fail to build 'cause they build "chromium_builder_asan", a target that doesn't exist in the gn build.
> >
> > Reverting to get back to a working state. I'll look at fixing and will hopefully reland this soon.
> >
> > Original issue's description:
> > > Flip Linux bots on chromium.lkgr to GN.
> > >
> > > R=brettw@chromium.org, inferno@chromium.org
> > > BUG= 605732 
> > >
> > > Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc
> > > Cr-Commit-Position: refs/heads/master@{#398038}
> >
> > TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG= 605732 
> >
> > Committed: https://crrev.com/424b728048335ebf880781b600f65fc7d993e206
> > Cr-Commit-Position: refs/heads/master@{#398904}
>
> TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 605732 
>
> Committed: https://crrev.com/e4e9b9ce3b7b6309477ac846f5ff8b565745fd75
> Cr-Commit-Position: refs/heads/master@{#399261}

TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 605732 
NOTRY=true

Review-Url: https://codereview.chromium.org/2063673002
Cr-Commit-Position: refs/heads/master@{#399427}

[modify] https://crrev.com/d83c5cb290e0e17caf4ff38d25719030780f60db/tools/mb/mb_config.pyl

Status: Started (was: Fixed)
Project Member

Comment 48 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/424b728048335ebf880781b600f65fc7d993e206

commit 424b728048335ebf880781b600f65fc7d993e206
Author: thakis <thakis@chromium.org>
Date: Thu Jun 09 16:29:04 2016

Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2006173002/ )

Reason for revert:
This had no effect: The LKGR waterfall used to be not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to out/None (and runhooks still ran gyp, so gyp's ninja files were always used).

I've now switched most of the bots to recipes, and now gn does have an effect, and all the bots now fail to build 'cause they build "chromium_builder_asan", a target that doesn't exist in the gn build.

Reverting to get back to a working state. I'll look at fixing and will hopefully reland this soon.

Original issue's description:
> Flip Linux bots on chromium.lkgr to GN.
>
> R=brettw@chromium.org, inferno@chromium.org
> BUG= 605732 
>
> Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc
> Cr-Commit-Position: refs/heads/master@{#398038}

TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 605732 

Review-Url: https://codereview.chromium.org/2054843002
Cr-Commit-Position: refs/heads/master@{#398904}

[modify] https://crrev.com/424b728048335ebf880781b600f65fc7d993e206/tools/mb/mb_config.pyl

Project Member

Comment 49 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4e9b9ce3b7b6309477ac846f5ff8b565745fd75

commit e4e9b9ce3b7b6309477ac846f5ff8b565745fd75
Author: thakis <thakis@chromium.org>
Date: Fri Jun 10 20:17:54 2016

Reland of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:60001 of https://codereview.chromium.org/2054843002/ )

Reason for revert:
This might work now (see  https://crbug.com/618702 , which I forgot to mention in the revert message).

Original issue's description:
> Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2006173002/ )
>
> Reason for revert:
> This had no effect: The LKGR waterfall used to be not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to out/None (and runhooks still ran gyp, so gyp's ninja files were always used).
>
> I've now switched most of the bots to recipes, and now gn does have an effect, and all the bots now fail to build 'cause they build "chromium_builder_asan", a target that doesn't exist in the gn build.
>
> Reverting to get back to a working state. I'll look at fixing and will hopefully reland this soon.
>
> Original issue's description:
> > Flip Linux bots on chromium.lkgr to GN.
> >
> > R=brettw@chromium.org, inferno@chromium.org
> > BUG= 605732 
> >
> > Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc
> > Cr-Commit-Position: refs/heads/master@{#398038}
>
> TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 605732 
>
> Committed: https://crrev.com/424b728048335ebf880781b600f65fc7d993e206
> Cr-Commit-Position: refs/heads/master@{#398904}

TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 605732 

Review-Url: https://codereview.chromium.org/2057193003
Cr-Commit-Position: refs/heads/master@{#399261}

[modify] https://crrev.com/e4e9b9ce3b7b6309477ac846f5ff8b565745fd75/tools/mb/mb_config.pyl

Project Member

Comment 50 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/746d6c13d1c1463f52adc42381a584dc7029ba6e

commit 746d6c13d1c1463f52adc42381a584dc7029ba6e
Author: dpranke <dpranke@chromium.org>
Date: Fri Jun 10 23:50:03 2016

Flip Linux MSAN (non-CF) bots to GN.

The CF bots on chromium.lkgr will be flipped in a separate CL.

R=brettw@chromium.org, inferno@chromium.org
BUG= 605732 

Review-Url: https://codereview.chromium.org/2033483003
Cr-Commit-Position: refs/heads/master@{#399324}

[modify] https://crrev.com/746d6c13d1c1463f52adc42381a584dc7029ba6e/tools/mb/mb_config.pyl

Project Member

Comment 51 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a28320ff1113f0a858b0d32fb762aa3b44be2696

commit a28320ff1113f0a858b0d32fb762aa3b44be2696
Author: dpranke <dpranke@chromium.org>
Date: Sat Jun 11 22:55:48 2016

Flip remaining Linux builders to GN.

This CL flips the last remaining Linux builders to GN, the
MSAN builders on the chromium.lkgr and chromium.webkit
waterfalls.

TBR=brettw@chromium.org, thakis@chromium.org, inferno@chromium.org
BUG= 605732 

Review-Url: https://codereview.chromium.org/2059003003
Cr-Commit-Position: refs/heads/master@{#399381}

[modify] https://crrev.com/a28320ff1113f0a858b0d32fb762aa3b44be2696/tools/mb/mb_config.pyl

Project Member

Comment 52 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d83c5cb290e0e17caf4ff38d25719030780f60db

commit d83c5cb290e0e17caf4ff38d25719030780f60db
Author: thakis <thakis@chromium.org>
Date: Mon Jun 13 11:00:22 2016

Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #1 id:1 of https://codereview.chromium.org/2057193003/ )

Reason for revert:
This breaks:

* UBSan vptr Release: https://build.chromium.org/p/chromium.lkgr/builders/UBSan%20vptr%20Release/builds/3782/steps/compile/logs/stdio
clang: error: argument unused during compilation: '-fsanitize-coverage=edge'
This is  https://crbug.com/618534 

* The 3 32-bit x86 with 32-bit arm v8 asan bots, e.g. https://build.chromium.org/p/chromium.lkgr/builders/ASan%20Debug%20%2832-bit%20x86%20with%20V8-ARM%29/builds/2477/steps/compile/logs/stdio
../../v8/src/base/build_config.h:145:2: error: Target architecture ia32 is only supported on ia32 host
#error Target architecture ia32 is only supported on ia32 host
 ^
I filed  https://crbug.com/619503  for this.

Original issue's description:
> Reland of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:60001 of https://codereview.chromium.org/2054843002/ )
>
> Reason for revert:
> This might work now (see  https://crbug.com/618702 , which I forgot to mention in the revert message).
>
> Original issue's description:
> > Revert of Flip Linux bots on chromium.lkgr to GN. (patchset #3 id:40001 of https://codereview.chromium.org/2006173002/ )
> >
> > Reason for revert:
> > This had no effect: The LKGR waterfall used to be not on recipes, and mb wasn't hooked up right and in gn mode wrote its output to out/None (and runhooks still ran gyp, so gyp's ninja files were always used).
> >
> > I've now switched most of the bots to recipes, and now gn does have an effect, and all the bots now fail to build 'cause they build "chromium_builder_asan", a target that doesn't exist in the gn build.
> >
> > Reverting to get back to a working state. I'll look at fixing and will hopefully reland this soon.
> >
> > Original issue's description:
> > > Flip Linux bots on chromium.lkgr to GN.
> > >
> > > R=brettw@chromium.org, inferno@chromium.org
> > > BUG= 605732 
> > >
> > > Committed: https://crrev.com/6864dbb0407a47f697901f70105d2c2c829c08bc
> > > Cr-Commit-Position: refs/heads/master@{#398038}
> >
> > TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG= 605732 
> >
> > Committed: https://crrev.com/424b728048335ebf880781b600f65fc7d993e206
> > Cr-Commit-Position: refs/heads/master@{#398904}
>
> TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 605732 
>
> Committed: https://crrev.com/e4e9b9ce3b7b6309477ac846f5ff8b565745fd75
> Cr-Commit-Position: refs/heads/master@{#399261}

TBR=brettw@chromium.org,inferno@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 605732 
NOTRY=true

Review-Url: https://codereview.chromium.org/2063673002
Cr-Commit-Position: refs/heads/master@{#399427}

[modify] https://crrev.com/d83c5cb290e0e17caf4ff38d25719030780f60db/tools/mb/mb_config.pyl

Project Member

Comment 53 by bugdroid1@chromium.org, Jun 17 2016

Project Member

Comment 54 by bugdroid1@chromium.org, Jun 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bba497d30d460399a070f121d3fb873e1bf13fd2

commit bba497d30d460399a070f121d3fb873e1bf13fd2
Author: dpranke <dpranke@chromium.org>
Date: Sun Jun 19 03:14:00 2016

Re-land "Flip Linux bots on chromium.lkgr to GN."

This re-lands r398038 now that the bugs have been fixed. It also
flips the CrOS ASAN builder.

TBR=thakis@chromium.org, inferno@chromium.org
BUG= 605732 

Review-Url: https://codereview.chromium.org/2073403002
Cr-Commit-Position: refs/heads/master@{#400609}

[modify] https://crrev.com/bba497d30d460399a070f121d3fb873e1bf13fd2/tools/mb/mb_config.pyl

Project Member

Comment 55 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2f0026c60bd81ccef3e4a0d1102bf985751fc04

commit f2f0026c60bd81ccef3e4a0d1102bf985751fc04
Author: dpranke <dpranke@chromium.org>
Date: Mon Jun 20 22:24:15 2016

Revert of Re-land "Flip Linux bots on chromium.lkgr to GN." (patchset #2 id:20001 of https://codereview.chromium.org/2073403002/ )

Reason for revert:
Things are still broken (see  crbug.com/621581 ).

Original issue's description:
> Re-land "Flip Linux bots on chromium.lkgr to GN."
>
> This re-lands r398038 now that the bugs have been fixed. It also
> flips the CrOS ASAN builder.
>
> TBR=thakis@chromium.org, inferno@chromium.org
> BUG= 605732 
>
> Committed: https://crrev.com/bba497d30d460399a070f121d3fb873e1bf13fd2
> Cr-Commit-Position: refs/heads/master@{#400609}

TBR=inferno@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 605732 

Review-Url: https://codereview.chromium.org/2082793002
Cr-Commit-Position: refs/heads/master@{#400812}

[modify] https://crrev.com/f2f0026c60bd81ccef3e4a0d1102bf985751fc04/tools/mb/mb_config.pyl

Blocking: -610748
Blocking: 432959
Labels: -Pri-1 Pri-2
Downgrading to P2 to make sure any M53-blockers get precedence.
Blocking: -432959
As suggested by laforge@ and a conversation w/ the monorail folks, I'm going to try tracking GN-Migration related issues by *just* using the Proj-GN-Migration label, and not using blocking/rollup bugs, so that we can use blocking for just tasks that truly need to be completed before other tasks can make progress.
Project Member

Comment 60 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6005ec2eabdd816c0d2c76f738018d6f3c46c1aa

commit 6005ec2eabdd816c0d2c76f738018d6f3c46c1aa
Author: dpranke <dpranke@chromium.org>
Date: Wed Jul 13 17:15:55 2016

Flip CrOS ozone builders to GN.

Specifically:

- chromium.chromiumos
  - Linux ChromiumOS Ozone Builder
- tryserver.chromium.linux
  - linux_chromium_chromeos_ozone_rel_ng

These are the last main CrOS builders on GYP. There are still
three memory-related builders on GYP, waiting for the "v8_target_cpu"
fixes to land ...

R=stevenjb@chromium.org
BUG= 605732 

Review-Url: https://codereview.chromium.org/2143453002
Cr-Commit-Position: refs/heads/master@{#405206}

[modify] https://crrev.com/6005ec2eabdd816c0d2c76f738018d6f3c46c1aa/tools/mb/mb_config.pyl

Project Member

Comment 61 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6005ec2eabdd816c0d2c76f738018d6f3c46c1aa

commit 6005ec2eabdd816c0d2c76f738018d6f3c46c1aa
Author: dpranke <dpranke@chromium.org>
Date: Wed Jul 13 17:15:55 2016

Flip CrOS ozone builders to GN.

Specifically:

- chromium.chromiumos
  - Linux ChromiumOS Ozone Builder
- tryserver.chromium.linux
  - linux_chromium_chromeos_ozone_rel_ng

These are the last main CrOS builders on GYP. There are still
three memory-related builders on GYP, waiting for the "v8_target_cpu"
fixes to land ...

R=stevenjb@chromium.org
BUG= 605732 

Review-Url: https://codereview.chromium.org/2143453002
Cr-Commit-Position: refs/heads/master@{#405206}

[modify] https://crrev.com/6005ec2eabdd816c0d2c76f738018d6f3c46c1aa/tools/mb/mb_config.pyl

Project Member

Comment 62 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a5d7f965cc6130fde6dc45dbd9d9504bfa7400a

commit 3a5d7f965cc6130fde6dc45dbd9d9504bfa7400a
Author: dpranke <dpranke@chromium.org>
Date: Fri Jul 22 03:48:16 2016

Flip last CrOS builders to GN.

Flip the remaining CrOS builders to GN:

- chromium.lkgr:
  - ChromiumOS ASAN Release
- chromium.memory:
  - Linux Chromium OS ASan LSan Builder
- chromium.memory.fyi:
  - Chromium Linux ChromeOS MSan Builder
- tryserver.chromium.linux:
  - linux_chromium_chromeos_asan_rel_ng

R=stevenjb@chromium.org
BUG= 605732 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_chromeos_asan_rel_ng

Review-Url: https://codereview.chromium.org/2170703002
Cr-Commit-Position: refs/heads/master@{#407045}

[modify] https://crrev.com/3a5d7f965cc6130fde6dc45dbd9d9504bfa7400a/tools/mb/mb_config.pyl

Project Member

Comment 63 by bugdroid1@chromium.org, Jul 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd97a422094294155a2d0333daca5cafa4ada1a8

commit bd97a422094294155a2d0333daca5cafa4ada1a8
Author: dpranke <dpranke@chromium.org>
Date: Sat Jul 23 03:34:10 2016

Fix typo in fuzzer build file for CrOS.

This was broken in r407045.

TBR=mbarbella@chromium.org
BUG= 605732 

Review-Url: https://codereview.chromium.org/2180473003
Cr-Commit-Position: refs/heads/master@{#407336}

[modify] https://crrev.com/bd97a422094294155a2d0333daca5cafa4ada1a8/tools/ipc_fuzzer/fuzzer/BUILD.gn

Status: Fixed (was: Started)
All Linux builders are now on GN.
Woohoooo! :)

Sign in to add a comment