New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 605724 link

Starred by 1 user
Status: Fixed
Owner:
█ mmccoy@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: Changing to a non-art device breaks

Project Member Reported by paulir...@chromium.org, Apr 21 2016 
TypeError: Cannot read property 'top' of undefined TypeError: Cannot read property 'top' of undefined


1. look at nexus 5x, then change to 6p
2. then change to Galaxy 5S

Breaks. Exception follow.

inspector.js:1503 TypeError: Cannot read property 'top' of undefined TypeError: Cannot read property 'top' of undefined
    at Object._applyDeviceMetrics (inspector.js:10704)
    at Object._calculateAndEmulate (inspector.js:10696)
    at Object._scaleSettingChanged (inspector.js:10685)
    at Object.dispatchEventToListeners (inspector.js:768)
    at Object.set (inspector.js:1157)
    at Object.emulate (inspector.js:10654)
    at Object._emulateDevice (inspector.js:10743)
    at Object._itemSelected (inspector.js:2159)
    at Object._onItemSelected (inspector.js:2157)
    at Object.dispatchEventToListeners (inspector.js:768)
Screen Shot 2016-04-21 at 2.11.06 PM.png
238 KB View Download

Comment 1 by mmccoy@chromium.org, Apr 27 2016 

https://codereview.chromium.org/1929603002 out for review.

Comment 2 by mmccoy@chromium.org, Apr 27 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8da946c11d2f47b862fbf0b3c146ea2517966bc2

commit 8da946c11d2f47b862fbf0b3c146ea2517966bc2
Author: mmccoy <mmccoy@chromium.org>
Date: Thu Apr 28 14:45:48 2016

[DevTools] If no device frame art is available, ensure neutral inset values are defined when applying metrics.

BUG= 605724 

Review-Url: https://codereview.chromium.org/1929603002
Cr-Commit-Position: refs/heads/master@{#390374}

[modify] https://crrev.com/8da946c11d2f47b862fbf0b3c146ea2517966bc2/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js

Comment 4 by mmccoy@chromium.org, Apr 28 2016

Status: Fixed (was: Started)
►

Sign in to add a comment