New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 605717 link

Starred by 1 user
Status: Fixed
Owner:
zmo@chromium.org
Closed: May 2016
Cc:
█ kbr@chromium.org
cwallez@chromium.org
bajones@chromium.org
piman@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove LOG from context_group.cc

Project Member Reported by zmo@chromium.org, Apr 21 2016 
Per discussion in https://codereview.chromium.org/1905743002/, we should not do a bunch of LOG in context_group.cc. This increases the binary size tremendously.

To provide a way to diagnose context creation failures, one option could be we add all such driver limits to about:gpu page.
Project Member

Comment 1 by bugdroid1@chromium.org, May 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bdab5dd2271c2722e9fd84964752b2b88c8c6e1

commit 9bdab5dd2271c2722e9fd84964752b2b88c8c6e1
Author: zmo <zmo@chromium.org>
Date: Thu May 05 04:35:27 2016

Fix a bug in texture validation.

We didn't consider MAX_ARRAY_TEXTURE_LAYERS.

Also, change LOG to DLOG in context group creation time.

BUG= 429053 , 605717 
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/1950233002
Cr-Commit-Position: refs/heads/master@{#391754}

[modify] https://crrev.com/9bdab5dd2271c2722e9fd84964752b2b88c8c6e1/gpu/command_buffer/service/context_group.cc
[modify] https://crrev.com/9bdab5dd2271c2722e9fd84964752b2b88c8c6e1/gpu/command_buffer/service/framebuffer_manager_unittest.cc
[modify] https://crrev.com/9bdab5dd2271c2722e9fd84964752b2b88c8c6e1/gpu/command_buffer/service/test_helper.cc
[modify] https://crrev.com/9bdab5dd2271c2722e9fd84964752b2b88c8c6e1/gpu/command_buffer/service/test_helper.h
[modify] https://crrev.com/9bdab5dd2271c2722e9fd84964752b2b88c8c6e1/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/9bdab5dd2271c2722e9fd84964752b2b88c8c6e1/gpu/command_buffer/service/texture_manager.h
[modify] https://crrev.com/9bdab5dd2271c2722e9fd84964752b2b88c8c6e1/gpu/command_buffer/service/texture_manager_unittest.cc

Comment 2 by zmo@chromium.org, May 5 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment