FileAPI: Eliminate (or sandardize?) nonstandard 'endings' option |
|||||||||||
Issue description
Chrome supports the nonstandard 'endings' option.
new Blob([data], {endings: 'native'});
new File([data], 'filename', {endings: 'native'});
... which translates '\n' in the data to '\r\n' on Windows.
HTTPArchive shows no use of this (searching for content containing "endings:" and "native") but we should implement a use counter, gather stats, and eliminate if possible.
,
Apr 21 2016
,
Apr 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec90317104f275c3e818f1a6e4d800ce5c8d6990 commit ec90317104f275c3e818f1a6e4d800ce5c8d6990 Author: jsbell <jsbell@chromium.org> Date: Fri Apr 22 08:32:00 2016 File API: Add a use counter for nonstandard 'endings' option Chrome supports the nonstandard 'endings' option for the Blob and File constructors, which normalizes CR in the data to CR+LF on Windows. It'd be nice to eliminate this if we can, so let's measure the usage. BUG= 605710 Review URL: https://codereview.chromium.org/1906153002 Cr-Commit-Position: refs/heads/master@{#389055} [modify] https://crrev.com/ec90317104f275c3e818f1a6e4d800ce5c8d6990/third_party/WebKit/Source/core/fileapi/Blob.cpp [modify] https://crrev.com/ec90317104f275c3e818f1a6e4d800ce5c8d6990/third_party/WebKit/Source/core/fileapi/Blob.h [modify] https://crrev.com/ec90317104f275c3e818f1a6e4d800ce5c8d6990/third_party/WebKit/Source/core/fileapi/Blob.idl [modify] https://crrev.com/ec90317104f275c3e818f1a6e4d800ce5c8d6990/third_party/WebKit/Source/core/fileapi/File.cpp [modify] https://crrev.com/ec90317104f275c3e818f1a6e4d800ce5c8d6990/third_party/WebKit/Source/core/fileapi/File.h [modify] https://crrev.com/ec90317104f275c3e818f1a6e4d800ce5c8d6990/third_party/WebKit/Source/core/fileapi/File.idl [modify] https://crrev.com/ec90317104f275c3e818f1a6e4d800ce5c8d6990/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/ec90317104f275c3e818f1a6e4d800ce5c8d6990/tools/metrics/histograms/histograms.xml
,
Jul 12 2016
In beta, use counter shows 0.0000000002% - we should let the counter hit stable but I think it's going to be safe to remove.
,
Jul 12 2016
CL to remove: https://codereview.chromium.org/2147633002 (Will wait for the counter to hit stable, though)
,
Jul 13 2016
Sure looks promising. Will you Intend to Remove this?
,
Jul 13 2016
Yeah, probably merits an Intent and chromestatus entry just to keep us transparent.
,
Oct 10 2016
FYI, as I was writing up the intent I realized that all the other browsers ended up supporting this option as well. Even though usage is extremely low and behavior is inconsistent it made me pause. I raised https://github.com/w3c/FileAPI/issues/46 to track this.
,
Feb 10 2017
,
Feb 15 2017
,
Feb 15 2017
,
Feb 16 2017
,
Mar 14 2017
Issue 701474 has been merged into this issue.
,
Dec 1 2017
,
Dec 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfca05b3ba1b81fab53601ee886b3e29d246f1bf commit bfca05b3ba1b81fab53601ee886b3e29d246f1bf Author: Joshua Bell <jsbell@chromium.org> Date: Tue Dec 05 00:01:36 2017 FileAPI: Blob 'endings' option is now standardized. The 'endings' option for the Blob (and File) constructor has now been standardized in the spec[1]. Remove TODOs and align the IDL with the spec. No behavior changes. [1] https://w3c.github.io/FileAPI Bug: 605710 , 509793 Change-Id: I26a1694eb56e415b6a50cc90148d10393b88b8d2 Reviewed-on: https://chromium-review.googlesource.com/802621 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#521537} [modify] https://crrev.com/bfca05b3ba1b81fab53601ee886b3e29d246f1bf/third_party/WebKit/LayoutTests/external/wpt/FileAPI/blob/Blob-constructor-expected.txt [modify] https://crrev.com/bfca05b3ba1b81fab53601ee886b3e29d246f1bf/third_party/WebKit/LayoutTests/external/wpt/FileAPI/blob/Blob-constructor.html [modify] https://crrev.com/bfca05b3ba1b81fab53601ee886b3e29d246f1bf/third_party/WebKit/LayoutTests/external/wpt/FileAPI/file/File-constructor-expected.txt [modify] https://crrev.com/bfca05b3ba1b81fab53601ee886b3e29d246f1bf/third_party/WebKit/LayoutTests/external/wpt/FileAPI/file/File-constructor.html [modify] https://crrev.com/bfca05b3ba1b81fab53601ee886b3e29d246f1bf/third_party/WebKit/LayoutTests/fast/files/blob-constructor-expected.txt [modify] https://crrev.com/bfca05b3ba1b81fab53601ee886b3e29d246f1bf/third_party/WebKit/LayoutTests/fast/files/blob-constructor.html [modify] https://crrev.com/bfca05b3ba1b81fab53601ee886b3e29d246f1bf/third_party/WebKit/LayoutTests/fast/files/file-constructor-expected.txt [modify] https://crrev.com/bfca05b3ba1b81fab53601ee886b3e29d246f1bf/third_party/WebKit/LayoutTests/fast/files/file-constructor.html [modify] https://crrev.com/bfca05b3ba1b81fab53601ee886b3e29d246f1bf/third_party/WebKit/Source/core/fileapi/BlobPropertyBag.idl
,
Dec 5 2017
,
Jun 15 2018
,
Jun 15 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by jsb...@chromium.org
, Apr 21 2016Components: Blink>FileAPI
Owner: jsb...@chromium.org