New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 605706 link

Starred by 1 user
Status: Fixed
Owner:
mustaq@chromium.org
Closed: May 2016
Cc:
nzolghadr@chromium.org
dtapu...@chromium.org
█ kozyatinskiy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 471824



Sign in to add a comment

Devtools: event listener breakpoints are not working for PointerEvents

Project Member Reported by mustaq@chromium.org, Apr 21 2016 
Looks like a regression, both ToT & beta is affected. Works fine in 50.0.2661.79 on Pixel.

0. Run Chrome with --enable-blink-features=PointerEvent
   (alternatively for ToT, enable PointerEvents through about://flags).
1. Goto: https://output.jsbin.com/dunuve
2. Add event listerner breakpoint for all PointerEvents through devtools.
3. Move mouse over any of the divs.

Expected: devtool should stop the pointermove eventHandler execution.

Actual: devtool doesn't stop even though the script in the page shows the handler's output.

Affects Windows, Linux & CrOS.

Comment 1 by mustaq@chromium.org, Apr 22 2016 

Ran bisect as far back as 50.0.2661.79, breakpoints are not working in any "version"!

Not sure exactly why only PEs are affected. E.g. after running
  $0.addEventListener("mousemove", ...);
  $0.addEventListener("pointermove", ...);
only the mouse breakpoints work although moniterEvents() & getEventListeners() work for both mousemoves and pointermoves.

Comment 2 by mustaq@chromium.org, Apr 22 2016

Cc: yu...@chromium.org
Owner: mustaq@chromium.org
Status: Assigned (was: Untriaged)
Also manually setting a breakpoint works, even for pointer events.

Yury, any clue if pointer events are being filtered out somewhere, possibly around InspectorDOMDebuggerAgent::setEventListenerBreakpoint?

Comment 3 by yu...@chromium.org, Apr 22 2016

Cc: -yu...@chromium.org kozyatinskiy@chromium.org
Alexey, can you please answer the question in #2?

Comment 4 by mustaq@chromium.org, Apr 22 2016 

I guess EventListenerBreakpointsSidebarPane.js::_updateBreakpointOnTarget() is treating PointerEvents differently because InspectorDOMDebuggerAgent::setEventListenerBreakpoint is not even called for PEs.

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js&l=232

Comment 5 by dtapu...@chromium.org, Apr 22 2016 

Ya I think you are correct mustaq@; the eventName for the pointerover is 

instrumentation:pointerover

not listener:pointerover

which causes the code not to execute the setEventListenerBreakpoint

Comment 7 by kozyatinskiy@chromium.org, Apr 22 2016 

It was my bad while review. _createCategory should be called with false or omitted argument for pointer events like for mouse events.

Comment 8 by mustaq@chromium.org, Apr 29 2016

Blocking: 471824
Project Member

Comment 9 by bugdroid1@chromium.org, May 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ce75f46df1069cd68a30be5a1298f21c7774f60

commit 2ce75f46df1069cd68a30be5a1298f21c7774f60
Author: mustaq <mustaq@chromium.org>
Date: Mon May 02 17:53:34 2016

Fixed DevTools event-listener breakpoints for PointerEvents.

Also added a test with PointerEvent specific expectation, in
the "pointerevent" virtual suite.

BUG= 605706 

Review-Url: https://codereview.chromium.org/1915623002
Cr-Commit-Position: refs/heads/master@{#390988}

[modify] https://crrev.com/2ce75f46df1069cd68a30be5a1298f21c7774f60/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2ce75f46df1069cd68a30be5a1298f21c7774f60/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/2ce75f46df1069cd68a30be5a1298f21c7774f60/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints-expected.txt
[modify] https://crrev.com/2ce75f46df1069cd68a30be5a1298f21c7774f60/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints.html
[add] https://crrev.com/2ce75f46df1069cd68a30be5a1298f21c7774f60/third_party/WebKit/LayoutTests/virtual/pointerevent/inspector/sources/debugger-breakpoints/README.txt
[add] https://crrev.com/2ce75f46df1069cd68a30be5a1298f21c7774f60/third_party/WebKit/LayoutTests/virtual/pointerevent/inspector/sources/debugger-breakpoints/event-listener-breakpoints-expected.txt
[modify] https://crrev.com/2ce75f46df1069cd68a30be5a1298f21c7774f60/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js

Comment 10 by mustaq@chromium.org, May 2 2016

Status: Fixed (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, May 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e50c5889bb9034888da15721abc76b211353d7d

commit 9e50c5889bb9034888da15721abc76b211353d7d
Author: dpranke <dpranke@chromium.org>
Date: Tue May 03 00:12:11 2016

Revert of Fixed DevTools event-listener breakpoints for PointerEvents. (patchset #3 id:40001 of https://codereview.chromium.org/1915623002/ )

Reason for revert:
Reverting this, one of the tests is timing out in debug builds:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/1480/steps/webkit_tests/logs/stdio

Original issue's description:
> Fixed DevTools event-listener breakpoints for PointerEvents.
>
> Also added a test with PointerEvent specific expectation, in
> the "pointerevent" virtual suite.
>
> BUG= 605706 
>
> Committed: https://crrev.com/2ce75f46df1069cd68a30be5a1298f21c7774f60
> Cr-Commit-Position: refs/heads/master@{#390988}

TBR=kozyatinskiy@chromium.org,lushnikov@chromium.org,mustaq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 605706 

Review-Url: https://codereview.chromium.org/1935373002
Cr-Commit-Position: refs/heads/master@{#391113}

[modify] https://crrev.com/9e50c5889bb9034888da15721abc76b211353d7d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/9e50c5889bb9034888da15721abc76b211353d7d/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/9e50c5889bb9034888da15721abc76b211353d7d/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints-expected.txt
[modify] https://crrev.com/9e50c5889bb9034888da15721abc76b211353d7d/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints.html
[delete] https://crrev.com/f95a3cba70ce113b2ab55db16df8754715095a7d/third_party/WebKit/LayoutTests/virtual/pointerevent/inspector/sources/debugger-breakpoints/README.txt
[delete] https://crrev.com/f95a3cba70ce113b2ab55db16df8754715095a7d/third_party/WebKit/LayoutTests/virtual/pointerevent/inspector/sources/debugger-breakpoints/event-listener-breakpoints-expected.txt
[modify] https://crrev.com/9e50c5889bb9034888da15721abc76b211353d7d/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js

Comment 12 by mustaq@chromium.org, May 3 2016

Status: Assigned (was: Fixed)
Reopening because of the revert.
Project Member

Comment 13 by bugdroid1@chromium.org, May 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/331cbe0e04f124affaec2c52fe38c6f22c7b6c69

commit 331cbe0e04f124affaec2c52fe38c6f22c7b6c69
Author: mustaq <mustaq@chromium.org>
Date: Thu May 05 15:09:30 2016

Fixed DevTools event-listener breakpoints for PointerEvents.

Also added a test with PointerEvent specific expectation, in
the "pointerevent" virtual suite.

BUG= 605706 

Review-Url: https://codereview.chromium.org/1943403002
Cr-Commit-Position: refs/heads/master@{#391804}

[modify] https://crrev.com/331cbe0e04f124affaec2c52fe38c6f22c7b6c69/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/331cbe0e04f124affaec2c52fe38c6f22c7b6c69/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/331cbe0e04f124affaec2c52fe38c6f22c7b6c69/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints-expected.txt
[modify] https://crrev.com/331cbe0e04f124affaec2c52fe38c6f22c7b6c69/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints.html
[add] https://crrev.com/331cbe0e04f124affaec2c52fe38c6f22c7b6c69/third_party/WebKit/LayoutTests/virtual/pointerevent/inspector/sources/debugger-breakpoints/README.txt
[add] https://crrev.com/331cbe0e04f124affaec2c52fe38c6f22c7b6c69/third_party/WebKit/LayoutTests/virtual/pointerevent/inspector/sources/debugger-breakpoints/event-listener-breakpoints-expected.txt
[modify] https://crrev.com/331cbe0e04f124affaec2c52fe38c6f22c7b6c69/third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js

Comment 14 by mustaq@chromium.org, May 5 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment