New issue
Advanced search Search tips

Issue 605691 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Azure video doesn't play

Project Member Reported by qin...@chromium.org, Apr 21 2016

Issue description

go to http://146.148.91.8/medialinks/medialinks.html, and play the Azure videos at the bottom, video will fail to play on trunk, but works fine in M49

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc609e6aaf5e4f7bf7aef788d05e070ad440e9e7

commit bc609e6aaf5e4f7bf7aef788d05e070ad440e9e7
Author: qinmin <qinmin@chromium.org>
Date: Thu Apr 21 22:35:56 2016

Fix an issue that HLS url for Azure video is not correctly detected

Azure video may have the following url:
http://b028.wpc.azureedge.net/80B028/Samples/a38e6323-95e9-4f1f-9b38-75eba91704e4/5f2ce531-d508-49fb-8152-647eba422aec.ism/Manifest(format=m3u8-aapl-v3)
Use IsHLSURL() instead of IsHLSPath() fixes the issue.
IsHLSURL() could introduce higher false positives.
However, in false positive case the url will be passed to Android MediaPlayer,
which will also play the video for us.

BUG= 605691 

Review URL: https://codereview.chromium.org/1905133003

Cr-Commit-Position: refs/heads/master@{#388930}

[modify] https://crrev.com/bc609e6aaf5e4f7bf7aef788d05e070ad440e9e7/content/renderer/render_frame_impl.cc

Comment 2 by qin...@chromium.org, Apr 21 2016

Labels: Merge-Request-51

Comment 3 by qin...@chromium.org, Apr 21 2016

Status: Started (was: Untriaged)

Comment 4 by tin...@google.com, Apr 22 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 25 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9f99ce9da604abdb416de7828adb64b9ac15b99

commit d9f99ce9da604abdb416de7828adb64b9ac15b99
Author: Min Qin <qinmin@chromium.org>
Date: Mon Apr 25 16:23:29 2016

Fix an issue that HLS url for Azure video is not correctly detected

Azure video may have the following url:
http://b028.wpc.azureedge.net/80B028/Samples/a38e6323-95e9-4f1f-9b38-75eba91704e4/5f2ce531-d508-49fb-8152-647eba422aec.ism/Manifest(format=m3u8-aapl-v3)
Use IsHLSURL() instead of IsHLSPath() fixes the issue.
IsHLSURL() could introduce higher false positives.
However, in false positive case the url will be passed to Android MediaPlayer,
which will also play the video for us.

TBR=sievers@chromium.org
BUG= 605691 

Review URL: https://codereview.chromium.org/1905133003

Cr-Commit-Position: refs/heads/master@{#388930}
(cherry picked from commit bc609e6aaf5e4f7bf7aef788d05e070ad440e9e7)

Review URL: https://codereview.chromium.org/1921743003 .

Cr-Commit-Position: refs/branch-heads/2704@{#214}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/d9f99ce9da604abdb416de7828adb64b9ac15b99/content/renderer/render_frame_impl.cc

Comment 6 by qin...@chromium.org, Apr 25 2016

Status: Fixed (was: Started)

Comment 7 by ram...@chromium.org, Apr 26 2016

Status: Verified (was: Fixed)
Verified with Chrome beta build '51.0.2704.28'
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d95212797289eebff36fec22033fa8859c7904b

commit 0d95212797289eebff36fec22033fa8859c7904b
Author: qinmin <qinmin@chromium.org>
Date: Mon Oct 10 20:43:19 2016

use IsHLSURL() instead of IsHLSPath()

according to UMA, the former is much better in detecting HLS streams

BUG= 605691 

Review-Url: https://codereview.chromium.org/2403973002
Cr-Commit-Position: refs/heads/master@{#424231}

[modify] https://crrev.com/0d95212797289eebff36fec22033fa8859c7904b/media/blink/webmediaplayer_impl.cc

Sign in to add a comment