New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 605688 link

Starred by 4 users
Status: Fixed
Owner:
█ andrewhayden@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
droger@chromium.org
█ picksi@chromium.org
█ dsites@google.com
hajimehoshi@chromium.org
rmcilroy@chromium.org
toyoshim@chromium.org
█ riesa@chromium.org
█ andrewhayden@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Delete CLD1 now that all platforms use CLD2

Project Member Reported by andrewhayden@chromium.org, Apr 21 2016 
After  issue 528257  was completed, there are no remaining platforms on CLD1. CLD1 has now been completely turned off for more than 6 months, replaced on all platforms by CLD2. It's time to kill CLD1 from the tree.

A PSA was made here in September 2015:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/HnEGkOOUJhg/discussion

We should be able to:
1. Delete all CLD1 variables from GYP/GN
2. Delete all IFDEF'd code that depends on cld_version
3. Drop the third_party/cld directory from the DEPS file and repo
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edab266c2b432d1200dc1de23fc5424dcd8d3b23

commit edab266c2b432d1200dc1de23fc5424dcd8d3b23
Author: andrewhayden <andrewhayden@chromium.org>
Date: Mon Apr 25 19:49:20 2016

Drop support for Compact Language Detector v1.

Compact Language Detector (CLD) v2 has been the only version used by Chromium
for several months. A PSA announcing deprecation was sent in September 2015, see
the bug for more details.

This change should be a no-op for all platforms, since all platforms are already
migrated to CLD v2.

BUG= 605688 

Review URL: https://codereview.chromium.org/1920853002

Cr-Commit-Position: refs/heads/master@{#389544}

[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/build/common.gypi
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/build/config/BUILD.gn
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/build/config/features.gni
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/chrome/BUILD.gn
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/chrome/android/chrome_apk.gyp
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/chrome/browser/resources/chromeos/chromevox/BUILD.gn
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/chrome/chrome.gyp
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/chrome/chrome_dll.gypi
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/chrome/chrome_tests.gypi
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/chrome/test/BUILD.gn
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/components/components_tests.gyp
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/components/translate.gypi
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/components/translate/content/renderer/BUILD.gn
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/components/translate/core/language_detection/BUILD.gn
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/components/translate/core/language_detection/language_detection_util.cc
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/extensions/BUILD.gn
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/extensions/extensions.gyp
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/extensions/shell/BUILD.gn
[modify] https://crrev.com/edab266c2b432d1200dc1de23fc5424dcd8d3b23/extensions/shell/app_shell.gyp
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 25 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/b5d45771429ab5adfe3193a9479ec2f4e2e87a13

commit b5d45771429ab5adfe3193a9479ec2f4e2e87a13
Author: Andrew Hayden <andrewhayden@google.com>
Date: Mon Apr 25 12:46:57 2016

Comment 4 by andrewhayden@chromium.org, Apr 25 2016

Cc: picksi@chromium.org andrewhayden@chromium.org rmcilroy@chromium.org
 Issue 528305  has been merged into this issue.

Comment 5 by andrewhayden@chromium.org, Apr 26 2016

Blockedon: 606795

Comment 6 by andrewhayden@chromium.org, Apr 26 2016 

Here's the final CL:
https://codereview.chromium.org/1917903004

But the bots are having some trouble with the license scanner still trying to find the license. Filed  issue 606795  for the troopers to figure out what's up with the license check still seeing the directory but not the license.
Project Member

Comment 7 by bugdroid1@chromium.org, May 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/865388d35da3f286d7caa9de61f0b297a382ddb3

commit 865388d35da3f286d7caa9de61f0b297a382ddb3
Author: andrewhayden <andrewhayden@chromium.org>
Date: Wed May 18 14:36:35 2016

Delete last remaining CLD deps.

This is being split from the following review in order to get through
the bots safely without breaking the tree:
https://codereview.chromium.org/1917903004/

We will delete the DEPS to ensure no build-time dependencies at all on
CLD, then break/delete the problematic
compact_lang_det_generated_quadschrome.cc file that is causing bots to
have issues with the larger patchset.

TBR as this is already reviewed at the link above.

BUG= 605688 

Review-Url: https://codereview.chromium.org/1972543003
Cr-Commit-Position: refs/heads/master@{#394417}

[modify] https://crrev.com/865388d35da3f286d7caa9de61f0b297a382ddb3/components/translate/core/language_detection/DEPS
[modify] https://crrev.com/865388d35da3f286d7caa9de61f0b297a382ddb3/tools/include_tracer.py

Comment 8 by andrewhayden@chromium.org, May 19 2016

Blockedon: -606795
Status: Started (was: Assigned)
Final review will be in gerrit because of  issue 606795 .

https://chromium-review.googlesource.com/#/c/345841
Project Member

Comment 9 by bugdroid1@chromium.org, May 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0c0cab516d52d7e58397b7c2d61839b1be69d5b

commit c0c0cab516d52d7e58397b7c2d61839b1be69d5b
Author: Andrew Hayden <andrewhayden@chromium.org>
Date: Tue May 24 09:52:32 2016

Remove Compact Language Detector v1.

See the bug for details. A deprecation notice was sent in September
2015, and there are no remaining uses of CLD1 in any code or build
files.

This change is being landed directly, without the commit queue,
because of  crbug.com/606795 . Sheriffs, reverts should be landed
manually as well. No problems are anticipated as all references
to third_party/cld have been deleted from code and build files.

BUG= 605688 

Cr-Commit-Position: refs/heads/master@{#395559}

[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/BUILD.gn
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/DEPS
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/LICENSE
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/OWNERS
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/README.chromium
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/DEPS
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/basictypes.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/build_config.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/casts.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/commandlineflags.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/crash.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/dynamic_annotations.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/global_strip_options.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/log_severity.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/logging.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/macros.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/port.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/stl_decl.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/stl_decl_msvc.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/string_util.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/strtoint.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/template_util.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/type_traits.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/base/vlog_is_on.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/cld.gyp
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/cldutil.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/cldutil.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/cldutil_dbg.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/cldutil_dbg_empty.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/compact_lang_det.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/compact_lang_det.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/compact_lang_det_impl.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/compact_lang_det_impl.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/compact_lang_det_unittest_small.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/ext_lang_enc.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/ext_lang_enc.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/generated/cld_generated_score_deltaoctachrome_0406.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/generated/cld_generated_score_quadchrome_0406.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/generated/compact_lang_det_generated_cjkbis_0.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/generated/compact_lang_det_generated_ctjkvz.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/generated/compact_lang_det_generated_ctjkvz_0.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/generated/compact_lang_det_generated_deltaoctachrome.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/generated/compact_lang_det_generated_longwords8_0.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/generated/compact_lang_det_generated_meanscore.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/generated/compact_lang_det_generated_quads_0.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/generated/compact_lang_det_generated_quadschrome.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/getonescriptspan.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/getonescriptspan.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/letterscript_enum.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/letterscript_enum.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/string_byte_sink.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/string_byte_sink.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/subsetsequence.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/subsetsequence.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/tote.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/tote.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/unittest_data.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/utf8propjustletter.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/utf8propletterscriptnum.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/utf8scannotjustletterspecial.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_basictypes.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_commandlineflags.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_google.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_htmlutils.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_htmlutils_google3.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_htmlutils_windows.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_logging.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_macros.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_strtoint.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_unicodetext.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_unicodetext.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_unilib.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_unilib_google3.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_unilib_windows.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_utf.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_utf8statetable.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_utf8statetable.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_utf8utils.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/cld_utf8utils_windows.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/normalizedunicodetext.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/compact_lang_det/win/normalizedunicodetext.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/internal/encodings.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/lang_enc.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/proto/encodings.pb.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/encodings/public/encodings.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/languages/internal/languages.cc
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/languages/proto/languages.pb.h
[delete] https://crrev.com/9289b46d142c34fb1507906048189503e2e6a306/third_party/cld/languages/public/languages.h

Comment 10 by andrewhayden@chromium.org, May 24 2016

Status: Fixed (was: Started)
Landed manually as:
https://chromium.googlesource.com/chromium/src/+/c0c0cab516d52d7e58397b7c2d61839b1be69d5b

Thanks to the sheriffs and infra troopers for the help. This is now done.

Comment 11 by lafo...@chromium.org, Apr 27 2017

Components: -UI>Browser>Translate UI>Browser>Language>Translate
►

Sign in to add a comment