New issue
Advanced search Search tips

Issue 605684 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 14
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Consider renaming LongConstraint and friends to WebLongConstraint etc

Project Member Reported by hta@chromium.org, Apr 21 2016

Issue description

The Blink naming guide states that all platform-exposed classes and types should start with Web*

https://www.chromium.org/blink/public-c-api#TOC-Naming

The types BooleanConstraint, LongConstraint, StringConstraint and DoubleConstraint don't; consider renaming them.

//src/third_party/WebKit/public/platform/WebMediaConstraints.h
 

Comment 1 by hta@chromium.org, Apr 5 2017

Owner: guidou@chromium.org

Comment 2 by guidou@chromium.org, Nov 29 2017

Status: Assigned (was: Untriaged)
Cc: guidou@chromium.org
Owner: ar...@chromium.org
The guide now says that the Web prefix is "mostly for historical reasons".

I would prefer long term to move all code that uses LongConstraint and friends into Blink and delete the Platform-exposed APIs (as part of OnionSoup), but I don't see a good reason to devote time to that rename at this time.

Status: WontFix (was: Assigned)
Closing as per #4. Moving everything to Blink is the long-term plan.

Sign in to add a comment