MacViews: credit card prompt needs updated |
|||||||
Issue descriptionThis dialog is actually tricky to summon: 1) Sign into a Google account in Chromium 2) Add a credit card to the account 3) Go to a page with a CC form 4) Click to autofill card in that form I haven't managed to summon it yet.
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c14582ff083f4c907573efd58e0246083cdd0581 commit c14582ff083f4c907573efd58e0246083cdd0581 Author: ellyjones <ellyjones@chromium.org> Date: Wed May 25 16:15:19 2016 MacViews: support Views credit card unmask prompt Much of the Views autofill code is Mac-ready. This CL also adds two shims, one for Cocoa browsers and one for Views browsers. BUG= 605677 Review-Url: https://codereview.chromium.org/2000863002 Cr-Commit-Position: refs/heads/master@{#395901} [modify] https://crrev.com/c14582ff083f4c907573efd58e0246083cdd0581/chrome/browser/ui/autofill/create_card_unmask_prompt_view.h [modify] https://crrev.com/c14582ff083f4c907573efd58e0246083cdd0581/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm [add] https://crrev.com/c14582ff083f4c907573efd58e0246083cdd0581/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_views.mm [modify] https://crrev.com/c14582ff083f4c907573efd58e0246083cdd0581/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc [add] https://crrev.com/c14582ff083f4c907573efd58e0246083cdd0581/chrome/browser/ui/views/autofill/card_unmask_prompt_views_shim.cc [modify] https://crrev.com/c14582ff083f4c907573efd58e0246083cdd0581/chrome/chrome_browser_ui.gypi
,
Aug 14 2016
The UI strings are totally different (I guess the .xib didn't get retranslated?). But here are before and after screenshots for reference.
,
Sep 23 2016
Review notes: https://groups.google.com/a/google.com/forum/#!topic/chrome-harmony/xqTrAqnJ-JE
,
Oct 7 2016
,
Oct 21 2016
To invoke, build browser_tests and launch: /browser_tests --gtest_filter= "CardUnmaskPromptViewBrowserTest.DISABLED_Invoke*" --gtest_also_run_disabled_tests --ui-test-action-max-timeout=10000000 --test-launcher-timeout=10000000 --secondary-ui-md There are two tests: one with an expired and one with a valid credit card.
,
Dec 12 2016
,
Sep 5 2017
,
Sep 5 2017
,
Nov 10 2017
The NextAction date has arrived: 2017-11-10
,
Jan 10 2018
It looks like the MacViews-specific work is done, and Harmony style is covered under bug 792278. So I'm closing this. |
|||||||
►
Sign in to add a comment |
|||||||
/Secondary%20UI%20Previews%20and%20specs%20(exports)/Spec/Phase%202#%2FSPEC-Phase%202-CVC.png%3Fz=width){kind=link}
Comment 1 by ellyjo...@chromium.org
, May 17 2016Owner: ellyjo...@chromium.org
Status: Assigned (was: Available)