New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605670 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Modify line boundary calculation to take into account embedded objects

Project Member Reported by nek...@chromium.org, Apr 21 2016

Issue description

IAccessible2 uses an embedded object character to represent composite elements, such as links and images, that are present within rich text. Chrome's logic for calculating line boundaries does not take these characters into account, returning incorrect line boundaries in many occasions.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78d5c7d32a7bd67f292397ddf7e79e079ff6f1d7

commit 78d5c7d32a7bd67f292397ddf7e79e079ff6f1d7
Author: nektar <nektar@chromium.org>
Date: Wed Apr 27 08:13:45 2016

Correctly finds line boundaries in objects with rich text on Windows.

The issue is that we were not taking into account embedded object characters.
Took the opportunity to update the code to use the new |nextOnLine| and |previousOnLine| Blink APIs.
BUG= 605670 
R=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/1905263002

Cr-Commit-Position: refs/heads/master@{#390017}

[modify] https://crrev.com/78d5c7d32a7bd67f292397ddf7e79e079ff6f1d7/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/78d5c7d32a7bd67f292397ddf7e79e079ff6f1d7/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/78d5c7d32a7bd67f292397ddf7e79e079ff6f1d7/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/78d5c7d32a7bd67f292397ddf7e79e079ff6f1d7/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://crrev.com/78d5c7d32a7bd67f292397ddf7e79e079ff6f1d7/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/78d5c7d32a7bd67f292397ddf7e79e079ff6f1d7/content/renderer/accessibility/blink_ax_tree_source.cc
[modify] https://crrev.com/78d5c7d32a7bd67f292397ddf7e79e079ff6f1d7/third_party/WebKit/LayoutTests/accessibility/inline-text-box-next-on-line.html
[modify] https://crrev.com/78d5c7d32a7bd67f292397ddf7e79e079ff6f1d7/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h
[modify] https://crrev.com/78d5c7d32a7bd67f292397ddf7e79e079ff6f1d7/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/78d5c7d32a7bd67f292397ddf7e79e079ff6f1d7/ui/accessibility/ax_node_data.cc
[modify] https://crrev.com/78d5c7d32a7bd67f292397ddf7e79e079ff6f1d7/ui/accessibility/ax_tree_combiner.cc

Project Member

Comment 3 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74bdbcb2a0b6cd2810e8b666cd5fefbd600039fd

commit 74bdbcb2a0b6cd2810e8b666cd5fefbd600039fd
Author: nektar <nektar@chromium.org>
Date: Mon May 09 21:12:24 2016

The bug fixed involves not recursing into inline text boxes in the case that a static text object covered more than one line.

Also fixed a bug on Windows that didn't return the correct line boundaries if the start offset was equal to the text's length, something that is allowed by the IA2 Spec.
BUG= 605670 
R=dmazzoni@chromium.org
TESTED=manual testing with Gmail > Compose and Docs, browser tests

Review-Url: https://codereview.chromium.org/1951353002
Cr-Commit-Position: refs/heads/master@{#392424}

[modify] https://crrev.com/74bdbcb2a0b6cd2810e8b666cd5fefbd600039fd/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/74bdbcb2a0b6cd2810e8b666cd5fefbd600039fd/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/74bdbcb2a0b6cd2810e8b666cd5fefbd600039fd/content/browser/accessibility/browser_accessibility_win.cc

Comment 4 by nek...@chromium.org, Nov 14 2016

Status: Fixed (was: Started)

Sign in to add a comment