Updating notifications on linux causes glitches
Reported by
dyaros...@yandex-team.ru,
Apr 21 2016
|
|||
Issue descriptionChrome Version (from the about:version page): Is this the most recent version: master 04.21.2016 OS + version: Ubuntu 15.4 CPU architecture (32-bit / 64-bit): 64-bit What steps will reproduce the problem? (1) Sent notification (from extension) with a big text (2) Update notification with smaller text What is the expected result? Notification shrinks with smaller size What happens instead? Quite unpleasant visual glitches (screenshots from debug build attached) Please provide any additional information below. Attach a screenshot and backtrace if possible. Attaching screenshots from debug build. In release build, blue rectangle is simply not updated, meaning, that half of previous message is still displayed. This happens, because ToastContentsView::preferred_size_ is updated, while the underlying widget isn't.
,
Apr 22 2016
,
Apr 23 2016
,
May 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f78eb16262f1442e4c2b0cc9a03689e5cc47353 commit 2f78eb16262f1442e4c2b0cc9a03689e5cc47353 Author: dyaroshev <dyaroshev@yandex-team.ru> Date: Wed May 11 13:03:23 2016 Supporting shrinking/enlarging for notifications Extensions have api to update text of a displayed notification. Due to such update, notification recalculates it's size. However, there was a bug in toast_contents_view, that updating preferred_size_ didn't trigger update of corresponding widget. Not updating widget lead to a visual glitch. BUG= 605656 R=dewittj@chromium.com Review-Url: https://codereview.chromium.org/1913433004 Cr-Commit-Position: refs/heads/master@{#392906} [modify] https://crrev.com/2f78eb16262f1442e4c2b0cc9a03689e5cc47353/ui/message_center/views/message_popup_collection_unittest.cc [modify] https://crrev.com/2f78eb16262f1442e4c2b0cc9a03689e5cc47353/ui/message_center/views/toast_contents_view.cc [modify] https://crrev.com/2f78eb16262f1442e4c2b0cc9a03689e5cc47353/ui/message_center/views/toast_contents_view.h
,
May 23 2016
Thanks dyaroshev. It sounds like this is fixed by your patch? If so, it'll roll out in Chrome 52. |
|||
►
Sign in to add a comment |
|||
Comment 1 by dyaros...@yandex-team.ru
, Apr 21 2016