MacViews: Extension install dialog has some confusion with buttons |
||
Issue descriptionWhat steps will reproduce the problem? (1) Got to https://carlosjeurissen.com/black-menu-for-google (2) Click the red Install button The panel that appears (see screenshot) in the Shiny Modern style has Cancel as the Default button, and is positioned leftmost in the dialog (should be rightmost). On the Mac, it's 99% of the time never the case that Cancel is the Default action in a panel. On the Mac, Cancel also has the Escape key as its keyboard shortcut, so if the intent behind making Cancel the Default action was to make it easy to invoke that button's action from the keyboard, it's already taken care of. The fix should be to make "Add extension" be the default action (is there a camelcase version of this string? Extension should be capitalized on the Mac), and make sure Escape is hooked up to the Cancel button.
,
Apr 21 2016
ellyjones@ points out that Cancel in the current dialog is probably the Default button to prevent users from powering through the dialog and installing the extension without realizing. That makes sense - the Cancel button should swap places with the Add extension button, and it's title should be changed to be more informative ("Don't Add" or "Don't Add Extension" would be great but "No Thanks" is OK).
,
Jul 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9139823c60ba620c8d344e9ef70ea5f2eea680e0 commit 9139823c60ba620c8d344e9ef70ea5f2eea680e0 Author: ellyjones <ellyjones@chromium.org> Date: Tue Jul 19 15:15:28 2016 DialogDelegate: allow platforms to prevent Cancel being default On Mac, DIALOG_BUTTON_CANCEL should never have default button styling, so DialogDelegate::UpdateButton() should avoid setting cancel buttons as default. BUG= 605652 Review-Url: https://codereview.chromium.org/2151933002 Cr-Commit-Position: refs/heads/master@{#406276} [modify] https://crrev.com/9139823c60ba620c8d344e9ef70ea5f2eea680e0/ui/views/style/platform_style.cc [modify] https://crrev.com/9139823c60ba620c8d344e9ef70ea5f2eea680e0/ui/views/style/platform_style.h [modify] https://crrev.com/9139823c60ba620c8d344e9ef70ea5f2eea680e0/ui/views/style/platform_style_mac.mm [modify] https://crrev.com/9139823c60ba620c8d344e9ef70ea5f2eea680e0/ui/views/window/dialog_client_view_unittest.cc [modify] https://crrev.com/9139823c60ba620c8d344e9ef70ea5f2eea680e0/ui/views/window/dialog_delegate.cc
,
Jul 19 2016
Fixed! The buttons are now far less confused.
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eaff8e380fa4ef7ad90a5929eb35ce81df786f70 commit eaff8e380fa4ef7ad90a5929eb35ce81df786f70 Author: karandeepb <karandeepb@chromium.org> Date: Thu Jan 05 10:03:31 2017 MacViews: Ensure cancel buttons don't get default button styling. r406276 introduced kDialogDefaultButtonCanBeCancel to ensure buttons with the type DIALOG_BUTTON_CANCEL do not have default button styling on Mac. Subsequently, r420488 made all default dialog buttons blue on Harfmony. This CL changes DialogClientView::CreateDialogButton to take kDialogDefaultButtonCanBeCancel into consideration before applying the default button styling on Harmony. This ensures Cancel buttons under Harmony on MacViews do not get the default button styling. BUG= 678165 , 605652 TEST= On Mac, enable chrome://flags//secondary-ui-md. Open Collected Cookies dialog. Ensure close button does not have default button styling. Review-Url: https://codereview.chromium.org/2615563003 Cr-Commit-Position: refs/heads/master@{#441615} [modify] https://crrev.com/eaff8e380fa4ef7ad90a5929eb35ce81df786f70/ui/views/window/dialog_client_view.cc |
||
►
Sign in to add a comment |
||
Comment 1 by ellyjo...@chromium.org
, Apr 21 2016