New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 605648 link

Starred by 1 user
Status: Fixed
Owner:
grt@chromium.org
Closed: Apr 2016
Cc:
brucedaw...@chromium.org
█ brettw@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 354261



Sign in to add a comment

setup.exe is missing its version resource in GN build

Project Member Reported by grt@chromium.org, Apr 21 2016 
In the gyp build, it was generated by the 'setup_version' rule in the 'setup' target using the setup_exe_version.rc.version source.

Comment 1 by dpranke@chromium.org, Apr 21 2016

Blocking: 354261
Cc: brucedaw...@chromium.org
Components: Build

Comment 2 by grt@chromium.org, Apr 21 2016

Cc: brettw@chromium.org
Owner: grt@chromium.org
Status: Started (was: Available)
I'll take a stab.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40a09e787b4aba33fcd27672b4763fecf13c3623

commit 40a09e787b4aba33fcd27672b4763fecf13c3623
Author: grt <grt@chromium.org>
Date: Thu Apr 21 19:41:49 2016

Give setup.exe its version resource back in the GN build.

BUG= 605648 

Review URL: https://codereview.chromium.org/1910103002

Cr-Commit-Position: refs/heads/master@{#388855}

[modify] https://crrev.com/40a09e787b4aba33fcd27672b4763fecf13c3623/chrome/installer/setup/BUILD.gn

Comment 4 by grt@chromium.org, Apr 21 2016

Status: Fixed (was: Started)
►

Sign in to add a comment