New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605644 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Add runtime flag to enable material design in the Chrome OS system UI

Project Member Reported by tdander...@chromium.org, Apr 21 2016

Issue description

Add a runtime flag which can be used to toggle material design on/off in the Chrome OS system UI.
 
Cc: -varkha@chromium.org tdander...@chromium.org
Owner: varkha@chromium.org
Status: Assigned (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6a59711024115cb14728ca0dfdc2a1d507fa567

commit b6a59711024115cb14728ca0dfdc2a1d507fa567
Author: varkha <varkha@chromium.org>
Date: Thu Apr 28 00:50:41 2016

Adds ash::MaterialDesignController and a run-time flag

Adds "ash-enable-md" and "ash-disable-md" flags to enable / disable
Material Design in Chrome OS system UI.
ash::MaterialDesignController::IsMaterial() can be used to query the
mode at run-time.

BUG= 605644 

Review-Url: https://codereview.chromium.org/1921133002
Cr-Commit-Position: refs/heads/master@{#390260}

[modify] https://crrev.com/b6a59711024115cb14728ca0dfdc2a1d507fa567/ash/ash.gyp
[modify] https://crrev.com/b6a59711024115cb14728ca0dfdc2a1d507fa567/ash/ash_switches.cc
[modify] https://crrev.com/b6a59711024115cb14728ca0dfdc2a1d507fa567/ash/ash_switches.h
[add] https://crrev.com/b6a59711024115cb14728ca0dfdc2a1d507fa567/ash/material_design/material_design_controller.cc
[add] https://crrev.com/b6a59711024115cb14728ca0dfdc2a1d507fa567/ash/material_design/material_design_controller.h
[add] https://crrev.com/b6a59711024115cb14728ca0dfdc2a1d507fa567/ash/material_design/material_design_controller_unittest.cc
[modify] https://crrev.com/b6a59711024115cb14728ca0dfdc2a1d507fa567/ash/test/ash_test_helper.cc
[add] https://crrev.com/b6a59711024115cb14728ca0dfdc2a1d507fa567/ash/test/material_design_controller_test_api.cc
[add] https://crrev.com/b6a59711024115cb14728ca0dfdc2a1d507fa567/ash/test/material_design_controller_test_api.h
[modify] https://crrev.com/b6a59711024115cb14728ca0dfdc2a1d507fa567/chrome/app/generated_resources.grd
[modify] https://crrev.com/b6a59711024115cb14728ca0dfdc2a1d507fa567/chrome/browser/about_flags.cc
[modify] https://crrev.com/b6a59711024115cb14728ca0dfdc2a1d507fa567/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/b6a59711024115cb14728ca0dfdc2a1d507fa567/tools/metrics/histograms/histograms.xml

Comment 4 by varkha@chromium.org, Apr 28 2016

Cc: yiyix@chromium.org moh...@chromium.org
Status: Fixed (was: Assigned)
Can now use ash::MaterialDesignController::IsMaterial() or ash::MaterialDesignController::IsMaterialExperimental() to guard the MD features / assets / layout.

Comment 5 by varkha@chromium.org, Apr 29 2016

Description correction for #3, the flag is actually "--ash-md". HT to yiyix@.
chrome://flags/#ash-md
Verified on 8270.0.0 canary.

Related:  Issue 608353 
Status: Verified (was: Fixed)

Sign in to add a comment