PointerType of pointer event is not set on Windows |
|||||||||
Issue descriptionPointerType property of pointer events are not set on Windows for all input devices.
,
May 2 2016
No pointerType for mouse/stylus except when stylus taps, which creates a pointerType=mouse event. I could make touch work today on Windows. Navid, do you recall it working?
,
May 2 2016
I do recall it working for W3C tests but it wasn't working with that drawing demo we found. Could be the coordinates problem which was causing that drawing demo to draw outside of the canvas or something like that.
,
May 3 2016
,
May 4 2016
Looks like low-level events in Windows never have PointerDetails.pointer_type set to POINTER_TYPE_UNKNOWN, so there's a chance we are messing up the type at a higher level. https://code.google.com/p/chromium/codesearch#chromium/src/ui/events/win/events_win.cc&l=293
,
May 16 2016
,
May 16 2016
This is also a demo that uses the pointerTypes: https://david.blob.core.windows.net/html5/PECR/touchsample4.htm
,
May 20 2016
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a78e7138f7fce8ce8bfe75803bbf8c33877da9a commit 8a78e7138f7fce8ce8bfe75803bbf8c33877da9a Author: lanwei <lanwei@chromium.org> Date: Wed May 25 22:04:42 2016 Set PointerType of pointer event on Windows. Pointer event's PointerType did not set on Windows for mouse type when converting from ui::MouseEvent to blink::WebMouseEvent. In WebMouseEventBuilder::Build for Windows, I set the pointer type of WebMouseEvent. BUG= 605639 Review-Url: https://codereview.chromium.org/1993853002 Cr-Commit-Position: refs/heads/master@{#395999} [modify] https://crrev.com/8a78e7138f7fce8ce8bfe75803bbf8c33877da9a/content/browser/renderer_host/input/web_input_event_builders_win.cc [modify] https://crrev.com/8a78e7138f7fce8ce8bfe75803bbf8c33877da9a/content/browser/renderer_host/input/web_input_event_builders_win.h [modify] https://crrev.com/8a78e7138f7fce8ce8bfe75803bbf8c33877da9a/content/browser/renderer_host/input/web_input_event_unittest.cc [modify] https://crrev.com/8a78e7138f7fce8ce8bfe75803bbf8c33877da9a/content/browser/renderer_host/web_input_event_aura.cc [modify] https://crrev.com/8a78e7138f7fce8ce8bfe75803bbf8c33877da9a/content/browser/renderer_host/web_input_event_aurawin.cc
,
May 26 2016
,
May 26 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
May 26 2016
Please have a the CL merged by EOD tomorrow (05/27), so it gets tested for dev channel release scheduled on 06/02.
,
May 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8a16ac50c11d9325a4d20dbd617c721d13e180a commit b8a16ac50c11d9325a4d20dbd617c721d13e180a Author: lanwei <lanwei@chromium.org> Date: Fri May 27 16:10:16 2016 Set PointerType of pointer event on Windows. Pointer event's PointerType did not set on Windows for mouse type when converting from ui::MouseEvent to blink::WebMouseEvent. In WebMouseEventBuilder::Build for Windows, I set the pointer type of WebMouseEvent. BUG= 605639 Review-Url: https://codereview.chromium.org/1993853002 Cr-Commit-Position: refs/heads/master@{#395999} (cherry picked from commit 8a78e7138f7fce8ce8bfe75803bbf8c33877da9a) Review URL: https://codereview.chromium.org/2016383002 . Cr-Commit-Position: refs/branch-heads/2743@{#102} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/b8a16ac50c11d9325a4d20dbd617c721d13e180a/content/browser/renderer_host/input/web_input_event_builders_win.cc [modify] https://crrev.com/b8a16ac50c11d9325a4d20dbd617c721d13e180a/content/browser/renderer_host/input/web_input_event_builders_win.h [modify] https://crrev.com/b8a16ac50c11d9325a4d20dbd617c721d13e180a/content/browser/renderer_host/input/web_input_event_unittest.cc [modify] https://crrev.com/b8a16ac50c11d9325a4d20dbd617c721d13e180a/content/browser/renderer_host/web_input_event_aura.cc [modify] https://crrev.com/b8a16ac50c11d9325a4d20dbd617c721d13e180a/content/browser/renderer_host/web_input_event_aurawin.cc
,
May 27 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by nzolghadr@chromium.org
, Apr 21 2016