New issue
Advanced search Search tips

Issue 605639 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 583688



Sign in to add a comment

PointerType of pointer event is not set on Windows

Project Member Reported by nzolghadr@chromium.org, Apr 21 2016

Issue description

PointerType property of pointer events are not set on Windows for all input devices.
 
Blocking: 583688
Labels: OS-Windows
No pointerType for mouse/stylus except when stylus taps, which creates a pointerType=mouse event.

I could make touch work today on Windows. Navid, do you recall it working?

I do recall it working for W3C tests but it wasn't working with that drawing demo we found. Could be the coordinates problem which was causing that drawing demo to draw outside of the canvas or something like that.
Labels: -Pri-3 M-52 Pri-1
Looks like low-level events in Windows never have PointerDetails.pointer_type set to POINTER_TYPE_UNKNOWN, so there's a chance we are messing up the type at a higher level.

https://code.google.com/p/chromium/codesearch#chromium/src/ui/events/win/events_win.cc&l=293

Cc: nzolghadr@chromium.org
Owner: lanwei@chromium.org
This is also a demo that uses the pointerTypes:

https://david.blob.core.windows.net/html5/PECR/touchsample4.htm

Comment 8 by lanwei@chromium.org, May 20 2016

Status: Started (was: Assigned)
Labels: Merge-Request-52

Comment 11 by tin...@google.com, May 26 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Please have a the CL merged by EOD tomorrow (05/27), so it gets tested for dev channel release scheduled on 06/02.
Project Member

Comment 13 by bugdroid1@chromium.org, May 27 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8a16ac50c11d9325a4d20dbd617c721d13e180a

commit b8a16ac50c11d9325a4d20dbd617c721d13e180a
Author: lanwei <lanwei@chromium.org>
Date: Fri May 27 16:10:16 2016

Set PointerType of pointer event on Windows.

Pointer event's PointerType did not set on Windows for mouse type when converting from
ui::MouseEvent to blink::WebMouseEvent.
In WebMouseEventBuilder::Build for Windows, I set the pointer type of WebMouseEvent.

BUG= 605639 

Review-Url: https://codereview.chromium.org/1993853002
Cr-Commit-Position: refs/heads/master@{#395999}
(cherry picked from commit 8a78e7138f7fce8ce8bfe75803bbf8c33877da9a)

Review URL: https://codereview.chromium.org/2016383002 .

Cr-Commit-Position: refs/branch-heads/2743@{#102}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/b8a16ac50c11d9325a4d20dbd617c721d13e180a/content/browser/renderer_host/input/web_input_event_builders_win.cc
[modify] https://crrev.com/b8a16ac50c11d9325a4d20dbd617c721d13e180a/content/browser/renderer_host/input/web_input_event_builders_win.h
[modify] https://crrev.com/b8a16ac50c11d9325a4d20dbd617c721d13e180a/content/browser/renderer_host/input/web_input_event_unittest.cc
[modify] https://crrev.com/b8a16ac50c11d9325a4d20dbd617c721d13e180a/content/browser/renderer_host/web_input_event_aura.cc
[modify] https://crrev.com/b8a16ac50c11d9325a4d20dbd617c721d13e180a/content/browser/renderer_host/web_input_event_aurawin.cc

Status: Fixed (was: Started)

Sign in to add a comment