New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605623 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

collect_crashinfo_execute broken for ADBHost

Project Member Reported by kevcheng@chromium.org, Apr 21 2016

Issue description

https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/60753935-chromeos-test/brillo-row1-legorack3-b1e12318/

We get a stack trace where it seems the serial isn't passed in or gathered.

04:13:48 ERROR| Traceback (most recent call last):
04:13:48 ERROR|   File "/usr/local/autotest/server/autoserv", line 547, in run_autoserv
04:13:48 ERROR|     use_packaging=(not no_use_packaging))
04:13:48 ERROR|   File "/usr/local/autotest/server/site_server_job.py", line 65, in run
04:13:48 ERROR|     super(site_server_job, self).run(*args, **dargs)
04:13:48 ERROR|   File "/usr/local/autotest/server/server_job.py", line 716, in run
04:13:48 ERROR|     self._execute_code(CRASHINFO_CONTROL_FILE, namespace)
04:13:48 ERROR|   File "/usr/local/autotest/server/server_job.py", line 1182, in _execute_code
04:13:48 ERROR|     execfile(code_file, namespace, namespace)
04:13:48 ERROR|   File "/usr/local/autotest/server/control_segments/crashinfo", line 14, in <module>
04:13:48 ERROR|     job.parallel_simple(crashinfo, machines, log=False)
04:13:48 ERROR|   File "/usr/local/autotest/server/server_job.py", line 574, in parallel_simple
04:13:48 ERROR|     return_results=return_results)
04:13:48 ERROR|   File "/usr/local/autotest/server/subcommand.py", line 93, in parallel_simple
04:13:48 ERROR|     function(arg)
04:13:48 ERROR|   File "/usr/local/autotest/server/control_segments/crashinfo", line 10, in crashinfo
04:13:48 ERROR|     host = hosts.create_host(machine, initialize=False, auto_monitor=False)
04:13:48 ERROR|   File "/usr/local/autotest/server/hosts/factory.py", line 160, in create_host
04:13:48 ERROR|     host_instance = host_class(hostname, **args)
04:13:48 ERROR|   File "/usr/local/autotest/server/hosts/base_classes.py", line 58, in __init__
04:13:48 ERROR|     super(Host, self).__init__(*args, **dargs)
04:13:48 ERROR|   File "/usr/local/autotest/client/common_lib/hosts/base_classes.py", line 70, in __init__
04:13:48 ERROR|     self._initialize(*args, **dargs)
04:13:48 ERROR|   File "/usr/local/autotest/server/hosts/adb_host.py", line 209, in _initialize
04:13:48 ERROR|     adb_prefix = any(adb_serial.startswith(p) for p in ADB_DEVICE_PREFIXES)
04:13:48 ERROR|   File "/usr/local/autotest/server/hosts/adb_host.py", line 209, in <genexpr>
04:13:48 ERROR|     adb_prefix = any(adb_serial.startswith(p) for p in ADB_DEVICE_PREFIXES)
04:13:48 ERROR| AttributeError: 'NoneType' object has no attribute 'startswith'
 

Comment 1 by sbasi@chromium.org, Apr 26 2016

Cc: -dshi@chromium.org bryanlew@chromium.org
+Bryan who will be looking at crash collection.
I think Dan's cl fixes this: https://chromium-review.googlesource.com/#/c/340761/

Comment 3 by benhenry@google.com, Apr 26 2016

Components: Infra>Client>ChromeOS
Labels: -Infra-ChromeOS
Cc: dshi@chromium.org kevcheng@chromium.org
 Issue 612494  has been merged into this issue.
Owner: bryanlew@chromium.org
My mistake, Dan's cl fixes the stack trace but the serial still isn't passed in.  This still needs fixing.

Assigning to Bryan to continue his investigation.
Status: WontFix (was: Untriaged)
Obsolete

Sign in to add a comment