New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605609 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature

Blocking:
issue 487345



Sign in to add a comment

Require videos to be visible in order to start playback

Project Member Reported by mlamouri@chromium.org, Apr 21 2016

Issue description

The videos should only play if they are partially visible.

We might want to keep this as part of the autoplay experiments for now.
 
I see that there is a -ifviewport autoplay experiment. I'm not entirely sure but it doesn't seem to be partial visibility. What does it exactly implement?
it requires that the entire element is visible, or at least fills the space it has if it's too wide / tall to fit.
I think we want visibility to be defined as partially visible (ie. at least 1x1 area). My understanding is that the consensus was about doing that.

renganathan@, do you confirm?

Comment 4 Deleted

Comment 5 Deleted

Labels: Proj-Autoplay
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fafc5a0d288d30ad051e9269d6bdac1f79ed2f5b

commit fafc5a0d288d30ad051e9269d6bdac1f79ed2f5b
Author: liberato <liberato@chromium.org>
Date: Tue Apr 26 16:27:45 2016

Add partial viewport visibility check to autoplay experiment.

Adds -ifpartialviewport to require 1x1 overlap of the media element
with the viewport area, before autoplay is allowed.  This differs
from -ifviewport, which requires the element to be completely visible
within the viewport.

BUG= 605609 

Review URL: https://codereview.chromium.org/1921073002

Cr-Commit-Position: refs/heads/master@{#389802}

[modify] https://crrev.com/fafc5a0d288d30ad051e9269d6bdac1f79ed2f5b/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.cpp
[modify] https://crrev.com/fafc5a0d288d30ad051e9269d6bdac1f79ed2f5b/third_party/WebKit/Source/core/html/AutoplayExperimentHelper.h

Status: Fixed (was: Assigned)

Sign in to add a comment