New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605605 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 3
Type: Bug

Blocking:
issue 505734



Sign in to add a comment

remove remaining valgrind references

Project Member Reported by dpranke@chromium.org, Apr 21 2016

Issue description

We've decided to stop regularly running valgrind.

This bug will be used to track shutting down the
bots and other cleanup-related work.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/2ccb8e41251de1a578d10f54a5b7a311162b2fad

commit 2ccb8e41251de1a578d10f54a5b7a311162b2fad
Author: dpranke@chromium.org <dpranke@chromium.org>
Date: Thu Apr 21 20:43:54 2016

Delete chromium valgrind bots.

R=thestig@chromium.org, jam@chromium.org
BUG=605605

Review URL: https://codereview.chromium.org/1902423008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300091 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/2ccb8e41251de1a578d10f54a5b7a311162b2fad/masters/master.chromium.memory.fyi/master.cfg
[modify] https://crrev.com/2ccb8e41251de1a578d10f54a5b7a311162b2fad/masters/master.chromium.memory.fyi/notifier_cfg.py
[modify] https://crrev.com/2ccb8e41251de1a578d10f54a5b7a311162b2fad/masters/master.chromium.memory.fyi/slaves.cfg
[modify] https://crrev.com/2ccb8e41251de1a578d10f54a5b7a311162b2fad/masters/master.tryserver.chromium.linux/master.cfg
[modify] https://crrev.com/2ccb8e41251de1a578d10f54a5b7a311162b2fad/masters/master.tryserver.chromium.linux/slaves.cfg
[modify] https://crrev.com/2ccb8e41251de1a578d10f54a5b7a311162b2fad/scripts/slave/gatekeeper.json
[modify] https://crrev.com/2ccb8e41251de1a578d10f54a5b7a311162b2fad/scripts/slave/recipe_modules/chromium_tests/chromium_memory_fyi.py
[modify] https://crrev.com/2ccb8e41251de1a578d10f54a5b7a311162b2fad/scripts/slave/recipe_modules/chromium_tests/trybots.py
[delete] https://crrev.com/e7dc20e84bf6fbed29d4a13dfa11d3f3001f446b/scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Chromium_Linux_Builder__valgrind_.json
[delete] https://crrev.com/e7dc20e84bf6fbed29d4a13dfa11d3f3001f446b/scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Linux_Tests__valgrind__1_.json
[delete] https://crrev.com/e7dc20e84bf6fbed29d4a13dfa11d3f3001f446b/scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Linux_Tests__valgrind__2_.json
[delete] https://crrev.com/e7dc20e84bf6fbed29d4a13dfa11d3f3001f446b/scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Linux_Tests__valgrind__3_.json
[delete] https://crrev.com/e7dc20e84bf6fbed29d4a13dfa11d3f3001f446b/scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Linux_Tests__valgrind__4_.json
[delete] https://crrev.com/e7dc20e84bf6fbed29d4a13dfa11d3f3001f446b/scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Linux_Tests__valgrind__5_.json
[delete] https://crrev.com/e7dc20e84bf6fbed29d4a13dfa11d3f3001f446b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_valgrind.json

Cc: thakis@chromium.org
Labels: -Pri-2 Pri-3

Comment 3 by thakis@chromium.org, Jun 13 2016

https://codereview.chromium.org/2062813002/ – thestig says "let's wait a quarter or two"
Owner: thakis@chromium.org
Status: Assigned (was: Started)
Summary: remove remaining valgrind references (was: shut down the valgrind bots and delete everything valgrind-related)
I'm punting this to thakis@ since it's his CL we're waiting on, and updating the bug subject to "remove remaining valgrind references".
~80 more Valgrind bugs to grind through.

Comment 6 by thakis@chromium.org, Jul 29 2016

Owner: thestig@chromium.org
I'm punting this to thestig since we're waiting on my cl since he wants us to wait :-)

Comment 8 by kochi@chromium.org, Jul 14 2017

Hi, I'm assigned to  issue 505734 , which is drmemory failure.

The scripts used for drmemory are removed by above change.
http://dev.chromium.org/developers/how-tos/using-drmemory
(specifically, tools/valgrind/chrome_tests.bat)

Does it mean we no longer care about memory failures? :-)
Seriously, how can I use drmemory on Windows?
(I don't yet understand the relationship between valgrind and drmemory, though)

Comment 9 by kochi@chromium.org, Jul 14 2017

Blocking: 505734
I thought we no longer had DrMemory bots (?)

Comment 11 by kochi@chromium.org, Jul 18 2017

Oh well... I'll contact the internal team responsible for it.
Re #10: that's correct.
Re #11: I don't think there is such a team. Unfortunately cleanups like this tend to be hard to convince people to do.

Comment 13 by kochi@chromium.org, Jul 27 2017

Re #12 at the bottom of http://dev.chromium.org/developers/how-tos/using-drmemory,

> Feedback?
> Drop drmemory-team@ a message

Though I sent a mail a week ago, I got no reply :)
So you may be correct, there is no team?

I just added the wiki page one-line notice about deprecation.
If it's anything wrong, feel free to correct it.
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05e28044610163f7a9b6a9c729023a1d97b3dadc

commit 05e28044610163f7a9b6a9c729023a1d97b3dadc
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Apr 17 17:34:13 2018

Remove a reference to Valgrind in DiskCacheBackendTest.

Valgrind bots are gone.

BUG=605605

Change-Id: Ie722b831d0a6fca8b48620e5a9d993896346cbef
Reviewed-on: https://chromium-review.googlesource.com/1014956
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551376}
[modify] https://crrev.com/05e28044610163f7a9b6a9c729023a1d97b3dadc/net/disk_cache/backend_unittest.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c42a51bf190e38237536e1a3ea509a68bd644b2f

commit c42a51bf190e38237536e1a3ea509a68bd644b2f
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Apr 24 02:35:53 2018

Remove Valgrind bits from build/android/pylib/valgrind_tools.py.

ASAN bits remain.

BUG=605605

Change-Id: I57252e03f569e8f605bdaa01e0aaf97455e5e761
Reviewed-on: https://chromium-review.googlesource.com/1014955
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552970}
[modify] https://crrev.com/c42a51bf190e38237536e1a3ea509a68bd644b2f/build/android/pylib/valgrind_tools.py

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1a8a8ff67b1953c40a33b7fb5d1a36f2eef3e68

commit c1a8a8ff67b1953c40a33b7fb5d1a36f2eef3e68
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Apr 24 12:50:41 2018

Remove tools/valgrind.

BUG=605605

Change-Id: I22f0c4a6fe06ec3d76359f2559e532e155c53815
Reviewed-on: https://chromium-review.googlesource.com/1014677
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553062}
[modify] https://crrev.com/c1a8a8ff67b1953c40a33b7fb5d1a36f2eef3e68/WATCHLISTS
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/.gitignore
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/common.py
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/fixed_suppressions.sh
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gdb_helper.py
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/OWNERS
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/ash_unittests.gtest-memcheck.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/aura_unittests.gtest.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/base_unittests.gtest.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/base_unittests.gtest_win-8.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/base_unittests.gtest_win32.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/blink_platform_unittests.gtest_win32.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/browser_tests.gtest-memcheck.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/chromeos_unittests.gtest.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/components_unittests.gtest.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/content_unittests.gtest.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/extensions_unittests.gtest-memcheck.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/interactive_ui_tests.gtest.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/ipc_tests.gtest.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/media_unittests.gtest.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/message_center_unittests.gtest.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/net_unittests.gtest-memcheck.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/net_unittests.gtest.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/net_unittests.gtest_linux.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/remoting_unittests.gtest_win-8.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/sandbox_linux_unittests.gtest.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/suppressions.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/sync_unit_tests.gtest-asan.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/ui_base_unittests.gtest-memcheck.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/ui_unittests.gtest-memcheck_linux.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/unit_tests.gtest-memcheck.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/gtest_exclude/unit_tests.gtest.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/memcheck/OWNERS
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/memcheck/PRESUBMIT.py
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/memcheck/suppressions.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/memcheck/suppressions_linux.txt
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/memcheck_analyze.py
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/regrind.sh
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/scan-build.py
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/suppressions.py
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/test_suppressions.py
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/unused_suppressions.py
[delete] https://crrev.com/140e3855b3c64993126f51f0da027452ec0ca65d/tools/valgrind/waterfall.sh

Cc: glider@chromium.org most...@vewd.com
What's left to do here? Land https://chromium-review.googlesource.com/c/chromium/src/+/817283 ? Look through infra code?

tools/valgrind/asan still lives, BTW.
Project Member

Comment 18 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cae7b37c9f6c290befa918ada00c1d13181abe79

commit cae7b37c9f6c290befa918ada00c1d13181abe79
Author: Lei Zhang <thestig@chromium.org>
Date: Mon May 07 19:18:48 2018

Remove Valgrind references in tests.

BUG= 545740 ,605605

Change-Id: I047e356e1284d2002bb2f6566dd1876cc5987059
Reviewed-on: https://chromium-review.googlesource.com/1038887
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556522}
[modify] https://crrev.com/cae7b37c9f6c290befa918ada00c1d13181abe79/content/browser/webrtc/webrtc_browsertest.cc
[modify] https://crrev.com/cae7b37c9f6c290befa918ada00c1d13181abe79/media/cast/test/end2end_unittest.cc

Also, is base/third_party/dynamic_annotations still actually used, or was that for TSANv1 only? It hasn't been updated since 2011.

Sign in to add a comment