I have a CL up to add a background: https://codereview.chromium.org/2050813002/

Still to do:
* Expand/collapse animations
* Different icons?

As of patchset 1 of that CL.

Deleted: Screen Shot 2016-06-08 at 3.41.22 PM.png 14.3 KB

	Screen Shot 2016-06-08 at 3.41.22 PM.png 14.3 KB View Download

Per shrike@, we should switch to IDR_BOOKMARK_BAR_FOLDER for the folder icons from what we have now.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df230152824bb04c6a7d520ecc77e24b9c02eaa1

commit df230152824bb04c6a7d520ecc77e24b9c02eaa1
Author: ellyjones <ellyjones@chromium.org>
Date: Tue Aug 23 16:25:21 2016

MacViews: support backgrounds for selected rows

This change adds support to TreeView for drawing a background on the entire
selected row instead of just behind the label of the selected row, controlled
by PlatformStyle::kTreeViewSelectsEntireRow.

Incidentally, this CL fixes the views_unittests build with gn so that this CL can be tested.

This CL is heavily inspired by https://codereview.chromium.org/1364423002/.

BUG=605589

Review-Url: https://codereview.chromium.org/2050813002
Cr-Commit-Position: refs/heads/master@{#413755}

[modify] https://crrev.com/df230152824bb04c6a7d520ecc77e24b9c02eaa1/ui/views/controls/tree/tree_view.cc
[modify] https://crrev.com/df230152824bb04c6a7d520ecc77e24b9c02eaa1/ui/views/controls/tree/tree_view.h
[modify] https://crrev.com/df230152824bb04c6a7d520ecc77e24b9c02eaa1/ui/views/style/platform_style.cc
[modify] https://crrev.com/df230152824bb04c6a7d520ecc77e24b9c02eaa1/ui/views/style/platform_style.h
[modify] https://crrev.com/df230152824bb04c6a7d520ecc77e24b9c02eaa1/ui/views/style/platform_style_mac.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433

commit 8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433
Author: ellyjones <ellyjones@chromium.org>
Date: Mon Oct 17 12:21:42 2016

views: add focus ring to TreeView

When TreeView is focused, there should be a focus ring around the control,
at least on Mac. This is mildly complicated because TreeViews are often
hosted in a ScrollView, and in that case the focus ring should go around
the ScrollView instead of the TreeView so the focus ring does not scroll.

BUG=605589, 647515 

Review-Url: https://codereview.chromium.org/2411693002
Cr-Commit-Position: refs/heads/master@{#425662}

[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/controls/focus_ring.cc
[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/controls/focus_ring.h
[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/controls/scroll_view.cc
[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/controls/scroll_view.h
[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/controls/tree/tree_view.cc
[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/controls/tree/tree_view.h
[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/style/platform_style.cc
[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/style/platform_style.h
[modify] https://crrev.com/8cbab2b4e38a3eeb48d76f7cf839d18d6a0fc433/ui/views/style/platform_style_mac.mm

Tacking a few things on and cc'ing shrike@ as requested, let me know if I should make separate bugs instead.

- option+arrow should recursively expand/collapse rows
- A row's icon shouldn't change depending on whether it's selected. I think it's valid but uncommon to have different icons for closed/open.
- Multiple selection with shift/command should be possible.

> - A row's icon shouldn't change depending on whether it's selected. I think it's valid but uncommon to have different icons for closed/open.

This is  Issue 649003  (for the record).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7742bafdff7eb65a0528f68a37545da0a89be113

commit 7742bafdff7eb65a0528f68a37545da0a89be113
Author: ellyjones <ellyjones@chromium.org>
Date: Thu Mar 23 21:18:38 2017

views: don't use open-folder icons in TreeView on Mac

Native Cocoa TreeViews do not have this behavior, so disable it in Views
TreeViews on Mac also.

BUG=605589

Review-Url: https://codereview.chromium.org/2772613003
Cr-Commit-Position: refs/heads/master@{#459222}

[modify] https://crrev.com/7742bafdff7eb65a0528f68a37545da0a89be113/ui/views/controls/tree/tree_view.cc
[modify] https://crrev.com/7742bafdff7eb65a0528f68a37545da0a89be113/ui/views/style/platform_style.cc
[modify] https://crrev.com/7742bafdff7eb65a0528f68a37545da0a89be113/ui/views/style/platform_style.h
[modify] https://crrev.com/7742bafdff7eb65a0528f68a37545da0a89be113/ui/views/style/platform_style_mac.mm

I don't know how to triage MacViews in depth, so not changing owner/priority.  This hasn't been touched in a while; please retriage.

This is not a MacViews-specific bug, but it was wrongly tagged as one. This bug is actually for deciding what Harmony treeviews ought to look like. I'm happy to do the needed control work but I think we need UX input.

Can you write up any specific questions there are about TreeView appearance?  I didn't realize we had decisions to make here.

Raising priority of this because it's not clear to me what action needs taking here, so I don't know how to triage.  Is all work here being done under bug 610428 (so this should just be closed)?  Is there further work beyond that, but it can be punted to phase 2, so this should be P3?

Elly, I think you have the most engineering context on this, so leaving this assigned to you.

The needful bits of TreeView for phase 1 are done already. This bug should stay open, because I think UX wants to rethink how TreeViews work a bit, but there's no further phase 1 work, so I'll Pri-3 it.

MacViews triage: this is a MacViews-Controls bug, but M-X.

***UI Mass Triage ***
Adding labels for expert review.