New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605556 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 597564



Sign in to add a comment

WebView crash when trying to set a null Cookie

Project Member Reported by bauerb@chromium.org, Apr 21 2016

Issue description

WebView apps are crashing when trying to invoke CookieManager.setCookie() with a null cookie. This is due to https://codereview.chromium.org/1828193002, which is in the M51 branch. Internal bug: b/28091262
 

Comment 1 by bauerb@chromium.org, Apr 21 2016

Labels: -OS-Linux
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72266b1cc2f117c2612514e53b6316bbec916a7e

commit 72266b1cc2f117c2612514e53b6316bbec916a7e
Author: bauerb <bauerb@chromium.org>
Date: Thu Apr 21 16:25:36 2016

[WebView] Don't try to set cookies with null values.

BUG= 605556 

Review URL: https://codereview.chromium.org/1903203002

Cr-Commit-Position: refs/heads/master@{#388786}

[modify] https://crrev.com/72266b1cc2f117c2612514e53b6316bbec916a7e/android_webview/glue/java/src/com/android/webview/chromium/CookieManagerAdapter.java

Comment 3 by bauerb@chromium.org, Apr 21 2016

Labels: Merge-Request-51

Comment 4 by tin...@google.com, Apr 21 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 22 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2558d75c7a6b83c9bc2fefdf715634e3b37760c7

commit 2558d75c7a6b83c9bc2fefdf715634e3b37760c7
Author: Bernhard Bauer <bauerb@chromium.org>
Date: Fri Apr 22 09:31:50 2016

[WebView] Don't try to set cookies with null values.

BUG= 605556 

Review URL: https://codereview.chromium.org/1903203002

Cr-Commit-Position: refs/heads/master@{#388786}
(cherry picked from commit 72266b1cc2f117c2612514e53b6316bbec916a7e)

Review URL: https://codereview.chromium.org/1912083002 .

Cr-Commit-Position: refs/branch-heads/2704@{#178}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/2558d75c7a6b83c9bc2fefdf715634e3b37760c7/android_webview/glue/java/src/com/android/webview/chromium/CookieManagerAdapter.java

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 23 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/22c7d8dda595e49c88da0e6e4b56e204d183b88f

commit 22c7d8dda595e49c88da0e6e4b56e204d183b88f
Author: bauerb <bauerb@chromium.org>
Date: Thu Apr 21 16:25:36 2016

Comment 7 by torne@chromium.org, May 5 2016

Blocking: 597564

Comment 8 by torne@chromium.org, May 5 2016

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/82b8f9de2000abd0e122e27445d3bf7320cf80b6

commit 82b8f9de2000abd0e122e27445d3bf7320cf80b6
Author: bauerb <bauerb@chromium.org>
Date: Thu Apr 21 16:25:36 2016

Sign in to add a comment