New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 605553 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

smoothness.tough_canvas_cases[.reference] very flaky on Mac HDD Perf (3)

Project Member Reported by petrcermak@chromium.org, Apr 21 2016

Issue description

Revision range first seen: 383454:383455 (beginning of the bots history)
Bot: https://build.chromium.org/p/chromium.perf/builders/Mac%20HDD%20Perf%20(3)
Build: https://build.chromium.org/p/chromium.perf/builders/Mac%20HDD%20Perf%20%283%29/builds/1364
Link to failing step log: https://build.chromium.org/p/chromium.perf/builders/Mac%20HDD%20Perf%20%283%29/builds/1364/steps/smoothness.tough_canvas_cases/logs/stdio

The benchmark fails due to various native crashes on various URLs:

Standard output:
********************************************************************************
	2016-04-21 03:10:14.218 Google Chrome[14323:126012] NSWindow warning: adding an unknown subview: <FullSizeContentView: 0x7fbefbc50c40>
	2016-04-21 03:10:14.218 Google Chrome[14323:126012] Call stack:
	(
	    "+callStackSymbols disabled for performance reasons"
	)
	<<<< VTVideoEncoderSelection >>>> VTSelectAndCreateVideoEncoderInstanceInternal: no video encoder found for 'avc1'
	
	[10:10:14.671] VTSelectAndCreateVideoEncoderInstanceInternal signalled err=-12908 (err) (Video encoder not available) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.238/Sources/VideoToolbox/VTVideoEncoderSelection.c line 1245
	[10:10:14.671] VTCompressionSessionCreate signalled err=-12908 (err) (Could not select and open encoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.238/Sources/VideoToolbox/VTCompressionSession.c line 946
********************************************************************************

If the test is disabled, please downgrade to Pri-2.

 
Cc: -junov@chromium.org
Owner: junov@chromium.org
The disabling patch failed to get through the CQ (for unrelated reasons) and the frequency of the flakes reduced a lot, so I'm NOT going to disable the benchmark now, but I'll re-assign this bug to the benchmark owner instead. Please land the disabling patch (https://codereview.chromium.org/1910483005/) if the frequency flakes increases again.
Labels: -Pri-1 Pri-2
Status: Assigned (was: Untriaged)
Labels: -Pri-2 Pri-1
We're still getting flakes on Mac 10.10 Perf (3). Here all the native crashes happen on ../../../chrome/test/data/perf/canvas_bench/many_images.html:

Standard output:
********************************************************************************
	2016-06-18 00:30:11.239 Google Chrome[12950:55306] NSWindow warning: adding an unknown subview: <FullSizeContentView: 0x7f99eaddab80>
	2016-06-18 00:30:11.239 Google Chrome[12950:55306] Call stack:
	(
	    "+callStackSymbols disabled for performance reasons"
	)
	[12960:30003:0618/003033:ERROR:ffmpeg_demuxer.cc(1495)] OnReadFrameDone result=-541478725 IsMaxMemoryUsageReached=0
	[12985:26143:0618/003302:ERROR:ffmpeg_demuxer.cc(1495)] OnReadFrameDone result=-541478725 IsMaxMemoryUsageReached=0
	[12985:26143:0618/003307:ERROR:ffmpeg_demuxer.cc(1495)] OnReadFrameDone result=-541478725 IsMaxMemoryUsageReached=0
********************************************************************************

Latest failing build: https://build.chromium.org/p/chromium.perf/builders/Mac%2010.10%20Perf%20%283%29/builds/3150

There were only 3 flakes in the past 20 builds, so, for the time being, I'm NOT going to disable the benchmark per perf bot sheriffing instructions (https://chromium.googlesource.com/chromium/src/+/master/tools/perf/docs/perf_bot_sheriffing.md).

junov@ (benchmark owner): Please decide what should be done next.

Comment 5 by junov@chromium.org, Jun 21 2016

I am going to try downsizing the test.  It uses an extremely large working set of images, which may be creating an unreasonable amount of memory pressure. After all, this is a benchmark, not a robustness test.

Comment 6 by junov@chromium.org, Jun 21 2016

Status: Started (was: Assigned)
Patch landed. It's a speculative fix, so let's let it bake for a day or two before declaring victory.
Cc: petrcermak@chromium.org
junov: Since this also affects the reference builds, I suspect we disable smoothness.tough_canvas_cases on mac-reference and re-enable it in a couple of weeks when the fix rolls into stable (assuming the issue is now fixed). Sounds good?

Comment 8 by junov@chromium.org, Jun 22 2016

I don't understand the logic of that. What is the problem with leaving the test enabled?
The point is that we don't want benchmark failures to cause redness on the perf waterfall (http://build.chromium.org/p/chromium.perf/console). Since this issue won't be fixed in reference builds until your fix propagates all the way to Chrome Stable, the benchmark will be flaky on the waterfall (unless we disable it).
Labels: Performance-Sheriff-BotHealth
Looks like this test is still being very flaky on the reference build. However we're just about to update the reference builds to 52.0.2743.116 (https://codereview.chromium.org/2226243004/). Does that contain the fix? If yes, then we can just sit tight -- otherwise I think we should disable the test.
Cc: aiolos@chromium.org
Ping!

I believe aiolos@ rolled the reference build last week.
Status: Fixed (was: Started)
It has been over a month since the last update. Seems fixed?

Marking as fixed. Re-open if needed.

Sign in to add a comment