New issue
Advanced search Search tips

Issue 605552 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 394770



Sign in to add a comment

HTMLAreaElement lacks couple attributes

Reported by shvaikal...@gmail.com, Apr 21 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2712.0 Safari/537.36

Steps to reproduce the problem:
1. var area = document.createElement("area")
2. "download" in area // => false
3. "rel" in area // => false

What is the expected behavior?
2. true
3. true

HTMLAreaElement should define `download` and `rel` attributes for faster access (w/o setAttribute).

Firefox implements both of them, Safari/Edge has only `rel` (WebKit has no `download` yet).

What went wrong?
implementing the spec

Did this work before? No 

Chrome version: 52.0.2712.0  Channel: n/a
OS Version: OS X 10.11.4
Flash Version: Shockwave Flash 21.0 r0

https://html.spec.whatwg.org/multipage/embedded-content.html#the-area-element
https://www.w3.org/TR/html5/embedded-content-0.html#the-area-element
 

Comment 1 by rsesek@chromium.org, Apr 21 2016

Components: Blink>HTML>Area
Labels: Hotlist-Interop
Owner: dominicc@chromium.org
Status: Available (was: Unconfirmed)
Anyone please feel free to poach.
Is only MAC OS affected by this issue? I checked on Linux version - on Firefox both properties are defined but empty, on Chrome both are undefined.

I can fix it to have similar behavior with Firefox.
I have checked on Windows, same issue there: IDL props are not defined. Fix would be nice: some code out there that works with/polyfills `download` may break on `area`s.
OK, got it, will fix it.
There was FIXME in the IDL file actually. It also mentions relList 
but I couldn't find it in the spec: https://www.w3.org/TR/html5/links.html#linkTypes
WhatWG LS defines `relList` for `a`, `area` and `link` elements:
https://html.spec.whatwg.org/multipage/embedded-content.html#the-area-element
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bf0830d9b2964a57c2fceced5e873b31d8f91d5

commit 0bf0830d9b2964a57c2fceced5e873b31d8f91d5
Author: a.obzhirov <a.obzhirov@samsung.com>
Date: Wed Jul 20 13:06:42 2016

HTMLAreaElement should expose `download` and `rel` attributes.

HTMLAreaElement should define IDL `download` and `rel` attributes for faster access.
Firefox implements both of them, Safari/Edge has only `rel` (WebKit has no `download` yet).

BUG= 605552 

Review-Url: https://codereview.chromium.org/2050643002
Cr-Commit-Position: refs/heads/master@{#406541}

[add] https://crrev.com/0bf0830d9b2964a57c2fceced5e873b31d8f91d5/third_party/WebKit/LayoutTests/fast/dom/HTMLAreaElement/area-download-expected.txt
[add] https://crrev.com/0bf0830d9b2964a57c2fceced5e873b31d8f91d5/third_party/WebKit/LayoutTests/fast/dom/HTMLAreaElement/area-download.html
[modify] https://crrev.com/0bf0830d9b2964a57c2fceced5e873b31d8f91d5/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/0bf0830d9b2964a57c2fceced5e873b31d8f91d5/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0bf0830d9b2964a57c2fceced5e873b31d8f91d5/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/0bf0830d9b2964a57c2fceced5e873b31d8f91d5/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0bf0830d9b2964a57c2fceced5e873b31d8f91d5/third_party/WebKit/Source/core/html/HTMLAreaElement.idl

There is a patch (https://codereview.chromium.org/400763002/)
already with should add relList to a element. May be I can expand it for area element as well.
Components: Blink>HTML>Map

Comment 12 by tkent@chromium.org, Jun 14 2017

Blockedon: 394770
It seems the remaining is only relList, and it is covered by  Issue 394770 .

Owner: ----
Bulk edit bugs owned by dominicc@

Comment 14 by brat...@opera.com, May 29 2018

Status: Fixed (was: Available)
bhagirathi.s@samsung.com> fixed this in 394770 4-5 months ago.

Sign in to add a comment