New issue
Advanced search Search tips

Issue 605551 link

Starred by 1 user
Status: Fixed
Owner:
agrieve@chromium.org
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Don't build targets for Android that aren't meant for Android

Project Member Reported by agrieve@chromium.org, Apr 21 2016 
There are many targets that end up being compiled on android bots that don't work on android. Mainly:

1. test() targets that don't pass
2. executable() that make sense only on the host machine

Our GN bots build all targets, so it's important to put unused targets behind if (!is_android) {}
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db0b5f0a1dd6a4fe48fce44d518c0bebfe4344d4

commit db0b5f0a1dd6a4fe48fce44d518c0bebfe4344d4
Author: agrieve <agrieve@chromium.org>
Date: Fri Apr 22 00:19:48 2016

Don't build khronos_glcts_test on Android

It doesn't pass, so we shouldn't be compiling it

BUG= 605551 , 550667, 550665
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1904083002

Cr-Commit-Position: refs/heads/master@{#388969}

[modify] https://crrev.com/db0b5f0a1dd6a4fe48fce44d518c0bebfe4344d4/BUILD.gn
[modify] https://crrev.com/db0b5f0a1dd6a4fe48fce44d518c0bebfe4344d4/gpu/khronos_glcts_support/BUILD.gn

Comment 2 by agrieve@chromium.org, Apr 22 2016

Status: Fixed (was: Started)
Not going to pursue this any further, so closing.
►

Sign in to add a comment